Issue metadata
Sign in to add a comment
|
Page Info sound icon is inconsistent with other icons |
||||||||||||||||||||||||
Issue descriptionChrome 62.0.3196.0 macOS 10.12.6 What steps will reproduce the problem? (1) Launch Chrome with --enable-features=SoundContentSetting (2) Open Page Info The sound icon has the following inconsistencies with the other icons - #141414 instead of #5a5a5a - Blurry @2x. [1] - The blocked icon uses a slash instead of a red box with "X". [1] steimel@, could you please replace these? Let me know if you need help getting the proper assets. [1] https://cs.chromium.org/chromium/src/chrome/app/theme/default_200_percent/common/blocked_sound.png
,
Aug 25 2017
Good eye. Yeah, these are temporary icons that I put in while we await the right ones. There was a discussion with UX, and it seems that they in the middle of switching the page info icons to vector sources ( crbug.com/647551 ), and would rather wait until that work is completed before creating this icon (to avoid duplicating work). We will not launch this feature until we receive those icons. Thanks!
,
Aug 28 2017
Sounds good! Would you mind marking this bug as a blocker for the sound permission launch bug, too?
,
Aug 28 2017
,
Aug 29 2017
No longer blocked on vector sources bug, as we received the icons (non-vector source)
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1675106c2d5122868b6b350ccd696cf7d3b5a6a9 commit 1675106c2d5122868b6b350ccd696cf7d3b5a6a9 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Aug 30 18:59:33 2017 Use correct icons for sound content setting Bug: 759129 Change-Id: Ie38207902be107e0edce8cc8a3fc8c4d25f52e0e Reviewed-on: https://chromium-review.googlesource.com/640250 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#498555} [modify] https://crrev.com/1675106c2d5122868b6b350ccd696cf7d3b5a6a9/chrome/app/theme/default_100_percent/common/allowed_sound.png [modify] https://crrev.com/1675106c2d5122868b6b350ccd696cf7d3b5a6a9/chrome/app/theme/default_100_percent/common/blocked_sound.png [modify] https://crrev.com/1675106c2d5122868b6b350ccd696cf7d3b5a6a9/chrome/app/theme/default_200_percent/common/allowed_sound.png [modify] https://crrev.com/1675106c2d5122868b6b350ccd696cf7d3b5a6a9/chrome/app/theme/default_200_percent/common/blocked_sound.png
,
Aug 30 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by lgar...@chromium.org
, Aug 25 2017