Trying to add long word to dictionary crashes on Android Jelly Bean |
||
Issue descriptionThe text box used for the "Add to dictionary" activity has a max length of 48: https://android.googlesource.com/platform/packages/apps/Settings/+/tools_r22/res/layout/user_dictionary_add_word.xml?autodive=0%2F%2F#41 Code in Jelly Bean that causes crash: https://android.googlesource.com/platform/packages/apps/Settings/+/jb-mr2.0.0-release/src/com/android/settings/inputmethod/UserDictionaryAddWordContents.java#67 Code fixed in the initial KitKat release that fixes it: https://android.googlesource.com/platform/packages/apps/Settings/+/kitkat-release/src/com/android/settings/inputmethod/UserDictionaryAddWordContents.java#67 We should truncate the word before trying to open the intent (at least on Jelly Bean).
,
Aug 29 2017
I already have a fix ready, I'd like to keep Jelly Bean support for now: https://chromium-review.googlesource.com/c/chromium/src/+/636205 I did previously spend some time specifically to support pre-Lollipop versions (so Jelly Bean and KitKat; KitKat has similar user share as Nougat), but I think this the first actually Jelly Bean-specific fix we've needed so far.
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0cb3eb47653341336c350c01d239c346d9d6208 commit c0cb3eb47653341336c350c01d239c346d9d6208 Author: Ryan Landay <rlanday@chromium.org> Date: Wed Aug 30 00:38:29 2017 Fix crash adding long word to dictionary on Android Jelly Bean Android Jelly Bean has a bug in the "add to dictionary" intent we're using where adding a word longer than 48 characters long will crash the whole browser. It's not terribly difficult to hit the "add to dictionary" button on accident, so this seems like a fairly serious crash. This CL fixes the crash by pre-trimming the word on Jelly Bean (the code is version-gated to make it easier to remove once we drop support for Jelly Bean). Bug: 759119 Change-Id: Ifce566a17e3da315a2711bd071e8c7220f897e98 Reviewed-on: https://chromium-review.googlesource.com/636205 Reviewed-by: Changwan Ryu <changwan@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#498312} [modify] https://crrev.com/c0cb3eb47653341336c350c01d239c346d9d6208/content/public/android/java/src/org/chromium/content/browser/input/SuggestionsPopupWindow.java
,
Aug 30 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by aelias@chromium.org
, Aug 28 2017