New issue
Advanced search Search tips

Issue 759100 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

rename detection stops working for some files on a large CL

Project Member Reported by chenwilliam@chromium.org, Aug 25 2017

Issue description

I'm working on a large refactoring CL and I noticed that only some of the files are getting rename detection.

Example:
https://chromium-review.googlesource.com/c/chromium/src/+/634570/2

I would expect files such as outline-javascript-1.html to be detected as a rename since they are well within the rename threshold.

Is gerrit doing some sort of bail-out on rename detection for large CLs? If so, it would be helpful to emit some sort of warning when you do the upload or on the CL page because it makes these large refactoring CLs very tough to review (and I need to split them into smaller CLs for my code reviewers).
 

Sign in to add a comment