I know this is across Chromium, but our original bug was in autofill_strings.grdp...so assigning to mathp@ for triage. :)

Sending this over to an owner in grit, in case they would like to fix!

Well, there's more possible values that go into expressions than just the above list. e.g. chrome/browser/browser_resources.grd has enable_extensions, and it allows {"not","and","or"} as keywords too.

Sometimes, grit will receive something like -D enable_plugins=true vs -D enable_plugins=false, but other times, it either receives -D toolkit_views, or it does not receive that argument at all. Given this example, if a .grd entry contains <if expr="toolkit_views"> on a platform that does not use Views, it cannot reject that as incorrect. Similarly, it's not obvious to grit, based on just the -D arguments, if "chromeos" is a valid expression or not.

So if someone wants to implement a check, they probably have to create (and maintain) a list of known expression values, feed that list in to grit, and have grit check the expressions against the list.

This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot