Issue metadata
Sign in to add a comment
|
Make "lgtm" in a comment automatically give +1 |
||||||||||||||||||||||
Issue descriptionI think typing lgtm as the first thing in a code review slides the box up to +1 in the UI, but it doesn't seem to always work --- I keep getting reviews with "lgtm" but not a +1, and then I have to wait potentially 24 hours, or in a case that happened today, 96 hours as my reviewer left a +1-less-lgtm and went on leave (https://chromium-review.googlesource.com/c/chromium/src/+/611741#message-69d39d5681c487aae711a7b0b29b9d516707c657). Can we just make a server-side thing that automatically changes a reviewer's status to +1 if their comment includes the word "lgtm", for compatibility with the Reitveld workflow?
,
Aug 25 2017
David, the reporter is using chromium-review.googlesource.com, which has a plugin enabled adding this behavior. https://chromium.googlesource.com/infra/gerrit-plugins/chromium-behavior/+/master/src/main/resources/static/chromium-behavior.html
,
Aug 25 2017
,
Aug 25 2017
,
Aug 25 2017
,
Aug 28 2017
We have carefully considered the tradeoffs of this behavior. The current plugin will cause the review to include a CR+1 vote if and only if the letters "lgtm" are the first four letter of the message, and the reviewer hasn't manipulated the CR label manually. When they type "lgtm", they will see the CR+1 button get highlighted. We are not going to implement any backend magic to interpret the text of messages, period. We have considered extending the plugin to recognize "lgtm" elsewhere in the message other than at the beginning, and have decided that we do not wish to perpetuate Rietveld's poor design decisions any further. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by david.pu...@gmail.com
, Aug 25 2017