"Available host" notification can appear spammy |
|||||||||
Issue descriptionAn "available host" notification is shown every time a host scan has completed successfully and the user is not online. The notification is never shown when the user is online and is hidden if the user goes online when it is visible. A host scan is triggered once when the user logs in, then again each time the user opens the network UI, disconnects from another network type, or disables and re-enables the feature. If the user is constantly repeating one of those operations, the notification could be an annoyance. Possible solutions: (1) Leave as-is. It's not expected that users will be opening and closing network settings often or constantly disabling/re-enabling the feature. (2) Only show the notification once per user log-in. (3) Rate limit the notification, maxing it out at once per time period (e.g., maximum once per hour). UX, thoughts?
,
Aug 25 2017
@jonmann: Are you sure that's not the "enable Bluetooth" notification? If so, that's been eliminated as part of issue 757556 . If it truly is the "available host" notification, I'd be surprised since the Wi-Fi scan should be able to complete far faster than the Tether scan should.
,
Aug 25 2017
yah, i get surprised by how quickly it happens every time!
,
Aug 25 2017
,
Aug 25 2017
@jonmann: Thanks for the description. I've moved discussion of that bug to issue 759137 . Let's keep this bug focused on the original discussion.
,
Aug 25 2017
Option 2 is reasonable to me
,
Aug 25 2017
Great - I'll go down that route. I'm going to make it display a maximium of once per each time Tether is enabled (so, if the user closes the laptop lid, then re-opens it, this counts as a new session, so it will be valid to display the notification a second time in this case). I think this makes sense from a UX point of view.
,
Aug 25 2017
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e088d8a86a53aee3a1d3537ed07166dcf914443d commit e088d8a86a53aee3a1d3537ed07166dcf914443d Author: Kyle Horimoto <khorimoto@google.com> Date: Tue Aug 29 19:28:50 2017 [CrOS Tether] Changes to the "available hotspot" notification. (1) Do not show that notification while connecting to another network. (2) Do not show that notification if it has already been shown during this session and was already closed. (3) Fix an issue in which NSH::FirstNetworkByType(Default()) would return the first Tether network, even if that network was not connecting/connected and there also existed a connecting/connected network of another type. Bug: 759137 , 759078 , 672263 Change-Id: Id59cfc00ebebdda7abc1b64585a0b9cfd4947c63 Reviewed-on: https://chromium-review.googlesource.com/636296 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#498197} [modify] https://crrev.com/e088d8a86a53aee3a1d3537ed07166dcf914443d/chrome/browser/chromeos/net/tether_notification_presenter.cc [modify] https://crrev.com/e088d8a86a53aee3a1d3537ed07166dcf914443d/chrome/browser/chromeos/net/tether_notification_presenter.h [modify] https://crrev.com/e088d8a86a53aee3a1d3537ed07166dcf914443d/chrome/browser/chromeos/net/tether_notification_presenter_unittest.cc [modify] https://crrev.com/e088d8a86a53aee3a1d3537ed07166dcf914443d/chromeos/components/tether/fake_notification_presenter.cc [modify] https://crrev.com/e088d8a86a53aee3a1d3537ed07166dcf914443d/chromeos/components/tether/fake_notification_presenter.h [modify] https://crrev.com/e088d8a86a53aee3a1d3537ed07166dcf914443d/chromeos/components/tether/host_scanner.cc [modify] https://crrev.com/e088d8a86a53aee3a1d3537ed07166dcf914443d/chromeos/components/tether/host_scanner.h [modify] https://crrev.com/e088d8a86a53aee3a1d3537ed07166dcf914443d/chromeos/components/tether/host_scanner_unittest.cc [modify] https://crrev.com/e088d8a86a53aee3a1d3537ed07166dcf914443d/chromeos/components/tether/notification_presenter.h [modify] https://crrev.com/e088d8a86a53aee3a1d3537ed07166dcf914443d/chromeos/components/tether/notification_remover.cc [modify] https://crrev.com/e088d8a86a53aee3a1d3537ed07166dcf914443d/chromeos/components/tether/notification_remover.h [modify] https://crrev.com/e088d8a86a53aee3a1d3537ed07166dcf914443d/chromeos/components/tether/notification_remover_unittest.cc [modify] https://crrev.com/e088d8a86a53aee3a1d3537ed07166dcf914443d/chromeos/network/network_state.cc [modify] https://crrev.com/e088d8a86a53aee3a1d3537ed07166dcf914443d/chromeos/network/network_state.h [modify] https://crrev.com/e088d8a86a53aee3a1d3537ed07166dcf914443d/chromeos/network/network_state_handler.cc
,
Aug 29 2017
,
Aug 29 2017
This bug requires manual review: We are only 6 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 29 2017
Approving merge to M61.
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13289a5e55ca73e2032379ae84928f43aecc0a4d commit 13289a5e55ca73e2032379ae84928f43aecc0a4d Author: Kyle Horimoto <khorimoto@google.com> Date: Tue Aug 29 21:30:54 2017 [CrOS Tether] Changes to the "available hotspot" notification. (1) Do not show that notification while connecting to another network. (2) Do not show that notification if it has already been shown during this session and was already closed. (3) Fix an issue in which NSH::FirstNetworkByType(Default()) would return the first Tether network, even if that network was not connecting/connected and there also existed a connecting/connected network of another type. TBR=khorimoto@google.com (cherry picked from commit e088d8a86a53aee3a1d3537ed07166dcf914443d) Bug: 759137 , 759078 , 672263 Change-Id: Id59cfc00ebebdda7abc1b64585a0b9cfd4947c63 Reviewed-on: https://chromium-review.googlesource.com/636296 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#498197} Reviewed-on: https://chromium-review.googlesource.com/642055 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#981} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/13289a5e55ca73e2032379ae84928f43aecc0a4d/chrome/browser/chromeos/net/tether_notification_presenter.cc [modify] https://crrev.com/13289a5e55ca73e2032379ae84928f43aecc0a4d/chrome/browser/chromeos/net/tether_notification_presenter.h [modify] https://crrev.com/13289a5e55ca73e2032379ae84928f43aecc0a4d/chrome/browser/chromeos/net/tether_notification_presenter_unittest.cc [modify] https://crrev.com/13289a5e55ca73e2032379ae84928f43aecc0a4d/chromeos/components/tether/fake_notification_presenter.cc [modify] https://crrev.com/13289a5e55ca73e2032379ae84928f43aecc0a4d/chromeos/components/tether/fake_notification_presenter.h [modify] https://crrev.com/13289a5e55ca73e2032379ae84928f43aecc0a4d/chromeos/components/tether/host_scanner.cc [modify] https://crrev.com/13289a5e55ca73e2032379ae84928f43aecc0a4d/chromeos/components/tether/host_scanner.h [modify] https://crrev.com/13289a5e55ca73e2032379ae84928f43aecc0a4d/chromeos/components/tether/host_scanner_unittest.cc [modify] https://crrev.com/13289a5e55ca73e2032379ae84928f43aecc0a4d/chromeos/components/tether/notification_presenter.h [modify] https://crrev.com/13289a5e55ca73e2032379ae84928f43aecc0a4d/chromeos/components/tether/notification_remover.cc [modify] https://crrev.com/13289a5e55ca73e2032379ae84928f43aecc0a4d/chromeos/components/tether/notification_remover.h [modify] https://crrev.com/13289a5e55ca73e2032379ae84928f43aecc0a4d/chromeos/components/tether/notification_remover_unittest.cc [modify] https://crrev.com/13289a5e55ca73e2032379ae84928f43aecc0a4d/chromeos/network/network_state.cc [modify] https://crrev.com/13289a5e55ca73e2032379ae84928f43aecc0a4d/chromeos/network/network_state.h [modify] https://crrev.com/13289a5e55ca73e2032379ae84928f43aecc0a4d/chromeos/network/network_state_handler.cc
,
Aug 29 2017
,
Jan 22 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by jonmann@chromium.org
, Aug 25 2017