New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 759070 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

20.9% regression in rasterize_and_record_micro.top_25 at 494644:494750

Project Member Reported by kraynov@chromium.org, Aug 25 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Aug 25 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=759070

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=dbb37fe0c079d28f6a985546056a66ba3ad905a28448bb0d1b05911faf11b677


Bot(s) for this bug's original alert(s):

chromium-rel-win7-dual
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 25 2017

Cc: herb@google.com
Owner: herb@google.com
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author herb@google.com ===

Hi herb@google.com, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Herb Derby
  Commit : 8a0d2d4af840fbd861d6e4444346c90c67dede13
  Date   : Wed Aug 16 03:59:53 2017
  Subject: Start using linear filter for small sigma

Bisect Details
  Configuration: win_perf_bisect
  Benchmark    : rasterize_and_record_micro.top_25
  Metric       : rasterize_time/Facebook
  Change       : 21.23% | 2.693 -> 3.26483333333

Revision             Result                    N
chromium@494643      2.693 +- 0.0995992        6      good
chromium@494670      2.67 +- 0.0753658         6      good
chromium@494684      2.69167 +- 0.0536594      6      good
chromium@494688      2.70817 +- 0.0630463      6      good
chromium@494690      2.66317 +- 0.0496269      6      good
chromium@494691      3.21683 +- 0.0369707      6      bad       <--
chromium@494697      3.20983 +- 0.0432069      6      bad
chromium@494750      3.26483 +- 0.0795414      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=Facebook rasterize_and_record_micro.top_25

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8970272163048642928


For feedback, file a bug with component Speed>Bisection

Comment 4 by herb@google.com, Aug 28 2017

Cc: -herb@google.com herb@chromium.org
Owner: herb@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bb1ca322c8ee7f00123f22364d5012881329b9d

commit 0bb1ca322c8ee7f00123f22364d5012881329b9d
Author: Herb Derby <herb@google.com>
Date: Wed Sep 13 23:18:17 2017

Add flag to gate faster blur code: SK_SUPPORT_LEGACY_SLOW_SMALL_BLUR

BUG= chromium:759070 

Change-Id: Ic0458450d00635b5cc18349d47bad852dfa8013e
Reviewed-on: https://chromium-review.googlesource.com/665737
Commit-Queue: Herb Derby <herb@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501793}
[modify] https://crrev.com/0bb1ca322c8ee7f00123f22364d5012881329b9d/skia/config/SkUserConfig.h

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/0f96bb303adfc712baba7830e036df1d0972d7f3

commit 0f96bb303adfc712baba7830e036df1d0972d7f3
Author: Herb Derby <herb@google.com>
Date: Thu Sep 14 03:42:50 2017

Sk4i version of blur.

For the blur_1.50_normal_low_quality benchmark, this code goes from about 120us to 85us.
The original implementation executes at about 95us.

This changed in controlled by the flag:

SK_SUPPORT_LEGACY_SLOW_SMALL_BLUR

BUG= chromium:759070 

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD
Change-Id: If722cb8ffd8c47a94b7a6b4e6dd26fd1474b6209
Reviewed-on: https://skia-review.googlesource.com/45300
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>

[modify] https://crrev.com/0f96bb303adfc712baba7830e036df1d0972d7f3/src/core/SkMaskBlurFilter.cpp
[modify] https://crrev.com/0f96bb303adfc712baba7830e036df1d0972d7f3/src/opts/SkNx_sse.h
[modify] https://crrev.com/0f96bb303adfc712baba7830e036df1d0972d7f3/src/opts/SkNx_neon.h

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fefaeaf2c9c59f304fad209e8da7c0bf3357cf9

commit 7fefaeaf2c9c59f304fad209e8da7c0bf3357cf9
Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org>
Date: Thu Sep 14 05:04:51 2017

Roll src/third_party/skia/ 09dfc4759..0f96bb303 (1 commit)

https://skia.googlesource.com/skia.git/+log/09dfc4759e99..0f96bb303adf

$ git log 09dfc4759..0f96bb303 --date=short --no-merges --format='%ad %ae %s'
2017-09-13 herb Sk4i version of blur.

Created with:
  roll-dep src/third_party/skia
BUG= 759070 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=stephana@chromium.org

Change-Id: Ida9a20a159aa793122f06f8d6cda9725ac191d7e
Reviewed-on: https://chromium-review.googlesource.com/666182
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501874}
[modify] https://crrev.com/7fefaeaf2c9c59f304fad209e8da7c0bf3357cf9/DEPS

Comment 8 by herb@google.com, Sep 14 2017

Cc: rmcilroy@chromium.org herb@google.com
 Issue 763870  has been merged into this issue.

Comment 9 by herb@google.com, Sep 14 2017

Cc: briander...@chromium.org
 Issue 762204  has been merged into this issue.
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f68a2d3dfaeef91796c0e7e3f5e92a1d949ad2b

commit 0f68a2d3dfaeef91796c0e7e3f5e92a1d949ad2b
Author: Herb Derby <herb@google.com>
Date: Thu Sep 14 22:38:06 2017

Use Skia's faster blur code.

BUG= chromium:759070 

Change-Id: Ic4a3f06d1654cb917718f6901fc2b66018dbfaf4
Reviewed-on: https://chromium-review.googlesource.com/667360
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502046}
[modify] https://crrev.com/0f68a2d3dfaeef91796c0e7e3f5e92a1d949ad2b/skia/config/SkUserConfig.h
[modify] https://crrev.com/0f68a2d3dfaeef91796c0e7e3f5e92a1d949ad2b/third_party/WebKit/LayoutTests/platform/linux/fast/css/shadow-multiple-expected.png
[modify] https://crrev.com/0f68a2d3dfaeef91796c0e7e3f5e92a1d949ad2b/third_party/WebKit/LayoutTests/platform/linux/fast/writing-mode/english-lr-text-expected.png
[modify] https://crrev.com/0f68a2d3dfaeef91796c0e7e3f5e92a1d949ad2b/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/shadow-multiple-expected.png
[modify] https://crrev.com/0f68a2d3dfaeef91796c0e7e3f5e92a1d949ad2b/third_party/WebKit/LayoutTests/platform/linux/svg/css/text-shadow-multiple-expected.png
[modify] https://crrev.com/0f68a2d3dfaeef91796c0e7e3f5e92a1d949ad2b/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/css/shadow-multiple-expected.png
[modify] https://crrev.com/0f68a2d3dfaeef91796c0e7e3f5e92a1d949ad2b/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/writing-mode/english-lr-text-expected.png
[modify] https://crrev.com/0f68a2d3dfaeef91796c0e7e3f5e92a1d949ad2b/third_party/WebKit/LayoutTests/platform/mac-mac10.10/paint/invalidation/shadow-multiple-expected.png
[modify] https://crrev.com/0f68a2d3dfaeef91796c0e7e3f5e92a1d949ad2b/third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/css/text-shadow-multiple-expected.png
[modify] https://crrev.com/0f68a2d3dfaeef91796c0e7e3f5e92a1d949ad2b/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/css/shadow-multiple-expected.png
[modify] https://crrev.com/0f68a2d3dfaeef91796c0e7e3f5e92a1d949ad2b/third_party/WebKit/LayoutTests/platform/mac/fast/css/shadow-multiple-expected.png
[modify] https://crrev.com/0f68a2d3dfaeef91796c0e7e3f5e92a1d949ad2b/third_party/WebKit/LayoutTests/platform/mac/fast/writing-mode/english-lr-text-expected.png
[modify] https://crrev.com/0f68a2d3dfaeef91796c0e7e3f5e92a1d949ad2b/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/shadow-multiple-expected.png
[modify] https://crrev.com/0f68a2d3dfaeef91796c0e7e3f5e92a1d949ad2b/third_party/WebKit/LayoutTests/platform/mac/svg/css/text-shadow-multiple-expected.png
[modify] https://crrev.com/0f68a2d3dfaeef91796c0e7e3f5e92a1d949ad2b/third_party/WebKit/LayoutTests/platform/win/fast/css/shadow-multiple-expected.png
[modify] https://crrev.com/0f68a2d3dfaeef91796c0e7e3f5e92a1d949ad2b/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/shadow-multiple-expected.png
[modify] https://crrev.com/0f68a2d3dfaeef91796c0e7e3f5e92a1d949ad2b/third_party/WebKit/LayoutTests/platform/win/svg/css/text-shadow-multiple-expected.png
[modify] https://crrev.com/0f68a2d3dfaeef91796c0e7e3f5e92a1d949ad2b/third_party/WebKit/LayoutTests/platform/win7/fast/css/shadow-multiple-expected.png
[modify] https://crrev.com/0f68a2d3dfaeef91796c0e7e3f5e92a1d949ad2b/third_party/WebKit/LayoutTests/platform/win7/paint/invalidation/shadow-multiple-expected.png
[modify] https://crrev.com/0f68a2d3dfaeef91796c0e7e3f5e92a1d949ad2b/third_party/WebKit/LayoutTests/platform/win7/svg/css/text-shadow-multiple-expected.png

Comment 11 by herb@chromium.org, Oct 2 2017

Status: Fixed (was: Assigned)

Sign in to add a comment