Issue metadata
Sign in to add a comment
|
8.4% regression in thread_times.key_mobile_sites_smooth at 496335:496583 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Aug 25 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8970272635685758896
,
Aug 25 2017
=== Auto-CCing suspected CL author bokan@chromium.org === Hi bokan@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : David Bokan Commit : 400ea682810ebe6ea2b11ea3917870c3f084669a Date : Wed Aug 23 01:17:00 2017 Subject: Convert key_mobile_sites_smooth to WPRGO Bisect Details Configuration: android_webview_nexus6_aosp_perf_bisect Benchmark : thread_times.key_mobile_sites_smooth Metric : thread_GPU_cpu_time_per_frame/http___slashdot.org_ Change : 9.26% | 0.620724848401 -> 0.678208494944 Revision Result N chromium@496334 0.620725 +- 0.0245852 6 good chromium@496459 0.625668 +- 0.0135341 6 good chromium@496521 0.622578 +- 0.0233156 6 good chromium@496537 0.627646 +- 0.00840011 6 good chromium@496539 0.630803 +- 0.0178093 6 good chromium@496540 0.625797 +- 0.0156226 6 good chromium@496541 0.674795 +- 0.0330869 6 bad <-- chromium@496545 0.673665 +- 0.0399097 6 bad chromium@496552 0.670775 +- 0.0285507 6 bad chromium@496583 0.678208 +- 0.0252036 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http...slashdot.org. thread_times.key_mobile_sites_smooth More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8970272635685758896 For feedback, file a bug with component Speed>Bisection
,
Aug 25 2017
This is not a regression but curious... Ned, is converting to WPRGO expected to have a performance impact? (btw, I'm OOO next week so I likely wont respond in the short term)
,
Aug 25 2017
Adding Helen since Ned is also OOO
,
Aug 25 2017
Yes, converting to WprGo can change performance characteristics of existing metrics. It's interesting to note that there are also improvements reported e.g. on www.reddit.com. thread_raster_cpu_time_per_frame/http___www.reddit.com_r_programming_comments_1g96ve 46.9% 0.314 ms thread_raster_cpu_time_per_frame/http___www.reddit.com_r_programming_comments_1g96ve 56.1% 0.580 ms thread_total_all_cpu_time_per_frame/http___www.reddit.com_r_programming_comments_1g96ve 12.9% 2.519 ms thread_GPU_cpu_time_per_frame/http___www.reddit.com_r_programming_comments_1g96ve 68.3% 0.631 ms If metrics are consistent post-migration and pages are loading fine, I would suggest to ignore it.
,
Aug 25 2017
Sgtm, thanks! |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Aug 25 2017