New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 759067 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

8.4% regression in thread_times.key_mobile_sites_smooth at 496335:496583

Project Member Reported by kraynov@chromium.org, Aug 25 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Aug 25 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=759067

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=b236077573670944d39bf9c3426c485b90d506f823732718dca7081324dc12c2


Bot(s) for this bug's original alert(s):

android-webview-nexus6
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 25 2017

Cc: bokan@chromium.org
Owner: bokan@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author bokan@chromium.org ===

Hi bokan@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : David Bokan
  Commit : 400ea682810ebe6ea2b11ea3917870c3f084669a
  Date   : Wed Aug 23 01:17:00 2017
  Subject: Convert key_mobile_sites_smooth to WPRGO

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : thread_times.key_mobile_sites_smooth
  Metric       : thread_GPU_cpu_time_per_frame/http___slashdot.org_
  Change       : 9.26% | 0.620724848401 -> 0.678208494944

Revision             Result                      N
chromium@496334      0.620725 +- 0.0245852       6      good
chromium@496459      0.625668 +- 0.0135341       6      good
chromium@496521      0.622578 +- 0.0233156       6      good
chromium@496537      0.627646 +- 0.00840011      6      good
chromium@496539      0.630803 +- 0.0178093       6      good
chromium@496540      0.625797 +- 0.0156226       6      good
chromium@496541      0.674795 +- 0.0330869       6      bad       <--
chromium@496545      0.673665 +- 0.0399097       6      bad
chromium@496552      0.670775 +- 0.0285507       6      bad
chromium@496583      0.678208 +- 0.0252036       6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http...slashdot.org. thread_times.key_mobile_sites_smooth

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8970272635685758896


For feedback, file a bug with component Speed>Bisection

Comment 4 by bokan@chromium.org, Aug 25 2017

Cc: nednguyen@chromium.org
This is not a regression but curious...

Ned, is converting to WPRGO expected to have a performance impact? (btw, I'm OOO next week so I likely wont respond in the short term)

Cc: xunji...@chromium.org
Adding Helen since Ned is also OOO
Yes, converting to WprGo can change performance characteristics of existing metrics. 

It's interesting to note that there are also improvements reported e.g. on www.reddit.com.

thread_raster_cpu_time_per_frame/http___www.reddit.com_r_programming_comments_1g96ve	46.9%	0.314 ms
thread_raster_cpu_time_per_frame/http___www.reddit.com_r_programming_comments_1g96ve	56.1%	0.580 ms
thread_total_all_cpu_time_per_frame/http___www.reddit.com_r_programming_comments_1g96ve	12.9%	2.519 ms
thread_GPU_cpu_time_per_frame/http___www.reddit.com_r_programming_comments_1g96ve	68.3%	0.631 ms

If metrics are consistent post-migration and pages are loading fine, I would suggest to ignore it. 

Comment 7 by bokan@chromium.org, Aug 25 2017

Status: WontFix (was: Assigned)
Sgtm, thanks!

Sign in to add a comment