New issue
Advanced search Search tips

Issue 759052 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 771399
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Clean up old 3x3 Previews disabling support once fully cutover to new blacklist

Project Member Reported by dougarnett@chromium.org, Aug 25 2017

Issue description

The LoFi fieldtrials are no longer used to decide whether to request server previews or not in M-61 but they still have some parameters that may be used for the original 3x3 disabling support:
  - "load_images_requests_per_session"
  - "consecutive_session_disables"
  - "implicit_opt_out_epoch"

Once the new blacklist support (eg, params::IsBlackListEnabledForServerPreviews()) is fully rolled out these fieldtrial params (hopefully all uses of params::GetLoFiFieldTrialName() and DataReductionProxyConfig::lofi_off()) can be clean up from the code base.
 

Comment 1 by bengr@chromium.org, Aug 29 2017

Owner: ryansturm@chromium.org
Status: Assigned (was: Untriaged)
Mergedinto: 771399
Status: Duplicate (was: Assigned)
This was fixed in another CL.

Comment 3 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 4 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews

Sign in to add a comment