LocalSurfaceIdAllocator should track its last generated LocalSurfaceId |
|||||||
Issue descriptionWhenever we have a LocalSurfaceIdAllocator we also need to store a LocalSurfaceId. It seems like it would be simpler and reduce a lot of duplicate code all over the place if LocalSurfaceIdAllocator kept track of its last allocated LocalSurfaceId doing away with the need to keep track of a LocalSurfaceId locally as well.
,
Dec 21 2017
Passing along to cblume@
,
Jan 8 2018
Passing it along to yiyix@
,
Jan 8 2018
I think I have a CL out for this.
,
Jan 8 2018
Ohh OK, nevermind. Passing back to cblume@ :-)
,
Jan 8 2018
Yeah, looks like here: https://chromium-review.googlesource.com/c/chromium/src/+/815679 I suspect I have some more local changes that I didn't upload before break. I'll take a look.
,
Apr 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e30c5be3fd331198d48355697a1e087d9a2fccd1 commit e30c5be3fd331198d48355697a1e087d9a2fccd1 Author: Chris Blume <cblume@chromium.org> Date: Tue Apr 10 21:19:20 2018 LocalSurfaceIdProvider to use allocator's copy The LSI allocators previously did not store a copy of the last generated LSI. As a result, many call sites would have to keep their own copies. Now that the LSI allocators have their own copies, the call sites can be updated to no longer store a separate copy. LocalSurfaceIdProvider is one such call site. BUG= 759031 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I85aad90edc9d61ae1c2924d3bbc5fc92b3b9376b Reviewed-on: https://chromium-review.googlesource.com/1005801 Reviewed-by: Fady Samuel <fsamuel@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#549647} [modify] https://crrev.com/e30c5be3fd331198d48355697a1e087d9a2fccd1/components/viz/client/local_surface_id_provider.cc [modify] https://crrev.com/e30c5be3fd331198d48355697a1e087d9a2fccd1/components/viz/client/local_surface_id_provider.h
,
Apr 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a971e271651eb7c0b3aefb4422682120307a5f09 commit a971e271651eb7c0b3aefb4422682120307a5f09 Author: Chris Blume <cblume@chromium.org> Date: Thu Apr 12 12:50:20 2018 Viz display unittests to use LSI allocator's copy The LSI allocators previously did not store a copy of the last generated LSI. As a result, many call sites would have to keep their own copies. Now that the LSI allocators have their own copies, the call sites can be updated to no longer store a separate copy. Viz's display unittests are one such call site. BUG= 759031 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I9b689e7e22971baf9596fcc42ccc7ffb28a4b7af Reviewed-on: https://chromium-review.googlesource.com/1008963 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#550161} [modify] https://crrev.com/a971e271651eb7c0b3aefb4422682120307a5f09/components/viz/service/display/display_unittest.cc
,
Apr 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dee45b30620a7ddafa8ceb735e54737bf5d86a7a commit dee45b30620a7ddafa8ceb735e54737bf5d86a7a Author: Chris Blume <cblume@chromium.org> Date: Thu Apr 12 19:41:04 2018 SurfaceAggregatorPixelTest to use allocator's copy The LSI allocators previously did not store a copy of the last generated LSI. As a result, many call sites would have to keep their own copies. Now that the LSI allocators have their own copies, the call sites can be updated to no longer store a separate copy. SurfaceAggregatorPixelTest is one such call site. BUG= 759031 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I8ea6b0cde545dd2a0a60cff2294028baf5569747 Reviewed-on: https://chromium-review.googlesource.com/1010705 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#550315} [modify] https://crrev.com/dee45b30620a7ddafa8ceb735e54737bf5d86a7a/components/viz/service/display/surface_aggregator_pixeltest.cc
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dee45b30620a7ddafa8ceb735e54737bf5d86a7a commit dee45b30620a7ddafa8ceb735e54737bf5d86a7a Author: Chris Blume <cblume@chromium.org> Date: Thu Apr 12 19:41:04 2018 SurfaceAggregatorPixelTest to use allocator's copy The LSI allocators previously did not store a copy of the last generated LSI. As a result, many call sites would have to keep their own copies. Now that the LSI allocators have their own copies, the call sites can be updated to no longer store a separate copy. SurfaceAggregatorPixelTest is one such call site. BUG= 759031 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I8ea6b0cde545dd2a0a60cff2294028baf5569747 Reviewed-on: https://chromium-review.googlesource.com/1010705 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#550315} [modify] https://crrev.com/dee45b30620a7ddafa8ceb735e54737bf5d86a7a/components/viz/service/display/surface_aggregator_pixeltest.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8ba255de96d00cfb0e52e88543cb69cad4ce03e commit e8ba255de96d00cfb0e52e88543cb69cad4ce03e Author: Chris Blume <cblume@chromium.org> Date: Tue Apr 24 17:15:20 2018 DirectLayerTreeFrameSink to use allocator's copy The LSI allocators previously did not store a copy of the last generated LSI. As a result, many call sites would have to keep their own copies. Now that the LSI allocators have their own copies, the call sites can be updated to no longer store a separate copy. DirectLayerTreeFrameSink is one such call site. BUG= 759031 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I3b02013078ac09330eb076f542886a14b545ad73 Reviewed-on: https://chromium-review.googlesource.com/1024748 Reviewed-by: Fady Samuel <fsamuel@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#553183} [modify] https://crrev.com/e8ba255de96d00cfb0e52e88543cb69cad4ce03e/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.cc [modify] https://crrev.com/e8ba255de96d00cfb0e52e88543cb69cad4ce03e/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.h
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3136942343b0142bdb23d7abe32d4073a5241894 commit 3136942343b0142bdb23d7abe32d4073a5241894 Author: Chris Blume <cblume@chromium.org> Date: Wed Apr 25 20:32:39 2018 RenderFrameProxy to use allocator's copy The LSI allocators previously did not store a copy of the last generated LSI. As a result, many call sites would have to keep their own copies. Now that the LSI allocators have their own copies, the call sites can be updated to no longer store a separate copy. RenderFrameProxy is one such call site. BUG= 759031 Change-Id: Id40e679f2c41876fd7e23aa8f2e70817445be420 Reviewed-on: https://chromium-review.googlesource.com/1024747 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#553724} [modify] https://crrev.com/3136942343b0142bdb23d7abe32d4073a5241894/content/renderer/render_frame_proxy.cc [modify] https://crrev.com/3136942343b0142bdb23d7abe32d4073a5241894/content/renderer/render_frame_proxy.h
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/545a6e1483161c60c1c76a65599499a357d0b02e commit 545a6e1483161c60c1c76a65599499a357d0b02e Author: Chris Blume <cblume@chromium.org> Date: Thu Apr 26 03:56:20 2018 FrameGenerator to use alloctor's copy The LSI allocators previously did not store a copy of the last generated LSI. As a result, many call sites would have to keep their own copies. Now that the LSI allocators have their own copies, the call sites can be updated to no longer store a separate copy. FrameGenerator is one such call site. BUG= 759031 Change-Id: I39774ba04f4bbfd61909e9df12df76c1fd76c492 Reviewed-on: https://chromium-review.googlesource.com/1029427 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#553905} [modify] https://crrev.com/545a6e1483161c60c1c76a65599499a357d0b02e/services/ui/ws/frame_generator.cc [modify] https://crrev.com/545a6e1483161c60c1c76a65599499a357d0b02e/services/ui/ws/frame_generator.h
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52b4d5be20c125f735970c1ed37e97a9a253d3f2 commit 52b4d5be20c125f735970c1ed37e97a9a253d3f2 Author: Chris Blume <cblume@chromium.org> Date: Thu Apr 26 17:34:18 2018 RendererLocalSurfaceIdProvider to use alloc's copy The LSI allocators previously did not store a copy of the last generated LSI. As a result, many call sites would have to keep their own copies. Now that the LSI allocators have their own copies, the call sites can be updated to no longer store a separate copy. RendererLocalSurfaceIdProvider is one such call site. BUG= 759031 Change-Id: I25af885c787a3c99852ba4f1b448d56c5bdb7315 Reviewed-on: https://chromium-review.googlesource.com/1026432 Reviewed-by: Fady Samuel <fsamuel@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#554067} [modify] https://crrev.com/52b4d5be20c125f735970c1ed37e97a9a253d3f2/content/renderer/render_thread_impl.cc
,
Apr 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62873578dc30938f2e9a042e10448f14394b8e5d commit 62873578dc30938f2e9a042e10448f14394b8e5d Author: Chris Blume <cblume@chromium.org> Date: Sat Apr 28 07:12:02 2018 Test LayerTreeFrameSink to use alloctor's copy The LSI allocators previously did not store a copy of the last generated LSI. As a result, many call sites would have to keep their own copies. Now that the LSI allocators have their own copies, the call sites can be updated to no longer store a separate copy. Test LayerTreeFrameSink is one such call site. BUG= 759031 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I17eea36d81726e50a1f5f46fadd3daa624f692c3 Reviewed-on: https://chromium-review.googlesource.com/1029538 Reviewed-by: Fady Samuel <fsamuel@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#554638} [modify] https://crrev.com/62873578dc30938f2e9a042e10448f14394b8e5d/components/viz/test/test_layer_tree_frame_sink.cc [modify] https://crrev.com/62873578dc30938f2e9a042e10448f14394b8e5d/components/viz/test/test_layer_tree_frame_sink.h
,
Apr 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f4ec987d2f5339cb079c55748d9ced998f7b097 commit 7f4ec987d2f5339cb079c55748d9ced998f7b097 Author: Chris Blume <cblume@chromium.org> Date: Mon Apr 30 17:29:26 2018 SurfaceHittest unit tests to use alloctor's copy The LSI allocators previously did not store a copy of the last generated LSI. As a result, many call sites would have to keep their own copies. Now that the LSI allocators have their own copies, the call sites can be updated to no longer store a separate copy. SurfaceHittest unit tests some such call site. BUG= 759031 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I2d15885b14805d230f8ee67d1dfa453d3f46804f Reviewed-on: https://chromium-review.googlesource.com/1034388 Reviewed-by: Fady Samuel <fsamuel@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#554802} [modify] https://crrev.com/7f4ec987d2f5339cb079c55748d9ced998f7b097/components/viz/service/surfaces/surface_hittest_unittest.cc
,
Apr 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2c23355cd3429845aededd5dcc614132727607d commit a2c23355cd3429845aededd5dcc614132727607d Author: Chris Blume <cblume@chromium.org> Date: Mon Apr 30 18:46:07 2018 WindowPortLocal to use alloctor's copy The LSI allocators previously did not store a copy of the last generated LSI. As a result, many call sites would have to keep their own copies. Now that the LSI allocators have their own copies, the call sites can be updated to no longer store a separate copy. WindowPortLocal is one such call site. BUG= 759031 Change-Id: I174529bdc83d97fe84f5c6e9ee595b2dd67a4668 Reviewed-on: https://chromium-review.googlesource.com/1034454 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#554824} [modify] https://crrev.com/a2c23355cd3429845aededd5dcc614132727607d/ui/aura/local/window_port_local.cc [modify] https://crrev.com/a2c23355cd3429845aededd5dcc614132727607d/ui/aura/local/window_port_local.h
,
May 2 2018
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c13539099f96adbb12f17677f3eda960d16fd55a commit c13539099f96adbb12f17677f3eda960d16fd55a Author: Chris Blume <cblume@chromium.org> Date: Wed May 02 21:17:21 2018 VideoFrameSubmitter to use alloctor's copy The LSI allocators previously did not store a copy of the last generated LSI. As a result, many call sites would have to keep their own copies. Now that the LSI allocators have their own copies, the call sites can be updated to no longer store a separate copy. VideoFrameSubmitter is one such call site. BUG= 759031 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia4fde6fdb870c87d1852edd1f4a33a89f7cc9743 Reviewed-on: https://chromium-review.googlesource.com/1034390 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#555541} [modify] https://crrev.com/c13539099f96adbb12f17677f3eda960d16fd55a/third_party/blink/renderer/platform/graphics/video_frame_submitter.cc [modify] https://crrev.com/c13539099f96adbb12f17677f3eda960d16fd55a/third_party/blink/renderer/platform/graphics/video_frame_submitter.h
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7d2e54fe3011731db32690498e110a1844ed648 commit a7d2e54fe3011731db32690498e110a1844ed648 Author: Chris Blume <cblume@chromium.org> Date: Wed May 02 22:20:22 2018 OffscreenCanvasFrameDispatcherImpl & alloc's copy The LSI allocators previously did not store a copy of the last generated LSI. As a result, many call sites would have to keep their own copies. Now that the LSI allocators have their own copies, the call sites can be updated to no longer store a separate copy. OffscreenCanvasFrameDispatcherImpl is one such call site. BUG= 759031 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I5e65ab848ba95c7b7f6f2f3a9eb31bce8c95fc94 Reviewed-on: https://chromium-review.googlesource.com/1034193 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#555577} [modify] https://crrev.com/a7d2e54fe3011731db32690498e110a1844ed648/third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher.cc [modify] https://crrev.com/a7d2e54fe3011731db32690498e110a1844ed648/third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher.h
,
May 15 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by fsamuel@google.com
, Oct 24 2017