Issue metadata
Sign in to add a comment
|
35.6% regression in blink_perf.canvas at 496423:496550 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Aug 25 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8970275446451954320
,
Aug 26 2017
=== Auto-CCing suspected CL author bsalomon@google.com === Hi bsalomon@google.com, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Brian Salomon Commit : a184ac7e0cdb26919369151f606c194358c94ff5 Date : Tue Aug 22 21:36:40 2017 Subject: Revert "Revert "Revert "Add GrTextureOp and use to implement SkGpuDevice::drawImage[Rect]() when possible""" Bisect Details Configuration: mac_retina_perf_bisect Benchmark : blink_perf.canvas Metric : draw-static-canvas-2d-to-hw-accelerated-canvas-2d/draw-static-canvas-2d-to-hw-accelerated-canvas-2d Change : 30.92% | 256942.053542 -> 177499.926331 Revision Result N chromium@496422 256942 +- 46065.5 6 good chromium@496486 237119 +- 62782.5 6 good chromium@496518 254179 +- 57916.6 6 good chromium@496522 255253 +- 80183.5 6 good chromium@496522,skia@d6b28f7bc8 272407 +- 58251.9 6 good chromium@496522,skia@82e314534c 254939 +- 89182.4 6 good chromium@496522,skia@a184ac7e0c 171434 +- 50586.8 6 bad <-- chromium@496523 178464 +- 44358.1 6 bad chromium@496524 180709 +- 21968.9 6 bad chromium@496526 182620 +- 36332.8 6 bad chromium@496534 202281 +- 24568.8 6 bad chromium@496550 177500 +- 35797.6 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.canvas More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8970275446451954320 For feedback, file a bug with component Speed>Bisection
,
Aug 26 2017
The regression is due to a revert of a change that improved performance for simple image draws. I'll be relanding that change once I add back an optimization to disable bilerp that the new code path omitted which caused some regressions on Android.
,
Aug 30 2017
The change relanded and the perf is recovered. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Aug 25 2017