New issue
Advanced search Search tips

Issue 759024 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

surfacechooser doesn't notice surfaceDestroyed

Project Member Reported by liber...@chromium.org, Aug 25 2017

Issue description

surface chooser doesn't know when an overlay is destroyed, so it doesn't realize that the client has switched back to surface texture.  so, it never tries for an overlay again.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42273dd1eeac30e14713246d996a9eb52074ad1c

commit 42273dd1eeac30e14713246d996a9eb52074ad1c
Author: liberato@chromium.org <liberato@chromium.org>
Date: Sat Aug 26 00:19:13 2017

Retry overlays after surfaceDestroyed.

AndroidVideoSurfaceChooserImpl wasn't being notified when a surface
was destroyed.  As a result, it continued to believe that the client
was using an overlay, even after the client (which was notified when
the surface was destroyed) has switched to SurfaceTexture.

This CL adds a 'deletion callback' to AndroidOverlay, which calls
back when the overlay object is deleted.  SurfaceChooser uses this
to update its internal state.

Bug:  759024 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I833e933ac50a775685801cd5f8e7e197a574a435
Reviewed-on: https://chromium-review.googlesource.com/636025
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497607}
[modify] https://crrev.com/42273dd1eeac30e14713246d996a9eb52074ad1c/media/base/android/android_overlay.cc
[modify] https://crrev.com/42273dd1eeac30e14713246d996a9eb52074ad1c/media/base/android/android_overlay.h
[modify] https://crrev.com/42273dd1eeac30e14713246d996a9eb52074ad1c/media/base/android_overlay_config.h
[modify] https://crrev.com/42273dd1eeac30e14713246d996a9eb52074ad1c/media/gpu/android_video_surface_chooser_impl.cc
[modify] https://crrev.com/42273dd1eeac30e14713246d996a9eb52074ad1c/media/gpu/android_video_surface_chooser_impl.h
[modify] https://crrev.com/42273dd1eeac30e14713246d996a9eb52074ad1c/media/gpu/android_video_surface_chooser_impl_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment