New issue
Advanced search Search tips

Issue 759023 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Assert failure on start on svelte device

Project Member Reported by dgn@chromium.org, Aug 25 2017

Issue description

No idea about specific steps to repro, but that seems to happen fairly reliably on my svelte device right when I launch Chrome.

E/AndroidRuntime: FATAL EXCEPTION: IntentService[]
E/AndroidRuntime: Process: com.google.android.apps.chrome, PID: 14883
E/AndroidRuntime: java.lang.AssertionError: Must be called on the UI thread.
E/AndroidRuntime: 	at org.chromium.base.ThreadUtils.assertOnUiThread(ThreadUtils.java:203)
E/AndroidRuntime: 	at org.chromium.components.signin.AccountManagerFacade$ConnectionRetry.attempt(AccountManagerFacade.java:537)
E/AndroidRuntime: 	at org.chromium.components.signin.AccountManagerFacade$ConnectionRetry.runAuthTask(AccountManagerFacade.java:523)
E/AndroidRuntime: 	at org.chromium.components.signin.AccountManagerFacade.getAuthToken(AccountManagerFacade.java:416)
E/AndroidRuntime: 	at org.chromium.components.signin.AccountManagerFacade.getNewAuthToken(AccountManagerFacade.java:441)
E/AndroidRuntime: 	at org.chromium.components.invalidation.InvalidationClientService.requestAuthToken(InvalidationClientService.java:256)
E/AndroidRuntime: 	at com.google.ipc.invalidation.external.client.contrib.AndroidListener.tryHandleAuthTokenRequestIntent(AndroidListener.java:560)
E/AndroidRuntime: 	at com.google.ipc.invalidation.external.client.contrib.AndroidListener.onHandleIntent(AndroidListener.java:475)
E/AndroidRuntime: 	at org.chromium.components.invalidation.InvalidationClientService.onHandleIntent(InvalidationClientService.java:154)
E/AndroidRuntime: 	at android.app.IntentService$ServiceHandler.handleMessage(IntentService.java:66)
E/AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:102)
E/AndroidRuntime: 	at android.os.Looper.loop(Looper.java:148)
E/AndroidRuntime: 	at android.os.HandlerThread.run(HandlerThread.java:61)


The AccountManagerFacade methods are marked with @MainThread, but the InvalidationClientService caller does not seem to care much about ensuring they are called on the UI thread. 

Boris, can you please have a look?
 
Status: Assigned (was: Unconfirmed)
Sure. Thanks for filing this!
Components: Services>SignIn
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 4 2017

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6f65f76217950158c16c912e819b7ecfc5100da

commit c6f65f76217950158c16c912e819b7ecfc5100da
Author: Boris Sazonov <bsazonov@chromium.org>
Date: Thu Oct 05 16:54:24 2017

[Android] Fix thread assert in InvalidationClientService

This CL adds ThreadUtils.runOnUiThread around call to
AccountManagerFacade.getNewAuthToken as this method should be invoked
on UI thread only.

Bug:  759023 
Change-Id: I67c05084dca091ab1909549556211f84b8dec9c6
Reviewed-on: https://chromium-review.googlesource.com/702303
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506769}
[modify] https://crrev.com/c6f65f76217950158c16c912e819b7ecfc5100da/components/invalidation/impl/android/java/src/org/chromium/components/invalidation/InvalidationClientService.java

Status: Fixed (was: Available)

Sign in to add a comment