Integrate new iOS11 devices to bot configs |
|||||
Issue descriptionI think this includes: - Make sure new iOS devices are configured on swarming downstream - Add product types for new iOS devices (I think iPhone 7 and iPad 5th gen) - Add iphone11-device-x64 - Point to new iOS devices in tests (main waterfall, cq, try, official) depending on load, right now everything points to `iPad Air 2`, since that's the only iOS 11 device on swarming.
,
Aug 25 2017
To reiterate, all the downstream *-device* configs with iOS11 point to `iPad Air 2`, They can be sharded between iPad Air 2 and iPad 5th Gen, plus should also have a config added for iPhone 7. It seemed pretty tedious going thru each config file. I wonder if some of this logic can be refactored / shared?
,
Aug 25 2017
Issue 754358 has been merged into this issue.
,
Aug 25 2017
,
Aug 25 2017
,
Aug 25 2017
re #2 > If you are talking about e.g. on 'ipad11-device-x64' bot, runs through all tests twice with device `iPad Air 2` and `iPad 5th Gen` each time respectively, could simplify the config by bundling the tests to a list, and 'include' it several times with different device configs. For example: https://chrome-internal.googlesource.com/chrome/ios_internal/+/master/build/bots/internal.bling.tryserver/stable-cherry-picker.json#18 Note that 'includes' are not recursive, so tests list json file (like common_tests.json) may not itself include any include dicts. But I think I can put those reused 'tests' (7 ones) to one 'include' for downstream device bots.
,
Aug 25 2017
I'm not sure I understand -- I don't think we need to test both iPad Air 2 and iPad 5th Gen on the same test for devices.
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/f86df0a3249efd0bd33cd917f9a03274948cc708 commit f86df0a3249efd0bd33cd917f9a03274948cc708 Author: Shenghua Zhang <shenghuazhang@chromium.org> Date: Wed Sep 13 01:09:31 2017 [iOS] Add 'iPad 5th Gen' and 'iPhone 7' to iOS product types Bug: 759016 Change-Id: Ica22b743b37a99f54507d2b56e3eaab4de22e5f4 Reviewed-on: https://chromium-review.googlesource.com/664230 Reviewed-by: Justin Cohen <justincohen@chromium.org> Reviewed-by: smut <smut@google.com> Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org> [modify] https://crrev.com/f86df0a3249efd0bd33cd917f9a03274948cc708/scripts/slave/README.recipes.md [modify] https://crrev.com/f86df0a3249efd0bd33cd917f9a03274948cc708/scripts/slave/recipe_modules/ios/api.py [modify] https://crrev.com/f86df0a3249efd0bd33cd917f9a03274948cc708/scripts/slave/recipe_modules/ios/examples/full.expected/errors.json
,
Sep 13 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/42b955043156bdf0ca838a4be3be03a2b117081b commit 42b955043156bdf0ca838a4be3be03a2b117081b Author: Shenghua Zhang <shenghuazhang@google.com> Date: Wed Sep 13 02:07:55 2017
,
Sep 13 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/e14e8accb23509aaf4c381fd44f8c119c0363260 commit e14e8accb23509aaf4c381fd44f8c119c0363260 Author: Shenghua Zhang <shenghuazhang@google.com> Date: Wed Sep 13 19:10:10 2017
,
Sep 14 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build/+/bb253ca0ff1758d4184b3904f0cbcbfe0812f9d9 commit bb253ca0ff1758d4184b3904f0cbcbfe0812f9d9 Author: Shenghua Zhang <shenghuazhang@google.com> Date: Thu Sep 14 01:47:12 2017
,
Sep 15 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/ff79e4207151bfee0aea43c8d385347328d98823 commit ff79e4207151bfee0aea43c8d385347328d98823 Author: Shenghua Zhang <shenghuazhang@google.com> Date: Fri Sep 15 00:19:22 2017
,
Sep 22 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/ca6893f6e5a7d74bf3c8601ecf88c29896d58835 commit ca6893f6e5a7d74bf3c8601ecf88c29896d58835 Author: Shenghua Zhang <shenghuazhang@google.com> Date: Fri Sep 22 19:14:08 2017
,
Sep 23 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by justincohen@chromium.org
, Aug 25 2017