New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 759016 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug


Participants' hotlists:
bling-infra-backlog
Intensive-Care-Bugs


Sign in to add a comment

Integrate new iOS11 devices to bot configs

Project Member Reported by justincohen@chromium.org, Aug 25 2017

Issue description

I think this includes:

- Make sure new iOS devices are configured on swarming downstream
- Add product types for new iOS devices (I think iPhone 7 and iPad 5th gen)
- Add iphone11-device-x64
- Point to new iOS devices in tests (main waterfall, cq, try, official) depending on load, right now everything points to `iPad Air 2`, since that's the only iOS 11 device on swarming.

 
Labels: -Restrict-View-Google
This is all downstream
To reiterate, all the downstream *-device* configs with iOS11 point to `iPad Air 2`, They can be sharded between iPad Air 2 and iPad 5th Gen, plus should also have a config added for iPhone 7.

It seemed pretty tedious going thru each config file.  I wonder if some of this logic can be refactored / shared?
Issue 754358 has been merged into this issue.
Cc: sergeybe...@chromium.org
Components: -Infra Infra>Client>iOS
Cc: jbudorick@chromium.org
re #2 > If you are talking about e.g. on 'ipad11-device-x64' bot, runs through all tests twice with device `iPad Air 2` and `iPad 5th Gen` each time respectively, could simplify the config by bundling the tests to a list, and 'include' it several times with different device configs. For example: https://chrome-internal.googlesource.com/chrome/ios_internal/+/master/build/bots/internal.bling.tryserver/stable-cherry-picker.json#18

Note that 'includes' are not recursive, so tests list json file (like common_tests.json) may not itself include any include dicts. But I think I can put those reused 'tests' (7 ones) to one 'include' for downstream device bots.
I'm not sure I understand -- I don't think we need to test both iPad Air 2 and iPad 5th Gen on the same test for devices.
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/42b955043156bdf0ca838a4be3be03a2b117081b

commit 42b955043156bdf0ca838a4be3be03a2b117081b
Author: Shenghua Zhang <shenghuazhang@google.com>
Date: Wed Sep 13 02:07:55 2017

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/e14e8accb23509aaf4c381fd44f8c119c0363260

commit e14e8accb23509aaf4c381fd44f8c119c0363260
Author: Shenghua Zhang <shenghuazhang@google.com>
Date: Wed Sep 13 19:10:10 2017

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/bb253ca0ff1758d4184b3904f0cbcbfe0812f9d9

commit bb253ca0ff1758d4184b3904f0cbcbfe0812f9d9
Author: Shenghua Zhang <shenghuazhang@google.com>
Date: Thu Sep 14 01:47:12 2017

Project Member

Comment 12 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/ff79e4207151bfee0aea43c8d385347328d98823

commit ff79e4207151bfee0aea43c8d385347328d98823
Author: Shenghua Zhang <shenghuazhang@google.com>
Date: Fri Sep 15 00:19:22 2017

Project Member

Comment 13 by bugdroid1@chromium.org, Sep 22 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/ca6893f6e5a7d74bf3c8601ecf88c29896d58835

commit ca6893f6e5a7d74bf3c8601ecf88c29896d58835
Author: Shenghua Zhang <shenghuazhang@google.com>
Date: Fri Sep 22 19:14:08 2017

Status: Fixed (was: Assigned)

Sign in to add a comment