ForceBrowserSignin escape |
||||
Issue descriptionChrome Version: ToT OS: Linux What steps will reproduce the problem? (1) Disable ForceBrowserSignin (2) Start browser from a fresh directory (3) Close browser (4) Enable ForceBrowserSignin (5) Start browser from shell (6) Sign in (7) On "Link your Chrome data to this account" screen hit Ctrl-C in the shell (8) Start browser What is the expected result? User should be forced to sign in. What happens instead? User may browse the web without being signed in and without receiving policy.
,
Aug 25 2017
When Chrome does not ended normally, the last used profile during Chrome launching is actually Guest Profile and it will be switched to normal profile later. This causes the issue of sign in status check because Guest Profile doesn't have profile entry in "Local State" file as normal profile. The fix will be double check the profile sign-in status when loaded into memory (We had this check already. However, it was only kicked in when there is a conflict between Profile and Local State. And there is actually no conflict at all in this case)
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b77864ad82e7b7a5dc0c547aa2ab879d311db98e commit b77864ad82e7b7a5dc0c547aa2ab879d311db98e Author: Owen Min <zmin@chromium.org> Date: Tue Aug 29 19:15:51 2017 Sign out user if it's not sign in during profile loaded Previous, sign in status check during profile loading will only sign out profile when there is a conflict between Profile and Local State. However, it's possible that Profile is not sign in during loaded when there is no proper Bug: 759007 Change-Id: Ic63a306c3f64461a834834daa16e874db4168eff Reviewed-on: https://chromium-review.googlesource.com/636354 Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#498189} [modify] https://crrev.com/b77864ad82e7b7a5dc0c547aa2ab879d311db98e/chrome/browser/profiles/profile_manager.cc
,
Nov 7 2017
,
Nov 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53078c4b7a340af06b08927a4bb0727901aff622 commit 53078c4b7a340af06b08927a4bb0727901aff622 Author: Owen Min <zmin@chromium.org> Date: Thu Nov 09 18:13:24 2017 Revert of "Sign out user if it's not sign in during profile loaded" This is the revert of crrev.com/b77864ad82e7b7a5dc0c547aa2ab879d311db98e Turns out that fix causes crbug.com/775526 . In the mean time, revert won't re-trigger the crbug.com/759007 as it's fixed by crrev.com/9990e87e486cceef3914bcbb82979190315bad3a. Bug: 759007 Bug: 775526 Change-Id: I2cd5acefb3d8588613629a99dde592f648650a93 Reviewed-on: https://chromium-review.googlesource.com/757718 Reviewed-by: anthonyvd <anthonyvd@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#515211} [modify] https://crrev.com/53078c4b7a340af06b08927a4bb0727901aff622/chrome/browser/profiles/profile_manager.cc
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/529510efa03236c73784fe51e73cb984e41ddd1e commit 529510efa03236c73784fe51e73cb984e41ddd1e Author: Owen Min <zmin@chromium.org> Date: Tue Nov 14 00:42:24 2017 [Merge 63]Revert of "Sign out user if it's not sign in during profile loaded" This is the revert of crrev.com/b77864ad82e7b7a5dc0c547aa2ab879d311db98e Turns out that fix causes crbug.com/775526 . In the mean time, revert won't re-trigger the crbug.com/759007 as it's fixed by crrev.com/9990e87e486cceef3914bcbb82979190315bad3a. TBR=zmin@chromium.org (cherry picked from commit 53078c4b7a340af06b08927a4bb0727901aff622) Bug: 759007 Bug: 775526 Change-Id: I2cd5acefb3d8588613629a99dde592f648650a93 Reviewed-on: https://chromium-review.googlesource.com/757718 Reviewed-by: anthonyvd <anthonyvd@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#515211} Reviewed-on: https://chromium-review.googlesource.com/767907 Reviewed-by: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#476} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/529510efa03236c73784fe51e73cb984e41ddd1e/chrome/browser/profiles/profile_manager.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by zmin@chromium.org
, Aug 25 2017