New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 759003 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 21 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task



Sign in to add a comment

Refactor SequentialIDGenerator::MaybeReleaseNumber

Project Member Reported by girard@chromium.org, Aug 25 2017

Issue description

SequentialIDGenerator has two functions - ReleaseNumber, and MaybeReleaseNumber

With https://chromium-review.googlesource.com/c/chromium/src/+/596428 ReleaseNumber is no longer in use. Refactor both functions names so that ReleaseNumber does the same thing as MaybeReleaseNumber, then remove one of them.

 

Comment 1 by girard@chromium.org, Aug 25 2017

Components: UI

Comment 2 by girard@chromium.org, Aug 31 2017

Status: Started (was: Assigned)
Patch is at https://chromium-review.googlesource.com/644855

Comment 3 by girard@chromium.org, Aug 31 2017

Labels: -Type-Bug OS-All Type-Task
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4ab70eec883c83d63c8b9a7141a1bab35c0dc37

commit c4ab70eec883c83d63c8b9a7141a1bab35c0dc37
Author: Eugene Girard <girard@chromium.org>
Date: Fri Sep 15 18:15:18 2017

Refactor (eliminate) MaybeReleaseNumber

In a recent patch I added the function SequentialIDGenerator::MaybeReleaseNumber which
protected against two threads assigning and releasing the same number. During review,
it was suggested we could get rid of ReleaseNumber since all clients had been migrated
to MaybeReleaseNumber.

This patch cleans up the two functions, leaving only one. 

Bug:  759003 
Change-Id: I7863162e7abcecfa5e5196f2dec5825e977182f2
Reviewed-on: https://chromium-review.googlesource.com/644855
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Eugene Girard <girard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502306}
[modify] https://crrev.com/c4ab70eec883c83d63c8b9a7141a1bab35c0dc37/ui/events/devices/x11/touch_factory_x11.cc
[modify] https://crrev.com/c4ab70eec883c83d63c8b9a7141a1bab35c0dc37/ui/events/ozone/evdev/event_factory_evdev.cc
[modify] https://crrev.com/c4ab70eec883c83d63c8b9a7141a1bab35c0dc37/ui/gfx/sequential_id_generator.cc
[modify] https://crrev.com/c4ab70eec883c83d63c8b9a7141a1bab35c0dc37/ui/gfx/sequential_id_generator.h
[modify] https://crrev.com/c4ab70eec883c83d63c8b9a7141a1bab35c0dc37/ui/gfx/sequential_id_generator_unittest.cc
[modify] https://crrev.com/c4ab70eec883c83d63c8b9a7141a1bab35c0dc37/ui/views/win/hwnd_message_handler.cc
[modify] https://crrev.com/c4ab70eec883c83d63c8b9a7141a1bab35c0dc37/ui/views/win/pen_event_processor.cc

Comment 5 by girard@chromium.org, Sep 16 2017

Status: Fixed (was: Started)

Sign in to add a comment