New issue
Advanced search Search tips

Issue 758985 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

getting prompt to save password with "Formulare von Google ausfüllen lassen" after password was filled via yolo

Project Member Reported by jochen@chromium.org, Aug 25 2017

Issue description

repro steps (on android o, stable chrome m60):

1) navigate to https://httpbin.org/basic-auth/u/p
2) log in with username u password p
3) chrome offers to save the password in yolo, accept the offer
4) stop chrome
5) re-open chrome and navigate to the URL from 1) again
6) notice that the username and password is already filled

expected results:

page loads, nothing else

actual results:
there's now a prompt that offers to save the password in "Formulare von Google ausfüllen lassen" (German for "store passwords in 'let Google fill-in forms'" - I guess that's just a poor translation of the new android autofill feature?)


 
Screenshot_20170825-151916.png
64.4 KB View Download

Comment 1 by battre@chromium.org, Aug 25 2017

Cc: sgu...@chromium.org twelling...@chromium.org melandory@chromium.org
I guess what's needed is to add https://developer.android.com/reference/android/view/View.html#attr_android:importantForAutofill to chrome/android/java/res/layout/http_auth_dialog.xml.

Adding a few folks as I don't have an Android O development phone around.
Labels: M-62
Status: Untriaged (was: Unconfirmed)
Tested the issue using #60.0.3112.107 on Android 8 (o) Nexus 6P HUAWEI and was able to reproduce the issue as per the steps mentioned in comment #0. 

Observed the same behavior since M58. Hence marking it as Untriaged to get more input's on this.

Please navigate to below link for the logs & video.

go/chrome-androidlogs/758985

Thanks!!
Labels: TE-DesktopTriage

Comment 4 by sgu...@chromium.org, Sep 27 2017

Cc: -sgu...@chromium.org
Selim is right, it you want to disable automatic autofill, you could mark the root view of that activity as android:importantForAutofill=noExcludeDescendants
Owner: jochen@chromium.org
Status: Assigned (was: Untriaged)
CL under review: https://chromium-review.googlesource.com/c/chromium/src/+/707145
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52cf162b1d1a0411c94cf0cf765b1c776b057ec8

commit 52cf162b1d1a0411c94cf0cf765b1c776b057ec8
Author: Jochen Eisinger <jochen@chromium.org>
Date: Tue Oct 10 18:24:27 2017

Mark HTTP auth dialog is not important for autofill

Otherwise, users get prompted everytime they use the http auth dialog,
even when the credentials are managed by chrome's password manager.

BUG= 758985 

Change-Id: I759bdf0ffd988f81d2299b3aa0fc82fb9906eb11
Reviewed-on: https://chromium-review.googlesource.com/707145
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507725}
[modify] https://crrev.com/52cf162b1d1a0411c94cf0cf765b1c776b057ec8/chrome/android/java/res/layout/http_auth_dialog.xml

Comment 8 by jochen@chromium.org, Oct 11 2017

Status: Fixed (was: Assigned)

Sign in to add a comment