New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758964 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1% regression in sizes at 495684:495684

Project Member Reported by kraynov@chromium.org, Aug 25 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Aug 25 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=758964

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=67a11911e9dffd0fb9f93d76fe9d7b54be46c82e34e668fc1068afca4941e7a7


Bot(s) for this bug's original alert(s):

win-32
Owner: updowndota@chromium.org
updowndota: this appears to be caused by r495684: "Avoid calling EmitLoginPromptVisible in voice interaction OOBE flow". Is this 453kib increase to mini_installer.exe expected?
Cc: updowndota@chromium.org
Owner: grt@chromium.org
Actually assigning to grt, windows sizes owner, not sure the graph has the right revision.

Comment 4 by grt@chromium.org, Sep 25 2017

Status: Started (was: Untriaged)
That sort of growth is definitely not expected. That CL is trivial, and had no impact on chrome.dll or chrome_child.dll. I'm trying to see what could have caused mini_installer.exe to grow so much.

Comment 5 by grt@chromium.org, Sep 26 2017

Cc: sullivan@chromium.org
This was caused by rolling Widevine CDM to 1.4.8.1022; see issue 745148. The size of the CDM (which is pulled via src-internal/DEPS) isn't currently measured. It should be. I'll send up a CL for this.

Comment 6 by grt@chromium.org, Sep 26 2017

Cc: grt@chromium.org michae...@chromium.org
 Issue 758963  has been merged into this issue.
Cc: -michae...@chromium.org
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/04da87837734e4f058730b6274a61406a694bd8f

commit 04da87837734e4f058730b6274a61406a694bd8f
Author: Greg Thompson <grt@chromium.org>
Date: Tue Sep 26 21:51:38 2017

Report the sizes of the Widevine CDM on Windows.

BUG= 758964 

Change-Id: Ie273006ad385fd4cb11280519115ea72dd5336c6
Reviewed-on: https://chromium-review.googlesource.com/684897
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>

[modify] https://crrev.com/04da87837734e4f058730b6274a61406a694bd8f/scripts/slave/chromium/sizes.py

Comment 9 by grt@chromium.org, Sep 26 2017

Cc: -grt@chromium.org
Status: WontFix (was: Started)
Marking as WontFix since this wasn't an accidental explosion. The CL in comment 8 should make it easier to find this sort of regression in the future.

sullivan@: could you set up monitoring/alerts for the dlls listed in the above CL so that we get meaningful bugs filed if/when they grow?
Thanks for updating the test! Monitoring added.

Sign in to add a comment