Issue metadata
Sign in to add a comment
|
1% regression in sizes at 495684:495684 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Sep 21 2017
updowndota: this appears to be caused by r495684: "Avoid calling EmitLoginPromptVisible in voice interaction OOBE flow". Is this 453kib increase to mini_installer.exe expected?
,
Sep 21 2017
Actually assigning to grt, windows sizes owner, not sure the graph has the right revision.
,
Sep 25 2017
That sort of growth is definitely not expected. That CL is trivial, and had no impact on chrome.dll or chrome_child.dll. I'm trying to see what could have caused mini_installer.exe to grow so much.
,
Sep 26 2017
This was caused by rolling Widevine CDM to 1.4.8.1022; see issue 745148. The size of the CDM (which is pulled via src-internal/DEPS) isn't currently measured. It should be. I'll send up a CL for this.
,
Sep 26 2017
,
Sep 26 2017
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/04da87837734e4f058730b6274a61406a694bd8f commit 04da87837734e4f058730b6274a61406a694bd8f Author: Greg Thompson <grt@chromium.org> Date: Tue Sep 26 21:51:38 2017 Report the sizes of the Widevine CDM on Windows. BUG= 758964 Change-Id: Ie273006ad385fd4cb11280519115ea72dd5336c6 Reviewed-on: https://chromium-review.googlesource.com/684897 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> [modify] https://crrev.com/04da87837734e4f058730b6274a61406a694bd8f/scripts/slave/chromium/sizes.py
,
Sep 26 2017
Marking as WontFix since this wasn't an accidental explosion. The CL in comment 8 should make it easier to find this sort of regression in the future. sullivan@: could you set up monitoring/alerts for the dlls listed in the above CL so that we get meaningful bugs filed if/when they grow?
,
Sep 27 2017
Thanks for updating the test! Monitoring added. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Aug 25 2017