[MacViewsBrowser] status bubble does not move
Reported by
jongkwon...@navercorp.com,
Aug 25 2017
|
||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3189.0 Safari/537.36 Steps to reproduce the problem: 1. build chrome with mac_views_browser=1 and run 2. open a web page 3. move mouse over a hyperlink located at the bottom of page What is the expected behavior? Status bubble should move below the window or move to the right side of window not to hide link. What went wrong? Status bubble hides the link if the link is at the location of status bubble. Did this work before? No Chrome version: 62.0.3189.0 Channel: n/a OS Version: OS X 10.12.6 Flash Version:
,
Aug 26 2017
,
Sep 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c1cb4850270b8a1597d8f1a1a79bca77bfeca07 commit 4c1cb4850270b8a1597d8f1a1a79bca77bfeca07 Author: jongkwon.lee <jongkwon.lee@navercorp.com> Date: Mon Sep 11 08:58:26 2017 Remove location argument sent to the status bubble WebContentsView was sending mouse location to its delegate with different coordinates for each platform. This makes confusion on Mac because it has two versions of status bubbles which use the location in different coordinates. This patch removes location argument sent to the status bubble and the status bubble uses global functions to get current mouse location. Bug: 758957 Change-Id: I51ca13fd51597694e269f3c10df32f241f0e76c5 Reviewed-on: https://chromium-review.googlesource.com/637471 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Simon Hong <simonhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#500867} [modify] https://crrev.com/4c1cb4850270b8a1597d8f1a1a79bca77bfeca07/chrome/browser/ui/browser.cc [modify] https://crrev.com/4c1cb4850270b8a1597d8f1a1a79bca77bfeca07/chrome/browser/ui/browser.h [modify] https://crrev.com/4c1cb4850270b8a1597d8f1a1a79bca77bfeca07/chrome/browser/ui/cocoa/status_bubble_mac.h [modify] https://crrev.com/4c1cb4850270b8a1597d8f1a1a79bca77bfeca07/chrome/browser/ui/cocoa/status_bubble_mac.mm [modify] https://crrev.com/4c1cb4850270b8a1597d8f1a1a79bca77bfeca07/chrome/browser/ui/cocoa/status_bubble_mac_unittest.mm [modify] https://crrev.com/4c1cb4850270b8a1597d8f1a1a79bca77bfeca07/chrome/browser/ui/status_bubble.h [modify] https://crrev.com/4c1cb4850270b8a1597d8f1a1a79bca77bfeca07/chrome/browser/ui/views/status_bubble_views.cc [modify] https://crrev.com/4c1cb4850270b8a1597d8f1a1a79bca77bfeca07/chrome/browser/ui/views/status_bubble_views.h [modify] https://crrev.com/4c1cb4850270b8a1597d8f1a1a79bca77bfeca07/components/guest_view/browser/guest_view_base.cc [modify] https://crrev.com/4c1cb4850270b8a1597d8f1a1a79bca77bfeca07/components/guest_view/browser/guest_view_base.h [modify] https://crrev.com/4c1cb4850270b8a1597d8f1a1a79bca77bfeca07/content/browser/web_contents/web_contents_view_aura.cc [modify] https://crrev.com/4c1cb4850270b8a1597d8f1a1a79bca77bfeca07/content/browser/web_contents/web_contents_view_mac.mm [modify] https://crrev.com/4c1cb4850270b8a1597d8f1a1a79bca77bfeca07/content/public/browser/web_contents_delegate.h
,
Mar 23 2018
The status bubble doesn't show up at *all* in MacViews browser, so there's something odd going on here. I'll look.
,
Mar 27 2018
,
Mar 29 2018
** Bulk Edit ** FYI: Starting 04/13 M68 will be in canary, M68 Dev promotion will be on 04/26.
,
Apr 25 2018
Pls mark the bug as fixed if CL is landed in trunk and nothing else is pending. Thank you.
,
Jun 20 2018
,
Jul 12
,
Jul 12
,
Jul 26
,
Jul 26
Is this fixed? |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by meh...@chromium.org
, Aug 25 2017Components: -UI UI>Browser>StatusBubble
Labels: Proj-MacViews