New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758943 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.6% regression in system_health.memory_mobile at 496217:496262

Project Member Reported by kraynov@chromium.org, Aug 25 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Aug 25 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=758943

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=49109449dfaf842db6097d21f6a346b1ab17fad07d0245e0bf876fee2b9e5faf


Bot(s) for this bug's original alert(s):

android-webview-nexus6
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 25 2017

Cc: jkummerow@chromium.org
Owner: jkummerow@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author jkummerow@chromium.org ===

Hi jkummerow@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Jakob Kummerow
  Commit : 1785fc368edf760c22b94def899f8364256990ee
  Date   : Mon Aug 21 21:34:09 2017
  Subject: [StoreIC] Don't create handlers for fresh transitions

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_chrome:v8:effective_size_avg/load_search/load_search_taobao
  Change       : 1.86% | 4215074.66667 -> 4293543.33333

Revision                           Result                  N
chromium@496216                    4215075 +- 7944.57      6      good
chromium@496228                    4217232 +- 6444.97      6      good
chromium@496229                    4215662 +- 19771.3      6      good
chromium@496229,v8@1785fc368e      4272791 +- 44409.3      6      bad       <--
chromium@496229,v8@6e13ca6d64      4288477 +- 64471.7      6      bad
chromium@496229,v8@e7af579ff3      4282347 +- 62025.1      6      bad
chromium@496230                    4281431 +- 50216.9      6      bad
chromium@496231                    4287461 +- 62423.5      6      bad
chromium@496234                    4300700 +- 52976.8      6      bad
chromium@496239                    4295489 +- 54298.0      6      bad
chromium@496262                    4293543 +- 59964.3      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.search.taobao system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8970288028096121200


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Aug 28 2017

Cc: tebbi@chromium.org
 Issue 759466  has been merged into this issue.
Status: WontFix (was: Assigned)
#3: That doesn't make any sense; this CL makes V8 use less memory. In fact, when checking all changes at that commit, a bunch of "system_health.memory_mobile" tests improve by 1-2%, only this one regresses. I suspect measurement artifacts.

#4: Overall time went down, so who cares if the "Optimize" bucket went up a bit? 
(Besides, I don't see what the suspected culprit CL might have to do with optimization times -- I'd expect a small impact on the "IC" bucket (could be either positive or negative), and some memory savings, but no impact on optimization decisions or timings.)

Sign in to add a comment