New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758916 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-09-30
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

[Android WebView] Lower minidump crash reporting fraction in time for 62 Stable.

Project Member Reported by gsennton@chromium.org, Aug 25 2017

Issue description

We did this for 61 in   crbug.com/740484  

for that release we used 1% as the fraction - we should do so for 62 as well.
 
gsennton@ please what's the status on this blocker? We aim to fix our blockers as early in the cycle as possible.
This is the reoccurring change we have to land for every release for Silent Feedback - it lowers the fraction of WebView crashes being reported to us. So we want to let this be for as long as possible throughout the Beta period, and then land the change just before going to Stable.

In that way we receive 100% of the crashes on Beta (up until the last couple of Beta releases), but only 1% of the crashes on Stable (to ensure we aren't using up all of our crash reporting quota).


It is not a great solution, but right now it's the only one we have. When we have Finch in WebView we could switch over to having this as a Finch configuration setting this fraction depending on the version of the WebView (but even then we can't set which version will be the Stable one beforehand so we won't know exactly which version to lower the reporting fraction for).

Comment 3 by cma...@chromium.org, Sep 11 2017

Got it!
The NextAction date has arrived: 2017-09-30
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 9 2017

Labels: merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aec89b06ee998af25758fef23c1ddc4e7d44b6d5

commit aec89b06ee998af25758fef23c1ddc4e7d44b6d5
Author: Gustav Sennton <gsennton@google.com>
Date: Mon Oct 09 11:03:19 2017

[Android WebView] Lower minidump generation fraction to 1% for Stable

To avoid hitting the cap on the number of uploaded crash reports per day
we lower the fraction of uploaded reports from 100% for Beta to 1% for
Stable.
Note that there should be at least one Beta version with the new lowered
fraction since we do not want to re-push Beta just for this change.

BUG= 758916 

Change-Id: Ie9074141afaed697b1456c9ff6567d6b79f6f83c
Reviewed-on: https://chromium-review.googlesource.com/697804
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#614}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/aec89b06ee998af25758fef23c1ddc4e7d44b6d5/android_webview/common/crash_reporter/aw_microdump_crash_reporter.cc

Status: Fixed (was: Assigned)
Verified this issue on Walleye/OPM1.171011.001 & GENERAL MOBILE 4GDUAL(SEED)/N2F69 on Monochrome: 62.0.3202.52
Status: Verified (was: Fixed)

Sign in to add a comment