New issue
Advanced search Search tips

Issue 758913 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

cros tryjob failed to parse CL dependency

Project Member Reported by manojgupta@chromium.org, Aug 25 2017

Issue description

This failed:
cros tryjob -g''611920 611646 *437413' nyan_kitty-paladin kevin-paladin 
Verifying patches...
03:36:07: ERROR: cros tryjob failed before completing.
03:36:07: ERROR: Cannot parse the dependency: 611920 611646 *437413

But the same using cbuildbot works
cbuildbot --remote -g''611920 611646 *437413' nyan_kitty-paladin kevin-paladin

Successfully sent PUT request to [buildbucket_bucket:master.chromiumos.tryserver] with [config:nyan_kitty-paladin] [buildbucket_id:8970294650582361648].
Successfully sent PUT request to [buildbucket_bucket:master.chromiumos.tryserver] with [config:kevin-paladin] [buildbucket_id:8970294650345421248].

 
-g before each CL works, but that one is supposed to work as well. 
Status: Started (was: Untriaged)
quick$cros tryjob --debug -g "634133 634515" lumpy-paladin
14:47:46: DEBUG: Cache dir lookup.
14:47:46: DEBUG: Configured cache_dir to '/usr/local/google/home/dgarrett/sand/quick/.cache'
Verifying patches...
14:47:46: ERROR: cros tryjob failed before completing.
cros: Unhandled exception:
Traceback (most recent call last):
  File "/usr/local/google/home/dgarrett/sand/quick/chromite/bin/cros", line 168, in <module>
    DoMain()
  File "/usr/local/google/home/dgarrett/sand/quick/chromite/bin/cros", line 164, in DoMain
    commandline.ScriptWrapperMain(FindTarget)
  File "/usr/local/google/home/dgarrett/sand/quick/chromite/lib/commandline.py", line 910, in ScriptWrapperMain
    ret = target(argv[1:])
  File "/usr/local/google/home/dgarrett/sand/quick/chromite/scripts/cros.py", line 65, in main
    code = _RunSubCommand(subcommand)
  File "/usr/local/google/home/dgarrett/sand/quick/chromite/scripts/cros.py", line 50, in _RunSubCommand
    return subcommand.Run()
  File "/usr/local/google/home/dgarrett/sand/quick/chromite/cli/cros/cros_tryjob.py", line 333, in Run
    remote_patches=[])
  File "/usr/local/google/home/dgarrett/sand/quick/chromite/cbuildbot/trybot_patch_pool.py", line 140, in FromOptions
    gerrit_patches = gerrit.GetGerritPatchInfo(gerrit_patches)
  File "/usr/local/google/home/dgarrett/sand/quick/chromite/lib/gerrit.py", line 460, in GetGerritPatchInfo
    [cros_patch.ParsePatchDep(p) for p in patches])
  File "/usr/local/google/home/dgarrett/sand/quick/chromite/lib/patch.py", line 548, in ParsePatchDep
    raise ValueError('Cannot parse the dependency: %s' % original_text)
ValueError: Cannot parse the dependency: 634133 634515

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/53cca86535f836bbc6fff87d24ae73f5c95ac3e8

commit 53cca86535f836bbc6fff87d24ae73f5c95ac3e8
Author: Don Garrett <dgarrett@google.com>
Date: Fri Sep 01 02:54:04 2017

cros tryjob: Fix -g "123 456" parsing.

cros tryjob handling of multiple patches in a single argument listing
was broken. Fix it!

BUG= chromium:758913 
TEST=unittest + cros tryjob --debug -g "634133 634515" lumpy-paladin

Change-Id: If28823c5a24e04d98dc498f6096ffc6f5f79a3ee
Reviewed-on: https://chromium-review.googlesource.com/636703
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/53cca86535f836bbc6fff87d24ae73f5c95ac3e8/cli/cros/cros_tryjob.py

This should now be fixed when you sync.
Thanks!
Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment