New issue
Advanced search Search tips

Issue 758892 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 678905



Sign in to add a comment

external/wpt/service-workers/service-worker/fetch-frame-resource.https.html times out

Project Member Reported by falken@chromium.org, Aug 25 2017

Issue description

There's a TestExpectation for the old bug  issue 602693 , but this is now the only test using that bug, so we should update the bug to this one.
 

Comment 1 by falken@chromium.org, Sep 13 2017

Status: Started (was: Available)
See https://github.com/w3c/ServiceWorker/issues/1194

Comment 2 by falken@chromium.org, Sep 13 2017

Owner: falken@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f373188e1c01d3fa6fae7fb554ed45ba9348a4e6

commit f373188e1c01d3fa6fae7fb554ed45ba9348a4e6
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Sep 13 09:22:59 2017

service worker: Fix WPT test fetch-frame-resource.https.html

There were two issues:
* The contentWindow access was throwing an exception because Chrome's
error pages are considered cross-origin.
* The test uses a setTimeout of 10 sec since Mozilla had flaky failures at 5
sec. This issue is still unresolved, see github.com/w3c/ServiceWorker/issues/1194
However, somehow the test seems to pass on local Release despite taking over
6 seconds, so I'm leaving it out of SlowTests for now.

Bug:  758892 
Change-Id: I4ff501bcc679db6e7d6ddd7d70adfd33e79bd718
Reviewed-on: https://chromium-review.googlesource.com/664460
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501575}
[modify] https://crrev.com/f373188e1c01d3fa6fae7fb554ed45ba9348a4e6/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/f373188e1c01d3fa6fae7fb554ed45ba9348a4e6/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-frame-resource.https.html

Comment 4 by falken@chromium.org, Sep 13 2017

Status: Fixed (was: Started)

Comment 5 by mek@chromium.org, Sep 13 2017

FYI, you should never need to add WPT tests to SlowTests, as having <meta name=timeout content=long> in the test is treated equivalently.

Comment 6 by falken@chromium.org, Sep 14 2017

Nice. Filed issue 765026

Sign in to add a comment