New issue
Advanced search Search tips

Issue 758891 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Jun 2018
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Experimental flag changes are not committed to disk.

Project Member Reported by jif@chromium.org, Aug 25 2017 
To reproduce:
1/ Launch Chrome iOS from Xcode.
2/ Open chrome://flags in Chrome iOS
3/ Change an experimental flag.
4/ Kill Chrome iOS from Xcode.
5/ Relaunch Chrome iOS, visit chrome://flags

What is expected:
I expect to see the change I've made to be saved.

What actually happens:
The change to the experimental flag is not saved.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69df1456d46ec39f63feff5c3721e0d47059b928

commit 69df1456d46ec39f63feff5c3721e0d47059b928
Author: Jean-François Geyelin <jif@chromium.org>
Date: Fri Aug 25 16:05:45 2017

Immediately store to disk changes to experimental flags.

Bug:  758891 
Change-Id: I95352f3f2abcd6484a940aeb5c694d3ec868dcaa
Reviewed-on: https://chromium-review.googlesource.com/633923
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Alexei Svitkine (very slow) <asvitkine@chromium.org>
Commit-Queue: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497423}
[modify] https://crrev.com/69df1456d46ec39f63feff5c3721e0d47059b928/components/flags_ui/flags_storage.h
[modify] https://crrev.com/69df1456d46ec39f63feff5c3721e0d47059b928/components/flags_ui/pref_service_flags_storage.cc
[modify] https://crrev.com/69df1456d46ec39f63feff5c3721e0d47059b928/components/flags_ui/pref_service_flags_storage.h
[modify] https://crrev.com/69df1456d46ec39f63feff5c3721e0d47059b928/ios/chrome/browser/ui/webui/flags_ui.cc

Comment 2 by eugene...@chromium.org, Jun 22 2018

Owner: ----
Status: Untriaged (was: Started)
jif@ is no longer on the team. Releasing his bugs for triage.

Comment 3 by sczs@chromium.org, Jun 27 2018

Status: Fixed (was: Untriaged)
I've been doing this for a long time and it works.
►

Sign in to add a comment