New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758890 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Blink of 'IP address' details are seen on disabling 'Configure IP address automatically' option when Wi-Fi network is disconnected in chrome://settings

Project Member Reported by mmanchala@chromium.org, Aug 25 2017

Issue description

Chrome Version: 62.0.3195.0/9876.0.0 dev-channel Kip,Daisy and Minnie
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Go to chrome://md-settings page
(2)Now at 'Network' section click on Wi-Fi -> select Connected Wi-Fi network -> click on 'Network' -> so that 'IP address','Routing prefix','Gateway' & 'IPv6 address' details are seen at 'Configure IP address automatically'
(3)Click on 'DISCONNECT' ->Now disable 'Configure IP address automatically' option and observe blink of 'IP address','Routing prefix','Gateway' & 'IPv6 address' details are seen   (Please refer video and screenshot)

Expected: Blink of 'IP address','Routing prefix','Gateway' & 'IPv6 address' details should not be displayed on disabling 'Configure IP address automatically' option

Actual: Instead blink of 'IP address','Routing prefix','Gateway' & 'IPv6 address' details are seen
 
This is Regression issue as same is working fine in old chrome://settings.

@stevenjb : Please confirm the issue
 
Actual.webm
583 KB View Download
Actual_BlinkOfIPAddressValues.jpg
551 KB View Download
Labels: Hotlist-MD-Settings-Internet
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b18ea898596222e903b648ca01be71d37365653

commit 9b18ea898596222e903b648ca01be71d37365653
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Sep 22 16:49:31 2017

Settings: Network: Show static IP configs

Also only shows the IP Address line when connected.

Bug:  758890 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7e167f5755140f6498524967eee89d0fd73bf09e
Reviewed-on: https://chromium-review.googlesource.com/675844
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503768}
[modify] https://crrev.com/9b18ea898596222e903b648ca01be71d37365653/chrome/browser/resources/settings/internet_page/internet_detail_page.html
[modify] https://crrev.com/9b18ea898596222e903b648ca01be71d37365653/chrome/browser/resources/settings/internet_page/internet_detail_page.js
[modify] https://crrev.com/9b18ea898596222e903b648ca01be71d37365653/ui/webui/resources/cr_components/chromeos/network/network_ip_config.js

Labels: Merge-Request-62
Status: Fixed (was: Started)
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 23 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-62 Merge-Approved-62
Approved for 62.
Project Member

Comment 7 by sheriffbot@chromium.org, Oct 2 2017

Cc: bhthompson@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 2 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9b7f6c1db01ffff55fc256e417461637d27df99

commit a9b7f6c1db01ffff55fc256e417461637d27df99
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Oct 02 16:37:25 2017

Settings: Network: Show static IP configs

Also only shows the IP Address line when connected.

TBR=stevenjb@chromium.org

(cherry picked from commit 9b18ea898596222e903b648ca01be71d37365653)

Bug:  758890 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7e167f5755140f6498524967eee89d0fd73bf09e
Reviewed-on: https://chromium-review.googlesource.com/675844
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503768}
Reviewed-on: https://chromium-review.googlesource.com/695681
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#534}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/a9b7f6c1db01ffff55fc256e417461637d27df99/chrome/browser/resources/settings/internet_page/internet_detail_page.html
[modify] https://crrev.com/a9b7f6c1db01ffff55fc256e417461637d27df99/chrome/browser/resources/settings/internet_page/internet_detail_page.js
[modify] https://crrev.com/a9b7f6c1db01ffff55fc256e417461637d27df99/ui/webui/resources/cr_components/chromeos/network/network_ip_config.js

Sign in to add a comment