New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 758882 link

Starred by 1 user
Status: Fixed
Owner:
█ galinap@google.com
Email to this user bounced
Closed: Aug 2017
Cc:
klo...@chromium.org
█ dgn@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Site Explore sometimes doesn't show suggestions in Personalized section

Project Member Reported by galinap@google.com, Aug 25 2017 
The Site Explore UI doesn't show any suggestions in the Personalized section.

Steps to reproduce:

1. Enable Chrome Home
2. Open and close bottom sheet
3. Open bottom sheet - there are no tiles in the personalized section
4. Swipe/click to another section - there are tiles there
5. Switch back to Personalized section - the personalized tiles show up

Comment 1 by galinap@google.com, Aug 30 2017

Status: Fixed (was: Started)
This was fixed in this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/631958

[Site Explore] Override SiteExploreViewPager.onMeasure to measure height of children

We need to override SiteExploreViewPager.onMeasure because ViewPager does not
properly handle wrap_content as its height measurement. It sets the height to 0.
This is because different pages might have different heights and the ViewPager
doesn't know which one to choose.
We know that the SiteExploreViewPager will hold a TabLayout and a TileGridLayout
at all times, so we can calculate its height explicitly.
►

Sign in to add a comment