graphics_drm 'null_platform_test' fails on Kevin with llvm-next |
||||||||
Issue description08/22 06:48:28.484 DEBUG| graphics_Drm:0131| Running test null_platform_test. 08/22 06:48:28.486 DEBUG| utils:0212| Running 'null_platform_test' 08/22 06:48:28.881 DEBUG| utils:0280| [stderr] ERROR:main():null_platform_test.c:223:failed to call image_flush_external 08/22 06:48:29.579 ERROR| graphics_Drm:0079| Failed: null_platform_test (exit=1) 08/22 06:48:29.599 DEBUG| graphics_Drm:0080| Command <null_platform_test> failed, rc=1, Command returned non-zero exit status Fails only with llvm-next.
,
Sep 1 2017
The offending LLVM CL is commit f41c3c9239734af0a6c543430ea4ffd2dfe736cb (HEAD) Author: Kristof Beyls <kristof.beyls@arm.com> Date: Wed Jun 28 07:07:03 2017 +0000 [ARM] Make -mcpu=generic schedule for an in-order core (Cortex-A8).
,
Sep 25 2017
This might be a source code problem. Assign this to the graphics people to have them take a look at this first. The test fails because bs_egl_image_flush_external (eglImageFlushExternalEXT) checks the value of img->external, which is set by bs_egl_image_create_gbm. bs_egl_image_create_gbm calls eglCreateImageKHR, this function does not initialize the value img_external_flush, which can be set by eglp_get_attribute_value_if_present if EGL_IMAGE_EXTERNAL_FLUSH_EXT appears in the parameter (const EGLint *attrib_list) of function eglCreateImageKHR. In the test, the eglCreateImageKHR is not set in bs_egl_image_create_gbm, so we just got lucky to have this test passed.
,
Sep 25 2017
,
Sep 25 2017
Raise the priority to p1 because this blocks us from rolling the compiler.
,
Sep 25 2017
,
Sep 27 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/vendor/mali-ddk/+/049a4653f028309ea74c795c2b4bed5490f6d54a commit 049a4653f028309ea74c795c2b4bed5490f6d54a Author: Gurchetan Singh <gurchetansingh@google.com> Date: Wed Sep 27 05:35:20 2017
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/drm-tests/+/cb9c8d1cae2a6107199bff7528c8fe2e783fec59 commit cb9c8d1cae2a6107199bff7528c8fe2e783fec59 Author: Gurchetan Singh <gurchetansingh@chromium.org> Date: Thu Sep 28 06:52:11 2017 drm-tests: specify EGL_IMAGE_EXTERNAL_FLUSH_EXT when creating EGLImage EGL_IMAGE_EXTERNAL_FLUSH_EXT attribute should be set to EGL_TRUE when creating an image that supports eglImageFlushExternalEXT. This breaks the NVIDIA eglCreateImageKHR code since it doesn't recognize EGL_IMAGE_EXTERNAL_FLUSH_EXT but advertises the extension. Let's work-around this. BUG= chromium:758878 TEST=null_platform_test on Kevin and nyan_big CQ-DEPEND=CL:*462914 Change-Id: I05193f45b4d4a3a25076cd5ff2d90b2adee048f4 Reviewed-on: https://chromium-review.googlesource.com/683318 Commit-Ready: Gurchetan Singh <gurchetansingh@chromium.org> Tested-by: Gurchetan Singh <gurchetansingh@chromium.org> Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org> [modify] https://crrev.com/cb9c8d1cae2a6107199bff7528c8fe2e783fec59/bsdrm/src/egl.c
,
Sep 29 2017
,
Oct 3 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by yunlian@chromium.org
, Aug 31 2017