New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758846 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 753158
issue 759774
issue 766193



Sign in to add a comment

Implement cron job to audit commits that have been scheduled.

Project Member Reported by robert...@chromium.org, Aug 25 2017

Issue description

Once the commit scanner has determined that a given commit belongs to a monitored account, this job should run the appropriate rules and update the datastore accordingly.
 
Blocking: 759774
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/6b80dc3414708bb9bfcc63596d424a16e52746dd

commit 6b80dc3414708bb9bfcc63596d424a16e52746dd
Author: Roberto Carrillo <robertocn@google.com>
Date: Thu Sep 07 23:24:22 2017

[cr-audit-commits] Commit auditor cron job.

This handler spawns worker threads that execute the defined rules on the
commits that the commit scanner has schedule for audit.

Bug:758846
Change-Id: Ic5e3f09f577bb51911d085e910bc678b279620cf
R=stgao,dnj,iannucci,chanli
Reviewed-on: https://chromium-review.googlesource.com/634929
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/6b80dc3414708bb9bfcc63596d424a16e52746dd/go/src/infra/appengine/cr-audit-commits/app/commit_scanner.go
[add] https://crrev.com/6b80dc3414708bb9bfcc63596d424a16e52746dd/go/src/infra/appengine/cr-audit-commits/app/commit_auditor.go
[modify] https://crrev.com/6b80dc3414708bb9bfcc63596d424a16e52746dd/go/src/infra/appengine/cr-audit-commits/app/rules_config.go
[modify] https://crrev.com/6b80dc3414708bb9bfcc63596d424a16e52746dd/go/src/infra/appengine/cr-audit-commits/app/app.go

Blocking: 766193
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/141e6687a297c15047aa3a0afc6ee2f35e94e0a8

commit 141e6687a297c15047aa3a0afc6ee2f35e94e0a8
Author: Roberto Carrillo <robertocn@google.com>
Date: Thu Sep 21 00:23:25 2017

[cr-audit-commits] Add missing test for commit auditor handler.

Also fix bug in slice initializer.

R=stgao,chanli
BUG= 758846 

Change-Id: Ie7db6e7995c26851bf69f9a7d0eefa15b809de88
Reviewed-on: https://chromium-review.googlesource.com/667981
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[add] https://crrev.com/141e6687a297c15047aa3a0afc6ee2f35e94e0a8/go/src/infra/appengine/cr-audit-commits/app/commit_auditor_test.go

Status: Fixed (was: Started)

Sign in to add a comment