New issue
Advanced search Search tips

Issue 758837 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Switch MigrateToDircryptoEx to MigrateToDircrypto

Project Member Reported by pmarko@chromium.org, Aug 25 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/c809845b20424f42c936190d1276b99825880500

commit c809845b20424f42c936190d1276b99825880500
Author: Eric Caruso <ejcaruso@chromium.org>
Date: Fri Feb 09 07:42:42 2018

cryptohome: add migrate_request argument to MigrateToDircrypto

Chrome only uses MigrateToDircryptoEx now, and the CLI already
wraps MigrateToDircryptoEx so we can make the APIs line up in
preparation for the method rename.

BUG= chromium:758837 
TEST=unit tests

Change-Id: I3168a77f24512ef4bfebb03759a580a04e38d8f0
Reviewed-on: https://chromium-review.googlesource.com/900299
Commit-Ready: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/c809845b20424f42c936190d1276b99825880500/cryptohome/service.cc
[modify] https://crrev.com/c809845b20424f42c936190d1276b99825880500/cryptohome/interface.cc
[modify] https://crrev.com/c809845b20424f42c936190d1276b99825880500/cryptohome/dbus_bindings/org.chromium.CryptohomeInterface.xml
[modify] https://crrev.com/c809845b20424f42c936190d1276b99825880500/cryptohome/interface.h

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fb734513eb3d69a9a153057a044ec134f7eab24

commit 8fb734513eb3d69a9a153057a044ec134f7eab24
Author: Pavol Marko <pmarko@chromium.org>
Date: Fri Feb 09 14:58:44 2018

cryptohome: Use MigrateToDircrypto instead of MigrateToDircryptoEx

After CL:900299, MigrateToDircryptoEx and MigrateToDircrypto are
synonymous, so switch back to MigrateToDircrypto.

BUG= 758837 

Change-Id: Id3eae32963c06491ad74464e6641a6acb4c1b008
Reviewed-on: https://chromium-review.googlesource.com/901243
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535710}
[modify] https://crrev.com/8fb734513eb3d69a9a153057a044ec134f7eab24/chromeos/dbus/cryptohome_client.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/4f471c8ee65d3f2d05a2afb05e75153c19ccbb9b

commit 4f471c8ee65d3f2d05a2afb05e75153c19ccbb9b
Author: Eric Caruso <ejcaruso@chromium.org>
Date: Mon Mar 19 21:19:12 2018

cryptohome: remove MigrateToDircryptoEx constant

This method is dead. Remove the constant so nobody can call it in
the future.

BUG= chromium:758837 
TEST=emerge

Change-Id: Ie9f841f38cb44be36e7ced3e0acb5d7271f28494
Reviewed-on: https://chromium-review.googlesource.com/965012
Commit-Ready: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/4f471c8ee65d3f2d05a2afb05e75153c19ccbb9b/dbus/cryptohome/rpc.proto
[modify] https://crrev.com/4f471c8ee65d3f2d05a2afb05e75153c19ccbb9b/dbus/cryptohome/dbus-constants.h

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ebce44e5691b41a0236b8fe5b5bae4ed547a3d78

commit ebce44e5691b41a0236b8fe5b5bae4ed547a3d78
Author: Eric Caruso <ejcaruso@chromium.org>
Date: Mon Mar 19 21:18:58 2018

cryptohome: remove MigrateToDircryptoEx D-Bus endpoint

Nobody uses this, as MigrateToDircrypto provides exactly the same
API. Remove the generated bindings and glue layers so we can't
use this endpoint in the future.

BUG= chromium:758837 
TEST=unit tests

Change-Id: I6a9c55647ee4baaeebd2f6725cd5b1eb6048f9d1
Reviewed-on: https://chromium-review.googlesource.com/964911
Commit-Ready: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/ebce44e5691b41a0236b8fe5b5bae4ed547a3d78/cryptohome/etc/Cryptohome.conf
[modify] https://crrev.com/ebce44e5691b41a0236b8fe5b5bae4ed547a3d78/cryptohome/cryptohome.cc
[modify] https://crrev.com/ebce44e5691b41a0236b8fe5b5bae4ed547a3d78/cryptohome/interface.cc
[modify] https://crrev.com/ebce44e5691b41a0236b8fe5b5bae4ed547a3d78/cryptohome/dbus_bindings/org.chromium.CryptohomeInterface.xml
[modify] https://crrev.com/ebce44e5691b41a0236b8fe5b5bae4ed547a3d78/cryptohome/interface.h

Components: OS>Systems>Security
Status: Fixed (was: Assigned)
IIUC this is fixed

Sign in to add a comment