New Style notification design adjustment |
||
Issue descriptionCurrently new-style notification is not matched with ARC notification. We need to investigate the difference and match them by modifying both notification.
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94fb7310f6b7f6156e57cac956d4e5b207a09a13 commit 94fb7310f6b7f6156e57cac956d4e5b207a09a13 Author: yoshiki iguchi <yoshiki@chromium.org> Date: Tue Aug 29 03:50:27 2017 Adjust the header style of new style notification This CL changes the margins/paddings in new-styled notification header. Bug: 758814 Change-Id: Id7476c6ce15087837a4197f6cd987a1aade72506 Reviewed-on: https://chromium-review.googlesource.com/635043 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#498012} [modify] https://crrev.com/94fb7310f6b7f6156e57cac956d4e5b207a09a13/ui/message_center/views/notification_header_view.cc [modify] https://crrev.com/94fb7310f6b7f6156e57cac956d4e5b207a09a13/ui/message_center/views/notification_view_md.cc
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09e3ff07c620efed74e68b9fdf34eb9b51b5747b commit 09e3ff07c620efed74e68b9fdf34eb9b51b5747b Author: yoshiki iguchi <yoshiki@chromium.org> Date: Tue Aug 29 03:51:48 2017 Fix the left padding of "Left Contents" in New-Styled Notification Previously we set both the innser insets and border for "Left Contents" container wrongly and it applied the padding doubly. This patch removes the inner insets and fixes the layout. Bug: 758814 Change-Id: I8d8f64e25635e84842bd75b4a81adb14c0389cbf Reviewed-on: https://chromium-review.googlesource.com/637289 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#498014} [modify] https://crrev.com/09e3ff07c620efed74e68b9fdf34eb9b51b5747b/ui/message_center/views/notification_view_md.cc
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/759999299f001d69d7eb4152c961e0dac9a234c1 commit 759999299f001d69d7eb4152c961e0dac9a234c1 Author: yoshiki iguchi <yoshiki@chromium.org> Date: Thu Aug 31 08:54:20 2017 Fix layout misc cleanup in ArcNotificationView - Add a width DCHECK to prevent future width inconsistency with Android - Fix the bug of calculating the height of the contents view - Prevent double Lauout calling These changes don't affect actual behavior. They are just cleanups. Bug: 758814 Change-Id: I68b8156fff83369187de45573f7aa948d6afe86c Reviewed-on: https://chromium-review.googlesource.com/645046 Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#498791} [modify] https://crrev.com/759999299f001d69d7eb4152c961e0dac9a234c1/ui/arc/notification/arc_notification_content_view.cc [modify] https://crrev.com/759999299f001d69d7eb4152c961e0dac9a234c1/ui/arc/notification/arc_notification_view.cc
,
Sep 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15925f47c1f2731fd7b62cf1a867bf7088754ebb commit 15925f47c1f2731fd7b62cf1a867bf7088754ebb Author: yoshiki iguchi <yoshiki@chromium.org> Date: Thu Sep 07 00:35:41 2017 Change the paddings of new-style notification * Bottom padding of the contents: According to the mock, it should be 16px, not 12px. * Top padding of the contents; According to the mock, the 2px top-padding should be applied only to the left content. Bug: 758814 Test: manual Change-Id: Ie26acb2e1056b7c3878b89df53af07ff5513fb42 Reviewed-on: https://chromium-review.googlesource.com/650073 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#500157} [modify] https://crrev.com/15925f47c1f2731fd7b62cf1a867bf7088754ebb/ui/message_center/views/message_popup_collection_unittest.cc [modify] https://crrev.com/15925f47c1f2731fd7b62cf1a867bf7088754ebb/ui/message_center/views/notification_view_md.cc
,
Nov 10 2017
,
Nov 10 2017
We still have several UI works, but they are filed separatedly. |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Aug 25 2017