Investigate pre-cq-launcher not picking up CLs for a long time..... |
|||||||
Issue descriptionRevision 1 of this CL was marked ready for the PreCQ from 4:19 PM until 5:44 PM without a PreCQ run running. https://chromium-review.googlesource.com/c/chromiumos/chromite/+/634133 These are the two PreCQ Launcher builds that ran during that window. https://luci-milo.appspot.com/buildbot/chromeos/pre-cq-launcher/9816 https://luci-milo.appspot.com/buildbot/chromeos/pre-cq-launcher/9817
,
Aug 25 2017
So... why weren't builds launched for this CL? If this is representative, this help explain poor PreCQ throughput.
,
Aug 25 2017
FYI: For Chase-Pending, you'd have to convince us (just me? 'cause I've been living under a rock?) that there is a problem with "poor PreCQ throughput". Otherwise, the impact is not critical enough to justify Chase.
,
Aug 25 2017
I've not been the one investigating, but I've been told that we are improving CQ performance, but making up for it by slowing PreCQ performance. I suspect this is related.
,
Aug 25 2017
,
Sep 11 2017
Chase for just finding out (as the summary says) if the time spent waiting is too long for the pre-cq-launcher.
,
Sep 15 2017
I looked into the clActionTable, the Pre-CQs were triggered mysql> select * from clActionTable where change_number = 634133 and patch_number = 1; | 15804481 | 1785372 | 634133 | 1 | external | trybot_launching | daisy_spring-no-vmtest-pre-cq | 2017-08-24 23:24:05 | 8970336971696144304 | | 15804482 | 1785372 | 634133 | 1 | external | trybot_launching | betty-pre-cq | 2017-08-24 23:24:05 | 8970336971295461856 | | 15804483 | 1785372 | 634133 | 1 | external | trybot_launching | binhost-pre-cq | 2017-08-24 23:24:05 | 8970336971020086224 | | 15804484 | 1785372 | 634133 | 1 | external | trybot_launching | nyan_blaze-no-vmtest-pre-cq | 2017-08-24 23:24:05 | 8970336970784100656 | | 15804485 | 1785372 | 634133 | 1 | external | trybot_launching | reef-uni-no-vmtest-pre-cq | 2017-08-24 23:24:05 | 8970336970554847728 | | 15804486 | 1785372 | 634133 | 1 | external | trybot_launching | lumpy-no-vmtest-pre-cq | 2017-08-24 23:24:05 | 8970336970379328928 | | 15804487 | 1785372 | 634133 | 1 | external | trybot_launching | whirlwind-no-vmtest-pre-cq | 2017-08-24 23:24:05 | 8970336970112734176 | | 15804488 | 1785372 | 634133 | 1 | external | trybot_launching | kevin-no-vmtest-pre-cq | 2017-08-24 23:24:05 | 8970336969820828560 | | 15804489 | 1785372 | 634133 | 1 | external | trybot_launching | cyan-no-vmtest-pre-cq | 2017-08-24 23:24:05 | 8970336969496282944 | | 15804490 | 1785372 | 634133 | 1 | external | trybot_launching | samus-no-vmtest-pre-cq | 2017-08-24 23:24:05 | 8970336969288561968 | | 15804491 | 1785372 | 634133 | 1 | external | trybot_launching | reef-no-vmtest-pre-cq | 2017-08-24 23:24:06 | 8970336968922342176 | The reason Pre-CQ-launcher didn't mark it as pre-cq-verify is dgarrett@'s CL changed the behaviors of the Pre-CQ sync stage. Normal Pre-CQ (like https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/no_vmtest_pre_cq/builds/122272) has the PreCQSync stage to mark its CL as picked up in CIDB, but the Pre-CQs in this example only have Sync stage. Pass this bug back to dgarrett@ to check why the stage behavior was changed.
,
Sep 15 2017
Add the link of the triggered Pre-CQ example: https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/no_vmtest_pre_cq/builds/105412
,
Sep 18 2017
,
Oct 14 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by dgarr...@chromium.org
, Aug 25 2017