Components should not depend on Chrome |
|||
Issue descriptionCurrently there is the dependency: //components/crash/content/app:run_as_crashpad_handler -> //chrome/install_static:install_static_util Which violates the chrome/components layering. I am trying to write a GN rule to enforce that //components can't depend on //chrome, but this prevents me from doing so on Windows. The reason for the layering assertion is that there was recently a regression where all of Chrome was brought into components_unittests. If you need to share some crashpad code, it should be moved somewhere outside of //chrome where it can be shared.
,
Aug 25 2017
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/108151497c06108c01e9d079372cf3bb62fb7f2b commit 108151497c06108c01e9d079372cf3bb62fb7f2b Author: Sigurdur Asgeirsson <siggi@chromium.org> Date: Fri Aug 25 17:31:30 2017 Remove errant and needless dependency from //components to //chrome. Bug: 758759 Change-Id: I38ab89ade6afbe5ecc46af6e6eaf6eac18054704 Reviewed-on: https://chromium-review.googlesource.com/635664 Reviewed-by: Brett Wilson <brettw@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#497453} [modify] https://crrev.com/108151497c06108c01e9d079372cf3bb62fb7f2b/components/crash/content/app/BUILD.gn
,
Aug 25 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by brettw@chromium.org
, Aug 24 2017