DCHECK occasionally hit when shutting down JavaHandlerThread. |
||
Issue descriptionIt appears that message_loop happily keeps queueing up tasks on a pump after telling the pump to quit, and message_pump_android doesn't handle that currently, and runs into DCHECK(!system_message_handler_obj_.is_null()); This issue always existed, but was exposed when https://chromium-review.googlesource.com/c/chromium/src/+/602470 fixed JavaHandlerThread to shutdown cleanly.
,
Aug 28 2017
This is causing crashes on Canary, see crash/edbe71ba9b51aa68.
,
Aug 28 2017
How did you connect that crash to this report? The stack looks like garbage
,
Aug 28 2017
The stack is garbage, but I triggered this crash by entering and exiting VR many times until it happened. You can see if you look at the logs that it's due to "JNI DETECTED ERROR IN APPLICATION: obj == null", which is exactly what would happen if you bypassed the DCHECK in Start(). It's possible that's really a different crash, but I'm pretty sure it's not.
,
Aug 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dbeca24ce89efd518399831952a6255871d0d05c commit dbeca24ce89efd518399831952a6255871d0d05c Author: Michael Thiessen <mthiesse@chromium.org> Date: Mon Aug 28 21:10:08 2017 Allow MessageLoop to attempt to queue tasks on message_pump_android after calling Quit(). Like other platform implementations, tasks queued up after quitting will simply not be run. Bug: 758738 Change-Id: I3c7badbb5c1fe4e91856dfdaa49b16e016f9f8b1 Reviewed-on: https://chromium-review.googlesource.com/634158 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#497874} [modify] https://crrev.com/dbeca24ce89efd518399831952a6255871d0d05c/base/message_loop/message_pump_android.cc [modify] https://crrev.com/dbeca24ce89efd518399831952a6255871d0d05c/base/message_loop/message_pump_android.h
,
Aug 28 2017
,
Sep 5 2017
|
||
►
Sign in to add a comment |
||
Comment 1 Deleted