Search result page keyboard focus is broken |
|||||
Issue descriptionRepro steps: (1) open launcher (2) type something to show apps search result (3) arrow down (4) keep pressing arrow right, will see focus is a loop between the first app and back button. Please help determine the priority for this bug.
,
Aug 25 2017
Issue 756860 has been merged into this issue.
,
Aug 28 2017
assign to weidongg, since he has done a bunch of keyboard focus work. Beside the reporter's issue, we shall also eliminate the highlight/focus on search results when typing (which is an old behavior but not seen on new specs).
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/836f045fe55a12bfe5eacf8bd1c6e41a3b9decd2 commit 836f045fe55a12bfe5eacf8bd1c6e41a3b9decd2 Author: Weidong Guo <weidongg@chromium.org> Date: Wed Aug 30 17:34:24 2017 Fix keyboard focus of SearchResultPageView Changes: 1. Initial focus is on the first search result when opened search box is shown, tab key moves the focus to the second search result. 2. When search box text field is selected and query is not empty, select the entire text. 3. When search box text field is selected, left and right key could only move the cursor, only tab key could navigate the focus off. 4. In AppsGridView, up and left key could move focus back to search box. 5. In SearchResultPageView, up and left key could move focus back to search box. 6. Make left and right key's behavior the same as tab and shift+tab in SearchResultPageView. 7. Add test coverage for arrow/tab key focus movement. BUG= 758737 TEST=SearchResultPageViewFullscreenTest.* Change-Id: I9bd791a92bf736ef4de9ae80b311d1e6ad2dc3db Reviewed-on: https://chromium-review.googlesource.com/639852 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#498525} [modify] https://crrev.com/836f045fe55a12bfe5eacf8bd1c6e41a3b9decd2/ui/app_list/views/apps_grid_view.cc [modify] https://crrev.com/836f045fe55a12bfe5eacf8bd1c6e41a3b9decd2/ui/app_list/views/apps_grid_view_unittest.cc [modify] https://crrev.com/836f045fe55a12bfe5eacf8bd1c6e41a3b9decd2/ui/app_list/views/search_box_view.cc [modify] https://crrev.com/836f045fe55a12bfe5eacf8bd1c6e41a3b9decd2/ui/app_list/views/search_box_view_unittest.cc [modify] https://crrev.com/836f045fe55a12bfe5eacf8bd1c6e41a3b9decd2/ui/app_list/views/search_result_list_view.cc [modify] https://crrev.com/836f045fe55a12bfe5eacf8bd1c6e41a3b9decd2/ui/app_list/views/search_result_list_view.h [modify] https://crrev.com/836f045fe55a12bfe5eacf8bd1c6e41a3b9decd2/ui/app_list/views/search_result_page_view.cc [modify] https://crrev.com/836f045fe55a12bfe5eacf8bd1c6e41a3b9decd2/ui/app_list/views/search_result_page_view_unittest.cc [modify] https://crrev.com/836f045fe55a12bfe5eacf8bd1c6e41a3b9decd2/ui/app_list/views/search_result_tile_item_list_view.cc
,
Aug 30 2017
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ff79a79eb35d17dc762cb0f318613dd12a1ed9a commit 1ff79a79eb35d17dc762cb0f318613dd12a1ed9a Author: Vadim Tryshev <vadimt@google.com> Date: Thu Aug 31 23:26:09 2017 Fix keyboard focus of SearchResultPageView Changes: 1. Initial focus is on the first search result when opened search box is shown, tab key moves the focus to the second search result. 2. When search box text field is selected and query is not empty, select the entire text. 3. When search box text field is selected, left and right key could only move the cursor, only tab key could navigate the focus off. 4. In AppsGridView, up and left key could move focus back to search box. 5. In SearchResultPageView, up and left key could move focus back to search box. 6. Make left and right key's behavior the same as tab and shift+tab in SearchResultPageView. 7. Add test coverage for arrow/tab key focus movement. BUG= 758737 TEST=SearchResultPageViewFullscreenTest.* TBR=weidongg@chromium.org (cherry picked from commit 836f045fe55a12bfe5eacf8bd1c6e41a3b9decd2) Change-Id: I9bd791a92bf736ef4de9ae80b311d1e6ad2dc3db Reviewed-on: https://chromium-review.googlesource.com/639852 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#498525} Reviewed-on: https://chromium-review.googlesource.com/646799 Reviewed-by: Vadim Tryshev <vadimt@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#1060} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/1ff79a79eb35d17dc762cb0f318613dd12a1ed9a/ui/app_list/views/apps_grid_view.cc [modify] https://crrev.com/1ff79a79eb35d17dc762cb0f318613dd12a1ed9a/ui/app_list/views/apps_grid_view_unittest.cc [modify] https://crrev.com/1ff79a79eb35d17dc762cb0f318613dd12a1ed9a/ui/app_list/views/search_box_view.cc [modify] https://crrev.com/1ff79a79eb35d17dc762cb0f318613dd12a1ed9a/ui/app_list/views/search_box_view_unittest.cc [modify] https://crrev.com/1ff79a79eb35d17dc762cb0f318613dd12a1ed9a/ui/app_list/views/search_result_list_view.cc [modify] https://crrev.com/1ff79a79eb35d17dc762cb0f318613dd12a1ed9a/ui/app_list/views/search_result_list_view.h [modify] https://crrev.com/1ff79a79eb35d17dc762cb0f318613dd12a1ed9a/ui/app_list/views/search_result_page_view.cc [modify] https://crrev.com/1ff79a79eb35d17dc762cb0f318613dd12a1ed9a/ui/app_list/views/search_result_page_view_unittest.cc [modify] https://crrev.com/1ff79a79eb35d17dc762cb0f318613dd12a1ed9a/ui/app_list/views/search_result_tile_item_list_view.cc
,
Jan 22 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by shibasheikh@chromium.org
, Aug 24 2017