New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758737 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Search result page keyboard focus is broken

Project Member Reported by warx@chromium.org, Aug 24 2017

Issue description

Repro steps:
(1) open launcher
(2) type something to show apps search result
(3) arrow down
(4) keep pressing arrow right, will see focus is a loop between the first app and back button.

Please help determine the priority for this bug.
 
search_result_page_keyboard_focus.webm
2.1 MB View Download
P0 please
Issue 756860 has been merged into this issue.

Comment 3 by warx@chromium.org, Aug 28 2017

Cc: -weidongg@chromium.org warx@chromium.org
Owner: weidongg@chromium.org
assign to weidongg, since he has done a bunch of keyboard focus work. Beside the reporter's issue, we shall also eliminate the highlight/focus on search results when typing (which is an old behavior but not seen on new specs).
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/836f045fe55a12bfe5eacf8bd1c6e41a3b9decd2

commit 836f045fe55a12bfe5eacf8bd1c6e41a3b9decd2
Author: Weidong Guo <weidongg@chromium.org>
Date: Wed Aug 30 17:34:24 2017

Fix keyboard focus of SearchResultPageView

Changes:
1. Initial focus is on the first search result when opened search box is
shown, tab key moves the focus to the second search result.
2. When search box text field is selected and query is not empty, select
the entire text.
3. When search box text field is selected, left and right key could
only move the cursor, only tab key could navigate the focus off.
4. In AppsGridView, up and left key could move focus back to search box.
5. In SearchResultPageView, up and left key could move focus back to
search box.
6. Make left and right key's behavior the same as tab and shift+tab in
SearchResultPageView.
7. Add test coverage for arrow/tab key focus movement.

BUG= 758737 
TEST=SearchResultPageViewFullscreenTest.*

Change-Id: I9bd791a92bf736ef4de9ae80b311d1e6ad2dc3db
Reviewed-on: https://chromium-review.googlesource.com/639852
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498525}
[modify] https://crrev.com/836f045fe55a12bfe5eacf8bd1c6e41a3b9decd2/ui/app_list/views/apps_grid_view.cc
[modify] https://crrev.com/836f045fe55a12bfe5eacf8bd1c6e41a3b9decd2/ui/app_list/views/apps_grid_view_unittest.cc
[modify] https://crrev.com/836f045fe55a12bfe5eacf8bd1c6e41a3b9decd2/ui/app_list/views/search_box_view.cc
[modify] https://crrev.com/836f045fe55a12bfe5eacf8bd1c6e41a3b9decd2/ui/app_list/views/search_box_view_unittest.cc
[modify] https://crrev.com/836f045fe55a12bfe5eacf8bd1c6e41a3b9decd2/ui/app_list/views/search_result_list_view.cc
[modify] https://crrev.com/836f045fe55a12bfe5eacf8bd1c6e41a3b9decd2/ui/app_list/views/search_result_list_view.h
[modify] https://crrev.com/836f045fe55a12bfe5eacf8bd1c6e41a3b9decd2/ui/app_list/views/search_result_page_view.cc
[modify] https://crrev.com/836f045fe55a12bfe5eacf8bd1c6e41a3b9decd2/ui/app_list/views/search_result_page_view_unittest.cc
[modify] https://crrev.com/836f045fe55a12bfe5eacf8bd1c6e41a3b9decd2/ui/app_list/views/search_result_tile_item_list_view.cc

Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 31 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ff79a79eb35d17dc762cb0f318613dd12a1ed9a

commit 1ff79a79eb35d17dc762cb0f318613dd12a1ed9a
Author: Vadim Tryshev <vadimt@google.com>
Date: Thu Aug 31 23:26:09 2017

Fix keyboard focus of SearchResultPageView

Changes:
1. Initial focus is on the first search result when opened search box is
shown, tab key moves the focus to the second search result.
2. When search box text field is selected and query is not empty, select
the entire text.
3. When search box text field is selected, left and right key could
only move the cursor, only tab key could navigate the focus off.
4. In AppsGridView, up and left key could move focus back to search box.
5. In SearchResultPageView, up and left key could move focus back to
search box.
6. Make left and right key's behavior the same as tab and shift+tab in
SearchResultPageView.
7. Add test coverage for arrow/tab key focus movement.

BUG= 758737 
TEST=SearchResultPageViewFullscreenTest.*
TBR=weidongg@chromium.org

(cherry picked from commit 836f045fe55a12bfe5eacf8bd1c6e41a3b9decd2)

Change-Id: I9bd791a92bf736ef4de9ae80b311d1e6ad2dc3db
Reviewed-on: https://chromium-review.googlesource.com/639852
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#498525}
Reviewed-on: https://chromium-review.googlesource.com/646799
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1060}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/1ff79a79eb35d17dc762cb0f318613dd12a1ed9a/ui/app_list/views/apps_grid_view.cc
[modify] https://crrev.com/1ff79a79eb35d17dc762cb0f318613dd12a1ed9a/ui/app_list/views/apps_grid_view_unittest.cc
[modify] https://crrev.com/1ff79a79eb35d17dc762cb0f318613dd12a1ed9a/ui/app_list/views/search_box_view.cc
[modify] https://crrev.com/1ff79a79eb35d17dc762cb0f318613dd12a1ed9a/ui/app_list/views/search_box_view_unittest.cc
[modify] https://crrev.com/1ff79a79eb35d17dc762cb0f318613dd12a1ed9a/ui/app_list/views/search_result_list_view.cc
[modify] https://crrev.com/1ff79a79eb35d17dc762cb0f318613dd12a1ed9a/ui/app_list/views/search_result_list_view.h
[modify] https://crrev.com/1ff79a79eb35d17dc762cb0f318613dd12a1ed9a/ui/app_list/views/search_result_page_view.cc
[modify] https://crrev.com/1ff79a79eb35d17dc762cb0f318613dd12a1ed9a/ui/app_list/views/search_result_page_view_unittest.cc
[modify] https://crrev.com/1ff79a79eb35d17dc762cb0f318613dd12a1ed9a/ui/app_list/views/search_result_tile_item_list_view.cc

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment