New issue
Advanced search Search tips

Issue 758729 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

Webkit Layout Tests failing on multiple platforms

Project Member Reported by zea@chromium.org, Aug 24 2017

Issue description

Comment 1 by zea@chromium.org, Aug 24 2017

Summary: Webkit Layout Tests failing on multiple platforms (was: Webkit Layout Tests)

Comment 2 by zea@chromium.org, Aug 24 2017

Owner: khushals...@chromium.org
Status: Assigned (was: Available)
Speculative revert in progress https://chromium-review.googlesource.com/c/chromium/src/+/633834

Comment 3 by zea@chromium.org, Aug 25 2017

Cc: dgozman@chromium.org khushals...@chromium.org
Owner: ----
Status: Available (was: Assigned)
Looks like things are still flaking. Found this dcheck in the logs (not sure if it's the cause of the failures or not):
05:05:15.754 9073   [11002:1295:0825/050515.652011:990634134411:FATAL:render_frame_devtools_agent_host.cc(829)] Check failed: !pending_. 
05:05:15.754 9073   0   libbase.dylib                       0x000000011a8d43be base::debug::StackTrace::StackTrace(unsigned long) + 174
05:05:15.754 9073   1   libbase.dylib                       0x000000011a8d447d base::debug::StackTrace::StackTrace(unsigned long) + 29
05:05:15.754 9073   2   libbase.dylib                       0x000000011a8d272c base::debug::StackTrace::StackTrace() + 28
05:05:15.754 9073   3   libbase.dylib                       0x000000011a9718df logging::LogMessage::~LogMessage() + 479
05:05:15.754 9073   4   libbase.dylib                       0x000000011a96f245 logging::LogMessage::~LogMessage() + 21
05:05:15.754 9073   5   libcontent.dylib                    0x000000010f09a2c2 content::RenderFrameDevToolsAgentHost::AboutToNavigateRenderFrame(content::RenderFrameHost*, content::RenderFrameHost*) + 1074
05:05:15.754 9073   6   libcontent.dylib                    0x000000010f099e84 content::RenderFrameDevToolsAgentHost::OnBeforeNavigation(content::RenderFrameHost*, content::RenderFrameHost*) + 68
05:05:15.754 9073   7   libcontent.dylib                    0x000000010f3d018b content::RenderFrameHostImpl::SendNavigateMessage(content::CommonNavigationParams const&, content::StartNavigationParams const&, content::RequestNavigationParams const&) + 59
05:05:15.754 9073   8   libcontent.dylib                    0x000000010f3d83c8 content::RenderFrameHostImpl::SetNavigationsSuspended(bool, base::TimeTicks const&) + 1400
05:05:15.754 9073   9   libcontent.dylib                    0x000000010f42fd53 content::RenderFrameHostManager::OnBeforeUnloadACK(bool, bool, base::TimeTicks const&) + 499
05:05:15.754 9073   10  libcontent.dylib                    0x000000010f3ad275 content::RenderFrameHostImpl::OnBeforeUnloadACK(bool, base::TimeTicks const&, base::TimeTicks const&) + 2469
05:05:15.754 9073   11  libcontent.dylib                    0x000000010f3f0c78 void base::DispatchToMethodImpl<content::RenderFrameHostImpl*, void (content::RenderFrameHostImpl::*)(bool, base::TimeTicks const&, base::TimeTicks const&), std::__1::tuple<bool, base::TimeTicks, base::TimeTicks> const&, 0ul, 1ul, 2ul>(content::RenderFrameHostImpl* const&, void (content::RenderFrameHostImpl::*)(bool, base::TimeTicks const&, base::TimeTicks const&), std::__1::tuple<bool, base::TimeTicks, base::TimeTicks> const&&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul>) + 280
05:05:15.754 9073   12  libcontent.dylib                    0x000000010f3f0b50 void base::DispatchToMethod<content::RenderFrameHostImpl*, void (content::RenderFrameHostImpl::*)(bool, base::TimeTicks const&, base::TimeTicks const&), std::__1::tuple<bool, base::TimeTicks, base::TimeTicks> const&>(content::RenderFrameHostImpl* const&, void (content::RenderFrameHostImpl::*)(bool, base::TimeTicks const&, base::TimeTicks const&), std::__1::tuple<bool, base::TimeTicks, base::TimeTicks> const&&&) + 96
05:05:15.754 9073   13  libcontent.dylib                    0x000000010f3f0acd void IPC::DispatchToMethod<content::RenderFrameHostImpl, void (content::RenderFrameHostImpl::*)(bool, base::TimeTicks const&, base::TimeTicks const&), void, std::__1::tuple<bool, base::TimeTicks, base::TimeTicks> >(content::RenderFrameHostImpl*, void (content::RenderFrameHostImpl::*)(bool, base::TimeTicks const&, base::TimeTicks const&), void*, std::__1::tuple<bool, base::TimeTicks, base::TimeTicks> const&) + 109
05:05:15.754 9073   14  libcontent.dylib                    0x000000010f3ac858 bool IPC::MessageT<FrameHostMsg_BeforeUnload_ACK_Meta, std::__1::tuple<bool, base::TimeTicks, base::TimeTicks>, void>::Dispatch<content::RenderFrameHostImpl, content::RenderFrameHostImpl, void, void (content::RenderFrameHostImpl::*)(bool, base::TimeTicks const&, base::TimeTicks const&)>(IPC::Message const*, content::RenderFrameHostImpl*, content::RenderFrameHostImpl*, void*, void (content::RenderFrameHostImpl::*)(bool, base::TimeTicks const&, base::TimeTicks const&)) + 552
05:05:15.754 9073   15  libcontent.dylib                    0x000000010f3a462f content::RenderFrameHostImpl::OnMessageReceived(IPC::Message const&) + 5119
05:05:15.754 9073   16  libcontent.dylib                    0x000000010fc2c7aa content::RenderProcessHostImpl::OnMessageReceived(IPC::Message const&) + 2058
05:05:15.754 9073   17  libipc.dylib                        0x000000011f6a2038 IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const&) + 152
05:05:15.754 9073   18  libipc.dylib                        0x000000011f6a93ef void base::internal::FunctorTraits<void (IPC::ChannelProxy::Context::*)(IPC::Message const&), void>::Invoke<scoped_refptr<IPC::ChannelProxy::Context> const&, IPC::Message const&>(void (IPC::ChannelProxy::Context::*)(IPC::Message const&), scoped_refptr<IPC::ChannelProxy::Context> const&&&, IPC::Message const&&&) + 143
05:05:15.754 9073   19  libipc.dylib                        0x000000011f6a92ef void base::internal::InvokeHelper<false, void>::MakeItSo<void (IPC::ChannelProxy::Context::* const&)(IPC::Message const&), scoped_refptr<IPC::ChannelProxy::Context> const&, IPC::Message const&>(void (IPC::ChannelProxy::Context::* const&&&)(IPC::Message const&), scoped_refptr<IPC::ChannelProxy::Context> const&&&, IPC::Message const&&&) + 95
05:05:15.754 9073   20  libipc.dylib                        0x000000011f6a927d void base::internal::Invoker<base::internal::BindState<void (IPC::ChannelProxy::Context::*)(IPC::Message const&), scoped_refptr<IPC::ChannelProxy::Context>, IPC::Message>, void ()>::RunImpl<void (IPC::ChannelProxy::Context::* const&)(IPC::Message const&), std::__1::tuple<scoped_refptr<IPC::ChannelProxy::Context>, IPC::Message> const&, 0ul, 1ul>(void (IPC::ChannelProxy::Context::* const&&&)(IPC::Message const&), std::__1::tuple<scoped_refptr<IPC::ChannelProxy::Context>, IPC::Message> const&&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul>) + 125
05:05:15.754 9073   21  libipc.dylib                        0x000000011f6a918c base::internal::Invoker<base::internal::BindState<void (IPC::ChannelProxy::Context::*)(IPC::Message const&), scoped_refptr<IPC::ChannelProxy::Context>, IPC::Message>, void ()>::Run(base::internal::BindStateBase*) + 44
05:05:15.754 9073   22  libbase.dylib                       0x000000011a871c7f base::Callback<void (), (base::internal::CopyMode)0, (base::internal::RepeatMode)0>::Run() + 95
05:05:15.754 9073   23  libbase.dylib                       0x000000011a8d6ab0 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 1040
05:05:15.755 9073   24  libbase.dylib                       0x000000011a9c7394 base::MessageLoop::RunTask(base::PendingTask*) + 900
05:05:15.755 9073   25  libbase.dylib                       0x000000011a9c78e7 base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) + 71
05:05:15.755 9073   26  libbase.dylib                       0x000000011a9c8738 base::MessageLoop::DoWork() + 568
05:05:15.755 9073   27  libbase.dylib                       0x000000011a9d8a6f base::MessagePumpCFRunLoopBase::RunWork() + 95
05:05:15.755 9073   28  libbase.dylib                       0x000000011a9d89fc ___ZN4base24MessagePumpCFRunLoopBase13RunWorkSourceEPv_block_invoke + 28
05:05:15.755 9073   29  libbase.dylib                       0x000000011a97a00a base::mac::CallWithEHFrame(void () block_pointer) + 10
05:05:15.755 9073   30  libbase.dylib                       0x000000011a9d7f05 base::MessagePumpCFRunLoopBase::RunWorkSource(void*) + 101
05:05:15.755 9073   31  CoreFoundation                      0x00007fff8ef095c1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
05:05:15.755 9073   32  CoreFoundation                      0x00007fff8eefb41c __CFRunLoopDoSources0 + 556
05:05:15.755 9073   33  CoreFoundation                      0x00007fff8eefa93f __CFRunLoopRun + 927
05:05:15.755 9073   34  CoreFoundation                      0x00007fff8eefa338 CFRunLoopRunSpecific + 296
05:05:15.755 9073   35  HIToolbox                           0x00007fff90bdb935 RunCurrentEventLoopInMode + 235
05:05:15.755 9073   36  HIToolbox                           0x00007fff90bdb76f ReceiveNextEventCommon + 432
05:05:15.755 9073   37  HIToolbox                           0x00007fff90bdb5af _BlockUntilNextEventMatchingListInModeWithFilter + 71
05:05:15.755 9073   38  AppKit                              0x00007fff9580b0ee _DPSNextEvent + 1067
05:05:15.755 9073   39  AppKit                              0x00007fff95bd7943 -[NSApplication _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 454
05:05:15.755 9073   40  AppKit                              0x00007fff95800fc8 -[NSApplication run] + 682
05:05:15.755 9073   41  libbase.dylib                       0x000000011a9d973c base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 300
05:05:15.755 9073   42  libbase.dylib                       0x000000011a9d76ee base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 110
05:05:15.755 9073   43  libbase.dylib                       0x000000011a9c6b1b base::MessageLoop::Run() + 299
05:05:15.755 9073   44  libbase.dylib                       0x000000011aac131e base::RunLoop::Run() + 286
05:05:15.755 9073   45  libcontent.dylib                    0x000000010ed42426 content::BrowserMainLoop::MainMessageLoopRun() + 422
05:05:15.755 9073   46  libcontent.dylib                    0x000000010ed42138 content::BrowserMainLoop::RunMainMessageLoopParts() + 488
05:05:15.755 9073   47  libcontent.dylib                    0x000000010ed4c5ec content::BrowserMainRunnerImpl::Run() + 396
05:05:15.755 9073   48  Content Shell Framework             0x000000010b49f638 (anonymous namespace)::RunOneTest(content::TestInfo const&, bool*, std::__1::unique_ptr<content::BrowserMainRunner, std::__1::default_delete<content::BrowserMainRunner> > const&) + 152
05:05:15.755 9073   49  Content Shell Framework             0x000000010b49f306 (anonymous namespace)::RunTests(std::__1::unique_ptr<content::BrowserMainRunner, std::__1::default_delete<content::BrowserMainRunner> > const&) + 1238
05:05:15.755 9073   50  Content Shell Framework             0x000000010b49ed68 LayoutTestBrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserMainRunner, std::__1::default_delete<content::BrowserMainRunner> > const&) + 1704
05:05:15.755 9073   51  Content Shell Framework             0x000000010b3edb75 content::ShellMainDelegate::RunProcess(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&) + 757
05:05:15.755 9073   52  libcontent.dylib                    0x00000001114537de content::RunNamedProcessTypeMain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&, content::ContentMainDelegate*) + 510
05:05:15.755 9073   53  libcontent.dylib                    0x0000000111455090 content::ContentMainRunnerImpl::Run() + 1280
05:05:15.755 9073   54  libcontent.dylib                    0x0000000111451b0d content::ContentServiceManagerMainDelegate::RunEmbedderProcess() + 61
05:05:15.755 9073   55  libembedder.dylib                   0x00000001240984c7 service_manager::Main(service_manager::MainParams const&) + 1911
05:05:15.755 9073   56  libcontent.dylib                    0x0000000111453599 content::ContentMain(content::ContentMainParams const&) + 89
05:05:15.756 9073   57  Content Shell Framework             0x000000010a8f4293 ContentMain + 83
05:05:15.756 9073   58  Content Shell                       0x000000010a8ebf82 main + 34
05:05:15.756 9073   59  libdyld.dylib                       0x00007fff8dab55ad start + 1
05:05:15.756 9073   60  ???                                 0x0000000000000005 0x0 + 5
05:05:15.756 9073   
05:05:15.760 9041 [5079/59764] virtual/mojo-loading/http/tests/devtools/console/console-timestamp.html failed unexpectedly (Content Shell crashed [pid=11002]):

+cc dgozman who added this logic a while ago in case he has any insight.
This looks like a different bug from the initial failure that the revert addressed. That was affecting 2 tests:

virtual/gpu/fast/canvas/canvas-toBlob-toDataURL-race-imageEncoder-jpeg.html on WebKit Linux Trusty ASAN, and
virtual/gpu-rasterization/images/color-profile-svg.html on win/mac bots.

The new failure is http/tests/webfont/slow-loading.html on the win bot.

Comment 6 by hbos@chromium.org, Aug 30 2017

Labels: -Sheriff-Chromium
Status: WontFix (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b41caaafb9b0785845a8fafc141bf54da6fe1875

commit b41caaafb9b0785845a8fafc141bf54da6fe1875
Author: Khushal <khushalsagar@chromium.org>
Date: Thu Aug 31 02:40:16 2017

Reland: cc/blink: Don't lock the frame index in PaintImageGenerator.

Reland [1] with bug fixes from the original patch and tests for them in
BitmapImageTest and DeferredImageDecoderTest.

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/624563

TBR=dalecurtis@chromium.org
R=pdr@chromium.org, vmpstr@chromium.org

Bug:  735741 ,  758729 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: If53fdf0f38c9c0cfea2dfb79cdcb07ad90df87d0
Reviewed-on: https://chromium-review.googlesource.com/639921
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498736}
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/cc/paint/draw_image.h
[add] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/cc/paint/frame_metadata.h
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/cc/paint/paint_image.cc
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/cc/paint/paint_image.h
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/cc/paint/paint_image_builder.cc
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/cc/paint/paint_image_builder.h
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/cc/paint/paint_image_generator.cc
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/cc/paint/paint_image_generator.h
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/cc/paint/skia_paint_image_generator.cc
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/cc/paint/skia_paint_image_generator.h
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/cc/test/skia_common.cc
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/cc/test/stub_decode_cache.h
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/cc/test/stub_paint_image_generator.cc
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/cc/test/stub_paint_image_generator.h
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/cc/tiles/checker_image_tracker_unittest.cc
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/cc/tiles/gpu_image_decode_cache.cc
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/cc/tiles/gpu_image_decode_cache.h
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/cc/tiles/gpu_image_decode_cache_unittest.cc
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/cc/tiles/image_controller_unittest.cc
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/cc/tiles/image_decode_cache.h
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/cc/tiles/software_image_decode_cache.cc
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/cc/tiles/software_image_decode_cache.h
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/cc/tiles/software_image_decode_cache_unittest.cc
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/media/renderers/skcanvas_video_renderer.cc
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/third_party/WebKit/Source/platform/graphics/BitmapImage.cpp
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.h
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.h
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTestWoPlatform.cpp
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/third_party/WebKit/Source/platform/graphics/Image.cpp
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/third_party/WebKit/Source/platform/graphics/ImageDecodingStoreTest.cpp
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/third_party/WebKit/Source/platform/graphics/PlaceholderImage.cpp
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/third_party/WebKit/Source/platform/graphics/PlaceholderImage.h
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/third_party/WebKit/Source/platform/graphics/paint/PaintImage.h
[modify] https://crrev.com/b41caaafb9b0785845a8fafc141bf54da6fe1875/third_party/WebKit/Source/platform/graphics/test/MockImageDecoder.h

Sign in to add a comment