Remove ReadWriteLock |
||
Issue descriptionThere are only two users of ReadWriteLock in just over a year. Both are used to synchronize some sort of shutdown. There are also non-trivial performance implications in using an SRWLock on Windows in shared mode. Discussion: https://groups.google.com/a/chromium.org/d/topic/chromium-dev/cPZKCTpVw4U/discussion
,
Aug 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94fef6e2a56ef5b3ed0dc0fd94e6ad52267067fb commit 94fef6e2a56ef5b3ed0dc0fd94e6ad52267067fb Author: Robert Liao <robliao@chromium.org> Date: Sat Aug 26 01:40:35 2017 Change ReadWriteLock to Lock+ConditionVariable in TaskService There are non-trivial performance implications of using shared SRWLocking on Windows as more state has to be checked. Since there are only two uses of the ReadWriteLock in Chromium after over 1 year, the decision is to remove it. BUG= 758721 Change-Id: I84d1987d7b624a89e896eb37184ee50845c39d80 Reviewed-on: https://chromium-review.googlesource.com/634423 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by: Francois Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#497632} [modify] https://crrev.com/94fef6e2a56ef5b3ed0dc0fd94e6ad52267067fb/media/midi/task_service.cc [modify] https://crrev.com/94fef6e2a56ef5b3ed0dc0fd94e6ad52267067fb/media/midi/task_service.h
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d301af71fa12496dd9ab550454ed36647ac85af2 commit d301af71fa12496dd9ab550454ed36647ac85af2 Author: Robert Liao <robliao@chromium.org> Date: Tue Sep 12 23:07:27 2017 Remove ReadWriteLock from IncomingTaskQueue Equivalent functionality can be achieved by adding a bool without any additional locking in the IncomingTaskQueue::PostPendingTask path. One fewer lock is required if there is no need to schedule work. BUG=749312, 758721 Change-Id: I812db615ef2d1772c077266240d3a1927c97565c Reviewed-on: https://chromium-review.googlesource.com/639158 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Francois Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#501441} [modify] https://crrev.com/d301af71fa12496dd9ab550454ed36647ac85af2/base/message_loop/incoming_task_queue.cc [modify] https://crrev.com/d301af71fa12496dd9ab550454ed36647ac85af2/base/message_loop/incoming_task_queue.h
,
Sep 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bbdc8ff88731c39cf32ebcf36ebe7e0ec4509ddf commit bbdc8ff88731c39cf32ebcf36ebe7e0ec4509ddf Author: Robert Liao <robliao@chromium.org> Date: Fri Sep 22 00:04:12 2017 Remove Read Write Lock There are no more references to ReadWriteLock in the Chromium codebase. BUG= 758721 Change-Id: I2b83afb9c1682fe349f2e389eb75fc0c368497b6 Reviewed-on: https://chromium-review.googlesource.com/676626 Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#503618} [modify] https://crrev.com/bbdc8ff88731c39cf32ebcf36ebe7e0ec4509ddf/base/BUILD.gn [delete] https://crrev.com/92d549f9ab9342c069a1c4c335eeccabd5ed93d1/base/synchronization/read_write_lock.h [delete] https://crrev.com/92d549f9ab9342c069a1c4c335eeccabd5ed93d1/base/synchronization/read_write_lock_nacl.cc [delete] https://crrev.com/92d549f9ab9342c069a1c4c335eeccabd5ed93d1/base/synchronization/read_write_lock_posix.cc [delete] https://crrev.com/92d549f9ab9342c069a1c4c335eeccabd5ed93d1/base/synchronization/read_write_lock_unittest.cc [delete] https://crrev.com/92d549f9ab9342c069a1c4c335eeccabd5ed93d1/base/synchronization/read_write_lock_win.cc
,
Oct 31 2017
|
||
►
Sign in to add a comment |
||
Comment 1 Deleted