New issue
Advanced search Search tips

Issue 758716 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug


Participants' hotlists:
Omnibox-Bugs-on-mpearson-Radar

Show other hotlists

Other hotlists containing this issue:
Hotlist-2
Hotlist-1


Sign in to add a comment

Importing History Omnibox Issues

Project Member Reported by mpear...@chromium.org, Aug 24 2017

Issue description

Chrome Version: 60.0.3112.113 (Official Build) (64-bit)
OS: Linux

What steps will reproduce the problem?
(1) Open firefox and browse to a web site, say finance.yahoo.com, using its URL bar.  Close firefox.
(2) Open chrome with a fresh user data directory.
(3) From the about:settings page, select import data (in particular history) from firefox.

There are several issues.

A.
Try this:
(4) Type "finance" in the omnibox.
What is the expected result?
(5) An inline autocompletion to "finance.yahoo.com" or at least the suggestion is offered somewhere in the dropdown.
What happens instead?
(5) No suggestion offer, nowhere on the dropdown.  Verified with about:omnibox that neither HistoryURL nor HistoryQuick provider offers this as a suggestion.

B.
Try this:
(4) Now restart the browser.
(5) Type "finance" in the omnibox.
What is the expected result?
(6) An inline autocompletion to "finance.yahoo.com" or at least the suggestion is offered somewhere in the dropdown.
What happens instead?
(6) The suggestion is offered, though not as an inline autocompletion. 
about:omnibox shows that HistoryQuick is returning the suggestion, which it says has typed_count=1 and visit_count=1 (both correct).  HistoryURL provider does not offer the suggestion.
  Incidentally, visiting the page once fixes it, making HistoryURL return the URL.

I'm more bothered by issue B. than issue A.
 
Here might be the problem:

sqlite> select * from urls;
...
2|http://finance.yahoo.com/||1|1|13148006387000000|1

The URL is marked as hidden.

It might be hidden in the imported firefox data, because we're explicitly reading and setting that field during the import.
https://cs.chromium.org/chromium/src/chrome/utility/importer/firefox_importer.cc?l=187

Also, yet, if it's hidden, then why is HistoryQuick provider returning it?  I don't think it should be.
https://cs.chromium.org/chromium/src/components/history/core/browser/url_database.cc?l=658
Hey does this look like a good first bug ? Would like to pick this up :)
Yes, this is probably a good first bug.  I imagine whatever bugs are here probably require narrow fixes (not much code), just detective work to figure out where the problem is.  (I wonder if it's a problem though with firefox data indicating the wrong thing, in which case it'd be hard to fix in chromium.  I guess you'll find out. :-) )
cool starting on it. 
can I get this assigned to me. 
thnx for the confidence :D
Owner: mpear...@chromium.org
Status: Assigned (was: Available)
Because you're not (yet) a chromium contributer, you can't have bugs assigned to you.  (The bug tracker doesn't let me do that.)

I'll label it as assigned to me to make sure no one else picks it up.
Cool awesome thnx :D
anuprai11894@, I'm curious if you've made any progress on this bug that you said you wanted to fix.  Let me know if there's any advice or help I can give you.
NextAction: 2018-10-12
anuprai11894@,

If I don't hear from you, I'm going to mark this bug as available to let someone else pick it up.
The NextAction date has arrived: 2018-10-12
Owner: ----
Status: Available (was: Assigned)
NextAction: ----
Hey sorry I lost track of this after doing a little work around this seriously apologies. 
Keep this open will ask you to assign only if I get to some solution 
Sorry again.

Sign in to add a comment