New issue
Advanced search Search tips

Issue 758712 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

AppListView background opacity is not being picked properly.

Project Member Reported by newcomer@chromium.org, Aug 24 2017

Issue description

When showing the app list, the opacity is not correct. After dragging it, the opacity is correct. This is because the background opacity is not being picked correctly with blur enabled. 
 
Project Member

Comment 1 by sheriffbot@chromium.org, Aug 24 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 11 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23ab199380c4d3a4c462f863b1fcb5335d08a3e7

commit 23ab199380c4d3a4c462f863b1fcb5335d08a3e7
Author: Alex Newcomer <newcomer@chromium.org>
Date: Thu Aug 24 22:08:55 2017

cros:AppListView background opacity bug

on dragging, the opacity was not correct  because it was
not taking into account the second configuration (blur enabled).

Bug:  758712 
Change-Id: I0dd4ff19d0fb337240ef9721d57b8658f40f784c
Reviewed-on: https://chromium-review.googlesource.com/633884
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497207}
[modify] https://crrev.com/23ab199380c4d3a4c462f863b1fcb5335d08a3e7/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/23ab199380c4d3a4c462f863b1fcb5335d08a3e7/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/23ab199380c4d3a4c462f863b1fcb5335d08a3e7/ui/app_list/views/app_list_view.cc

Comment 3 by ketakid@google.com, Aug 25 2017

Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Status: Fixed (was: Started)
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 28 2017

Cc: ketakid@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 30 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf1cc745ccd58b8bc3b04cbd92a55c88c64bc585

commit cf1cc745ccd58b8bc3b04cbd92a55c88c64bc585
Author: Maajid <maajid@chromium.org>
Date: Wed Aug 30 18:27:55 2017

cros:AppListView background opacity bug

on dragging, the opacity was not correct  because it was
not taking into account the second configuration (blur enabled).

TBR=newcomer@chromium.org

(cherry picked from commit 23ab199380c4d3a4c462f863b1fcb5335d08a3e7)

Bug:  758712 
Change-Id: I0dd4ff19d0fb337240ef9721d57b8658f40f784c
Reviewed-on: https://chromium-review.googlesource.com/633884
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#497207}
Reviewed-on: https://chromium-review.googlesource.com/644086
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1001}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/cf1cc745ccd58b8bc3b04cbd92a55c88c64bc585/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/cf1cc745ccd58b8bc3b04cbd92a55c88c64bc585/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/cf1cc745ccd58b8bc3b04cbd92a55c88c64bc585/ui/app_list/views/app_list_view.cc

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment