New issue
Advanced search Search tips

Issue 758710 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Close the launcher without delay when it is dragged tto the bezel.

Project Member Reported by newcomer@chromium.org, Aug 24 2017

Issue description

The launcher should be closed without delay when dragged to the bezel, instead of allowing it to close over the standard 300ms. This also fixes the bug where the launcher was being reopened while the close animation was happening.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Aug 24 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 11 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd19fb7da71856332170d07c20f6faa6b0e3968a

commit fd19fb7da71856332170d07c20f6faa6b0e3968a
Author: Alex Newcomer <newcomer@chromium.org>
Date: Thu Aug 24 23:22:29 2017

cros: Immediately hide launcher when it is dragged to the bezel.

Before this CL, when the launcher is dragged to the bezel it
would close with a 300 ms delay, which kept the shelf background hidden
longer than desired.

Bug:  758710 
Change-Id: I595d95daff25f0c832ea8e8dc004d5b635906d6c
Reviewed-on: https://chromium-review.googlesource.com/633846
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497243}
[modify] https://crrev.com/fd19fb7da71856332170d07c20f6faa6b0e3968a/ash/app_list/app_list_presenter_delegate.cc

Comment 3 by ketakid@google.com, Aug 25 2017

Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Status: Fixed (was: Started)
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 28 2017

Cc: ketakid@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 30 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1a710dc158931f3333c02e37605090322e80f74

commit a1a710dc158931f3333c02e37605090322e80f74
Author: Maajid <maajid@chromium.org>
Date: Wed Aug 30 20:45:20 2017

cros: Immediately hide launcher when it is dragged to the bezel.

Before this CL, when the launcher is dragged to the bezel it
would close with a 300 ms delay, which kept the shelf background hidden
longer than desired.

TBR=newcomer@chromium.org

(cherry picked from commit fd19fb7da71856332170d07c20f6faa6b0e3968a)

Bug:  758710 
Change-Id: I595d95daff25f0c832ea8e8dc004d5b635906d6c
Reviewed-on: https://chromium-review.googlesource.com/633846
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#497243}
Reviewed-on: https://chromium-review.googlesource.com/644218
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1007}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/a1a710dc158931f3333c02e37605090322e80f74/ash/app_list/app_list_presenter_delegate.cc

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment