New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758708 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

SIM PUK unlock dialog doesn't report number of attempts left in error message

Project Member Reported by benchan@chromium.org, Aug 24 2017

Issue description

When unlocking a blocked SIM with an incorrect PUK, the SIM PUK unlock dialog doesn't report number of attempts left in the error message.
 
Status: Available (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbd8341efa7f7e475b2543853b106a8d90ead2e7

commit cbd8341efa7f7e475b2543853b106a8d90ead2e7
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Aug 28 19:32:16 2017

networking_private: provide DeviceStateProperties.SIMLockStatus

Currently we do not provide 'RetriesLeft' in DeviceStateProperties.
This information is required when a sim is locked but no Cellular
service is available.

This CL uses SIMLockStatus in DeviceStateProperties, deprecating
SimLockType in lieu of the more complete structure that matches
NetworkStateProperties. It also provides support for retries left
in the DeviceState C++ helper class.

This also renames DeviceStateProperties.SimPresent -> SIMPresent to
be consistent with NetworkStateProperties.

It also fixes a minor bug in the sim lock button behavior (stopping
propagation incorrectly) and improves support in the fake
implementation.

Bug:  758708 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I63f1cb233d9cbaf3413cdcd98f0baeb88f26ffe1
Reviewed-on: https://chromium-review.googlesource.com/633900
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497838}
[modify] https://crrev.com/cbd8341efa7f7e475b2543853b106a8d90ead2e7/chrome/browser/resources/settings/internet_page/network_siminfo.js
[modify] https://crrev.com/cbd8341efa7f7e475b2543853b106a8d90ead2e7/chrome/browser/resources/settings/internet_page/network_summary_item.js
[modify] https://crrev.com/cbd8341efa7f7e475b2543853b106a8d90ead2e7/chrome/test/data/extensions/api_test/networking_private/chromeos/test.js
[modify] https://crrev.com/cbd8341efa7f7e475b2543853b106a8d90ead2e7/chromeos/dbus/fake_shill_manager_client.cc
[modify] https://crrev.com/cbd8341efa7f7e475b2543853b106a8d90ead2e7/chromeos/network/device_state.cc
[modify] https://crrev.com/cbd8341efa7f7e475b2543853b106a8d90ead2e7/chromeos/network/device_state.h
[modify] https://crrev.com/cbd8341efa7f7e475b2543853b106a8d90ead2e7/extensions/browser/api/networking_private/networking_private_chromeos.cc
[modify] https://crrev.com/cbd8341efa7f7e475b2543853b106a8d90ead2e7/extensions/common/api/networking_onc.idl
[modify] https://crrev.com/cbd8341efa7f7e475b2543853b106a8d90ead2e7/extensions/common/api/networking_private.idl
[modify] https://crrev.com/cbd8341efa7f7e475b2543853b106a8d90ead2e7/third_party/closure_compiler/externs/networking_private.js

Owner: steve...@chromium.org
Status: Fixed (was: Available)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment