SIM PUK unlock dialog doesn't report number of attempts left in error message |
|||
Issue descriptionWhen unlocking a blocked SIM with an incorrect PUK, the SIM PUK unlock dialog doesn't report number of attempts left in the error message.
,
Aug 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cbd8341efa7f7e475b2543853b106a8d90ead2e7 commit cbd8341efa7f7e475b2543853b106a8d90ead2e7 Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon Aug 28 19:32:16 2017 networking_private: provide DeviceStateProperties.SIMLockStatus Currently we do not provide 'RetriesLeft' in DeviceStateProperties. This information is required when a sim is locked but no Cellular service is available. This CL uses SIMLockStatus in DeviceStateProperties, deprecating SimLockType in lieu of the more complete structure that matches NetworkStateProperties. It also provides support for retries left in the DeviceState C++ helper class. This also renames DeviceStateProperties.SimPresent -> SIMPresent to be consistent with NetworkStateProperties. It also fixes a minor bug in the sim lock button behavior (stopping propagation incorrectly) and improves support in the fake implementation. Bug: 758708 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I63f1cb233d9cbaf3413cdcd98f0baeb88f26ffe1 Reviewed-on: https://chromium-review.googlesource.com/633900 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#497838} [modify] https://crrev.com/cbd8341efa7f7e475b2543853b106a8d90ead2e7/chrome/browser/resources/settings/internet_page/network_siminfo.js [modify] https://crrev.com/cbd8341efa7f7e475b2543853b106a8d90ead2e7/chrome/browser/resources/settings/internet_page/network_summary_item.js [modify] https://crrev.com/cbd8341efa7f7e475b2543853b106a8d90ead2e7/chrome/test/data/extensions/api_test/networking_private/chromeos/test.js [modify] https://crrev.com/cbd8341efa7f7e475b2543853b106a8d90ead2e7/chromeos/dbus/fake_shill_manager_client.cc [modify] https://crrev.com/cbd8341efa7f7e475b2543853b106a8d90ead2e7/chromeos/network/device_state.cc [modify] https://crrev.com/cbd8341efa7f7e475b2543853b106a8d90ead2e7/chromeos/network/device_state.h [modify] https://crrev.com/cbd8341efa7f7e475b2543853b106a8d90ead2e7/extensions/browser/api/networking_private/networking_private_chromeos.cc [modify] https://crrev.com/cbd8341efa7f7e475b2543853b106a8d90ead2e7/extensions/common/api/networking_onc.idl [modify] https://crrev.com/cbd8341efa7f7e475b2543853b106a8d90ead2e7/extensions/common/api/networking_private.idl [modify] https://crrev.com/cbd8341efa7f7e475b2543853b106a8d90ead2e7/third_party/closure_compiler/externs/networking_private.js
,
Aug 30 2017
,
Jan 22 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by benchan@chromium.org
, Aug 24 2017