New issue
Advanced search Search tips

Issue 758706 link

Starred by 2 users
Status: Started
Owner:
w...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 3
Type: Feature



Sign in to add a comment

Consider enabling SO_KEEPALIVE on Fuchsia

Project Member Reported by sergeyu@chromium.org, Aug 24 2017 
I'm going to disable SO_KEEPALIVE on Fuchsia because it's not implemented there (see https://chromium-review.googlesource.com/c/chromium/src/+/630978 ). Currently SO_KEEPALIVE is set for all TCP sockets on all platforms except Android and iOS. See https://chromium.googlesource.com/chromium/src/+/9fd93b0de71b01ef99bad0d95ac789804871697d/net/socket/tcp_socket_posix.cc#402

Filed NET-161 to get this feature implemented in Fuchsia. Once it's implemented we will need to decide if and when it's useful on Fuchsia.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4613270be5c6dc15cf611df28f9ff0c81e3a9c2

commit e4613270be5c6dc15cf611df28f9ff0c81e3a9c2
Author: Sergey Ulanov <sergeyu@google.com>
Date: Fri Aug 25 00:34:30 2017

Don't set SO_KEEPALIVE on Fuchsia

SO_KEEPALIVE is not implemented on Fuchsia, but TCPSocketPosix tries to
enable it for all sockets, which causes netstack to spam console.
SO_KEEPALIVE is not used on Android and iOS. Disable it on Fuchsia too.

Bug:  731302 , 758706
Change-Id: I2ea1deb52de43c46550b8dc1eae92c876228bf4a
Reviewed-on: https://chromium-review.googlesource.com/630978
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497263}
[modify] https://crrev.com/e4613270be5c6dc15cf611df28f9ff0c81e3a9c2/net/socket/tcp_socket_posix.cc

Comment 2 by w...@chromium.org, Jan 20 (3 days ago)

Owner: w...@chromium.org
Status: Started (was: Untriaged)
Looks like SO_KEEPALIVE is now supported!
►

Sign in to add a comment