New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758686 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove extra retry logic in Paygen.

Project Member Reported by dgarr...@chromium.org, Aug 24 2017

Issue description

We've finally figured out why Golden Eye published files were sometimes corrupt in Google Storage, and so no longer need the extra retries.

Rip them out to simplify code, and ensure the fix.
 
Labels: Hotlist-Fixit
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/838f72bf3df91144aa98c9a5a9a33be40f5a6b9e

commit 838f72bf3df91144aa98c9a5a9a33be40f5a6b9e
Author: Don Garrett <dgarrett@google.com>
Date: Wed Sep 27 19:58:03 2017

paygen_build: Remove json parsing retry loop.

leecy found and fixed the cause of the empty json files in GS, so
there is no longer a need for us to poll for good files.

BUG= chromium:758686 
TEST=run_tests

Change-Id: Ifbab624c91ad4fff6a6c34be682f4680d69ab697
Reviewed-on: https://chromium-review.googlesource.com/683454
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/838f72bf3df91144aa98c9a5a9a33be40f5a6b9e/lib/paygen/paygen_build_lib.py

Status: Fixed (was: Started)

Sign in to add a comment