New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 758684 link

Starred by 4 users
Status: Started
Owner:
chrisha@chromium.org
Cc:
█ zh...@chromium.org
edwardjung@chromium.org
pkasting@chromium.org
sky@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Don't display the spinner for background tabs that are loading during a session restore.

Project Member Reported by chrisha@chromium.org, Aug 24 2017 
This is a short term fix as part of ongoing discussions around tab strip UX for indicating tab state. A consensus has been reached that the throbber/spinner being displayed for background tabs is largely a source of visual noise during a session restore.

The UX team is in the middle of a full rethink of how to communicate tab state via the tab strip, especially in light of ongoing feature work around proactive tab discarding and staggered background-disposition tab opening. Expect more work here in the near future.

Comment 1 by chrisha@chromium.org, Sep 5 2017

Labels: Hotlist-TooManyTabs
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a60bcdada48c6a307d1b4dd7d02302f216645607

commit a60bcdada48c6a307d1b4dd7d02302f216645607
Author: Zhen Wang <zhenw@chromium.org>
Date: Fri Nov 03 23:51:56 2017

Update spinner/title logic for session restore and background tab opening

This prototype updates the spinner/title logic for session restore and
staggered background tab opening feature.

For session restore, we do not want to show the spinner for backgrounded
session-restore created tabs.

For staggered background tab opening feature, when a background tab's
navigation is delayed, we want to show the favicon from history service and
the host as the title for better user experience.

Bug:  762133 , 758684
Change-Id: I16a029f261229c553edefad1fe2d71b3df9c7a3a
Reviewed-on: https://chromium-review.googlesource.com/734201
Commit-Queue: Zhen Wang <zhenw@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513969}
[modify] https://crrev.com/a60bcdada48c6a307d1b4dd7d02302f216645607/chrome/browser/resource_coordinator/tab_manager.cc
[modify] https://crrev.com/a60bcdada48c6a307d1b4dd7d02302f216645607/chrome/browser/resource_coordinator/tab_manager.h
[modify] https://crrev.com/a60bcdada48c6a307d1b4dd7d02302f216645607/chrome/browser/resource_coordinator/tab_manager_unittest.cc
[modify] https://crrev.com/a60bcdada48c6a307d1b4dd7d02302f216645607/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/a60bcdada48c6a307d1b4dd7d02302f216645607/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
[modify] https://crrev.com/a60bcdada48c6a307d1b4dd7d02302f216645607/chrome/browser/ui/tab_helpers.cc
[add] https://crrev.com/a60bcdada48c6a307d1b4dd7d02302f216645607/chrome/browser/ui/tab_ui_helper.cc
[add] https://crrev.com/a60bcdada48c6a307d1b4dd7d02302f216645607/chrome/browser/ui/tab_ui_helper.h
[modify] https://crrev.com/a60bcdada48c6a307d1b4dd7d02302f216645607/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/a60bcdada48c6a307d1b4dd7d02302f216645607/chrome/browser/ui/views/tabs/browser_tab_strip_controller.h
[modify] https://crrev.com/a60bcdada48c6a307d1b4dd7d02302f216645607/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/a60bcdada48c6a307d1b4dd7d02302f216645607/chrome/browser/ui/views/tabs/tab.h
[modify] https://crrev.com/a60bcdada48c6a307d1b4dd7d02302f216645607/chrome/browser/ui/views/tabs/tab_renderer_data.cc
[modify] https://crrev.com/a60bcdada48c6a307d1b4dd7d02302f216645607/chrome/browser/ui/views/tabs/tab_renderer_data.h
[modify] https://crrev.com/a60bcdada48c6a307d1b4dd7d02302f216645607/chrome/browser/ui/views/tabs/tab_unittest.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc9231eb012b76968f2fe3c3332ec131e0cb3e5b

commit dc9231eb012b76968f2fe3c3332ec131e0cb3e5b
Author: Zhen Wang <zhenw@chromium.org>
Date: Mon Nov 06 06:51:29 2017

Revert "Update spinner/title logic for session restore and background tab opening"

This reverts commit a60bcdada48c6a307d1b4dd7d02302f216645607.

Reason for revert:

Crashing in canary. See http://crbug.com/781669

Original change's description:
> Update spinner/title logic for session restore and background tab opening
> 
> This prototype updates the spinner/title logic for session restore and
> staggered background tab opening feature.
> 
> For session restore, we do not want to show the spinner for backgrounded
> session-restore created tabs.
> 
> For staggered background tab opening feature, when a background tab's
> navigation is delayed, we want to show the favicon from history service and
> the host as the title for better user experience.
> 
> Bug:  762133 , 758684
> Change-Id: I16a029f261229c553edefad1fe2d71b3df9c7a3a
> Reviewed-on: https://chromium-review.googlesource.com/734201
> Commit-Queue: Zhen Wang <zhenw@chromium.org>
> Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#513969}

TBR=avi@chromium.org,sky@chromium.org,chrisha@chromium.org,zhenw@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  762133 , 758684, 781669
Change-Id: I2208a3a80480edc8684ce733ae4b0be793a4b258
Reviewed-on: https://chromium-review.googlesource.com/753709
Reviewed-by: Zhen Wang <zhenw@chromium.org>
Commit-Queue: Zhen Wang <zhenw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514094}
[modify] https://crrev.com/dc9231eb012b76968f2fe3c3332ec131e0cb3e5b/chrome/browser/resource_coordinator/tab_manager.cc
[modify] https://crrev.com/dc9231eb012b76968f2fe3c3332ec131e0cb3e5b/chrome/browser/resource_coordinator/tab_manager.h
[modify] https://crrev.com/dc9231eb012b76968f2fe3c3332ec131e0cb3e5b/chrome/browser/resource_coordinator/tab_manager_unittest.cc
[modify] https://crrev.com/dc9231eb012b76968f2fe3c3332ec131e0cb3e5b/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/dc9231eb012b76968f2fe3c3332ec131e0cb3e5b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
[modify] https://crrev.com/dc9231eb012b76968f2fe3c3332ec131e0cb3e5b/chrome/browser/ui/tab_helpers.cc
[delete] https://crrev.com/57e1b8ab157e9bbe862b1dbebeee5bcf04756b37/chrome/browser/ui/tab_ui_helper.cc
[delete] https://crrev.com/57e1b8ab157e9bbe862b1dbebeee5bcf04756b37/chrome/browser/ui/tab_ui_helper.h
[modify] https://crrev.com/dc9231eb012b76968f2fe3c3332ec131e0cb3e5b/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/dc9231eb012b76968f2fe3c3332ec131e0cb3e5b/chrome/browser/ui/views/tabs/browser_tab_strip_controller.h
[modify] https://crrev.com/dc9231eb012b76968f2fe3c3332ec131e0cb3e5b/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/dc9231eb012b76968f2fe3c3332ec131e0cb3e5b/chrome/browser/ui/views/tabs/tab.h
[modify] https://crrev.com/dc9231eb012b76968f2fe3c3332ec131e0cb3e5b/chrome/browser/ui/views/tabs/tab_renderer_data.cc
[modify] https://crrev.com/dc9231eb012b76968f2fe3c3332ec131e0cb3e5b/chrome/browser/ui/views/tabs/tab_renderer_data.h
[modify] https://crrev.com/dc9231eb012b76968f2fe3c3332ec131e0cb3e5b/chrome/browser/ui/views/tabs/tab_unittest.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 7 2017

Labels: merge-merged-3260
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73679839bd0520ad541e3b0bdccbca44ca0abc4d

commit 73679839bd0520ad541e3b0bdccbca44ca0abc4d
Author: Zhen Wang <zhenw@chromium.org>
Date: Tue Nov 07 00:48:19 2017

Revert "Update spinner/title logic for session restore and background tab opening"

This reverts commit a60bcdada48c6a307d1b4dd7d02302f216645607.

Reason for revert:

Crashing in canary. See http://crbug.com/781669

Original change's description:
> Update spinner/title logic for session restore and background tab opening
> 
> This prototype updates the spinner/title logic for session restore and
> staggered background tab opening feature.
> 
> For session restore, we do not want to show the spinner for backgrounded
> session-restore created tabs.
> 
> For staggered background tab opening feature, when a background tab's
> navigation is delayed, we want to show the favicon from history service and
> the host as the title for better user experience.
> 
> Bug:  762133 , 758684
> Change-Id: I16a029f261229c553edefad1fe2d71b3df9c7a3a
> Reviewed-on: https://chromium-review.googlesource.com/734201
> Commit-Queue: Zhen Wang <zhenw@chromium.org>
> Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#513969}

TBR=avi@chromium.org,sky@chromium.org,chrisha@chromium.org,zhenw@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  762133 , 758684, 781669
Change-Id: I2208a3a80480edc8684ce733ae4b0be793a4b258
Reviewed-on: https://chromium-review.googlesource.com/753709
Reviewed-by: Zhen Wang <zhenw@chromium.org>
Commit-Queue: Zhen Wang <zhenw@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#514094}(cherry picked from commit dc9231eb012b76968f2fe3c3332ec131e0cb3e5b)
Reviewed-on: https://chromium-review.googlesource.com/756186
Reviewed-by: Abdul Syed <abdulsyed@google.com>
Cr-Commit-Position: refs/branch-heads/3260@{#2}
Cr-Branched-From: eec83ceb16d47f70f5804a140687e268a6230b5c-refs/heads/master@{#514066}
[modify] https://crrev.com/73679839bd0520ad541e3b0bdccbca44ca0abc4d/chrome/browser/resource_coordinator/tab_manager.cc
[modify] https://crrev.com/73679839bd0520ad541e3b0bdccbca44ca0abc4d/chrome/browser/resource_coordinator/tab_manager.h
[modify] https://crrev.com/73679839bd0520ad541e3b0bdccbca44ca0abc4d/chrome/browser/resource_coordinator/tab_manager_unittest.cc
[modify] https://crrev.com/73679839bd0520ad541e3b0bdccbca44ca0abc4d/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/73679839bd0520ad541e3b0bdccbca44ca0abc4d/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
[modify] https://crrev.com/73679839bd0520ad541e3b0bdccbca44ca0abc4d/chrome/browser/ui/tab_helpers.cc
[delete] https://crrev.com/949c1540cbf883023a48fec4dc6a720a3817ef2e/chrome/browser/ui/tab_ui_helper.cc
[delete] https://crrev.com/949c1540cbf883023a48fec4dc6a720a3817ef2e/chrome/browser/ui/tab_ui_helper.h
[modify] https://crrev.com/73679839bd0520ad541e3b0bdccbca44ca0abc4d/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/73679839bd0520ad541e3b0bdccbca44ca0abc4d/chrome/browser/ui/views/tabs/browser_tab_strip_controller.h
[modify] https://crrev.com/73679839bd0520ad541e3b0bdccbca44ca0abc4d/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/73679839bd0520ad541e3b0bdccbca44ca0abc4d/chrome/browser/ui/views/tabs/tab.h
[modify] https://crrev.com/73679839bd0520ad541e3b0bdccbca44ca0abc4d/chrome/browser/ui/views/tabs/tab_renderer_data.cc
[modify] https://crrev.com/73679839bd0520ad541e3b0bdccbca44ca0abc4d/chrome/browser/ui/views/tabs/tab_renderer_data.h
[modify] https://crrev.com/73679839bd0520ad541e3b0bdccbca44ca0abc4d/chrome/browser/ui/views/tabs/tab_unittest.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fb94bff1f5368ee0f4f89590d496d21b08739ce

commit 3fb94bff1f5368ee0f4f89590d496d21b08739ce
Author: Zhen Wang <zhenw@chromium.org>
Date: Wed Nov 08 22:27:07 2017

Reland - Update spinner/title logic for session restore and background tab opening

This CL relands the previous CL with fix for the crash (see crbug.com/781669)

Previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/734201

**** Original CL discription ****

This prototype updates the spinner/title logic for session restore and
staggered background tab opening feature.

For session restore, we do not want to show the spinner for backgrounded
session-restore created tabs.

For staggered background tab opening feature, when a background tab's
navigation is delayed, we want to show the favicon from history service and
the host as the title for better user experience.

Bug:  762133 , 758684
Change-Id: I32643d5b269c4afa5c7e30b23b07d6bda16ef386
Reviewed-on: https://chromium-review.googlesource.com/755540
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Zhen Wang <zhenw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514972}
[modify] https://crrev.com/3fb94bff1f5368ee0f4f89590d496d21b08739ce/chrome/browser/resource_coordinator/background_tab_navigation_throttle.cc
[modify] https://crrev.com/3fb94bff1f5368ee0f4f89590d496d21b08739ce/chrome/browser/resource_coordinator/background_tab_navigation_throttle_unittest.cc
[modify] https://crrev.com/3fb94bff1f5368ee0f4f89590d496d21b08739ce/chrome/browser/resource_coordinator/tab_manager.cc
[modify] https://crrev.com/3fb94bff1f5368ee0f4f89590d496d21b08739ce/chrome/browser/resource_coordinator/tab_manager.h
[modify] https://crrev.com/3fb94bff1f5368ee0f4f89590d496d21b08739ce/chrome/browser/resource_coordinator/tab_manager_unittest.cc
[modify] https://crrev.com/3fb94bff1f5368ee0f4f89590d496d21b08739ce/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/3fb94bff1f5368ee0f4f89590d496d21b08739ce/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
[modify] https://crrev.com/3fb94bff1f5368ee0f4f89590d496d21b08739ce/chrome/browser/ui/tab_helpers.cc
[add] https://crrev.com/3fb94bff1f5368ee0f4f89590d496d21b08739ce/chrome/browser/ui/tab_ui_helper.cc
[add] https://crrev.com/3fb94bff1f5368ee0f4f89590d496d21b08739ce/chrome/browser/ui/tab_ui_helper.h
[modify] https://crrev.com/3fb94bff1f5368ee0f4f89590d496d21b08739ce/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/3fb94bff1f5368ee0f4f89590d496d21b08739ce/chrome/browser/ui/views/tabs/browser_tab_strip_controller.h
[modify] https://crrev.com/3fb94bff1f5368ee0f4f89590d496d21b08739ce/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/3fb94bff1f5368ee0f4f89590d496d21b08739ce/chrome/browser/ui/views/tabs/tab.h
[modify] https://crrev.com/3fb94bff1f5368ee0f4f89590d496d21b08739ce/chrome/browser/ui/views/tabs/tab_renderer_data.cc
[modify] https://crrev.com/3fb94bff1f5368ee0f4f89590d496d21b08739ce/chrome/browser/ui/views/tabs/tab_renderer_data.h
[modify] https://crrev.com/3fb94bff1f5368ee0f4f89590d496d21b08739ce/chrome/browser/ui/views/tabs/tab_unittest.cc

Comment 6 by ojan@chromium.org, May 8 2018

Cc: -ojan@chromium.org
►

Sign in to add a comment