Cleanup: combine GetAppOutputInternal() with LaunchProcess(). |
|||
Issue descriptionThere is a lot of overlap with GetAppOutputInternal() and LaunchProcess() in launch_fuchsia.cc. We might be able to combine the two functions.
,
Aug 25 2017
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78d126564439a3d8540a5a2732f5da0a26496a03 commit 78d126564439a3d8540a5a2732f5da0a26496a03 Author: Wez <wez@chromium.org> Date: Tue Aug 29 23:22:48 2017 Simplify GetAppOutputInternal to use LaunchProcess() internally. GetAppOutputInternal is used by the various GetAppOutput* helpers to launch a process and capture its stdout/stderr. Rather than having it implement process-launching directly, having it re-use LaunchProcess reduces the repetition in our wrapper code. Bug: 758683 Change-Id: I6bc288a8393f6eb86d7953a1ea472dbe9d6ddade Reviewed-on: https://chromium-review.googlesource.com/640452 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#498279} [modify] https://crrev.com/78d126564439a3d8540a5a2732f5da0a26496a03/base/process/launch_fuchsia.cc
,
Aug 29 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by w...@chromium.org
, Aug 24 2017Status: Assigned (was: Untriaged)