Copied  issue chromium:758680  from issue chromium:758679

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e64f8fc4fe4ef3224747b9d6ed06a3fdf21a99f

commit 1e64f8fc4fe4ef3224747b9d6ed06a3fdf21a99f
Author: Sean Kau <skau@chromium.org>
Date: Thu Aug 31 19:27:19 2017

Define the bulk enterprise printer policy.

Enterprise printer configurations will now be distributed as a file
encoded in JSON and a policy indicating what printers
are allowed.

Bug:  758680 
Change-Id: If2d4063f6d5dea13a743bf9309db85b24ff4efe7
Reviewed-on: https://chromium-review.googlesource.com/616257
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498951}
[modify] https://crrev.com/1e64f8fc4fe4ef3224747b9d6ed06a3fdf21a99f/chrome/browser/chromeos/printing/synced_printers_manager.cc
[modify] https://crrev.com/1e64f8fc4fe4ef3224747b9d6ed06a3fdf21a99f/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/1e64f8fc4fe4ef3224747b9d6ed06a3fdf21a99f/chrome/common/pref_names.cc
[modify] https://crrev.com/1e64f8fc4fe4ef3224747b9d6ed06a3fdf21a99f/chrome/common/pref_names.h
[modify] https://crrev.com/1e64f8fc4fe4ef3224747b9d6ed06a3fdf21a99f/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/1e64f8fc4fe4ef3224747b9d6ed06a3fdf21a99f/components/policy/resources/policy_templates.json
[modify] https://crrev.com/1e64f8fc4fe4ef3224747b9d6ed06a3fdf21a99f/tools/metrics/histograms/enums.xml

Hit a bit of a delay.  Reading the external policy is less straightforward than originally thought.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4eda54c3deba249a3152bcbd6b4df4d982ae660

commit a4eda54c3deba249a3152bcbd6b4df4d982ae660
Author: Sean Kau <skau@chromium.org>
Date: Tue Dec 05 23:24:40 2017

Process the bulk printer policy.

Read the new external policy, enforce the selected policies, provide
printers to clients.  Code path is not connected yet.

Bug:  758680 
Change-Id: I178d0afd1e0e60d5c0cdaa8adfebb14d1d5d7070
Reviewed-on: https://chromium-review.googlesource.com/677865
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521884}
[modify] https://crrev.com/a4eda54c3deba249a3152bcbd6b4df4d982ae660/chrome/browser/chromeos/BUILD.gn
[add] https://crrev.com/a4eda54c3deba249a3152bcbd6b4df4d982ae660/chrome/browser/chromeos/printing/external_printers.cc
[add] https://crrev.com/a4eda54c3deba249a3152bcbd6b4df4d982ae660/chrome/browser/chromeos/printing/external_printers.h
[add] https://crrev.com/a4eda54c3deba249a3152bcbd6b4df4d982ae660/chrome/browser/chromeos/printing/external_printers_unittest.cc
[modify] https://crrev.com/a4eda54c3deba249a3152bcbd6b4df4d982ae660/chromeos/printing/printer_translator.cc
[modify] https://crrev.com/a4eda54c3deba249a3152bcbd6b4df4d982ae660/chromeos/printing/printer_translator_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2945b4acf4c0c95c0c84472dded8b5ad094a5acf

commit 2945b4acf4c0c95c0c84472dded8b5ad094a5acf
Author: Sean Kau <skau@chromium.org>
Date: Fri Dec 22 23:13:58 2017

Parse JSON and compute off the UI thread for policy printers.

Change ExternalPrinters to perform slow operations off the UI thread
to avoid introducing jank.  Also add infrastructure to observe
preferences and manage instances by user.

Bug:  758680 
Change-Id: I56f4dae9f0c2062cfe177fcdac88785978874217
Reviewed-on: https://chromium-review.googlesource.com/826705
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Xiaoqian Dai OOO until Jan 2nd <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526087}
[modify] https://crrev.com/2945b4acf4c0c95c0c84472dded8b5ad094a5acf/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/2945b4acf4c0c95c0c84472dded8b5ad094a5acf/chrome/browser/chromeos/printing/external_printers.cc
[modify] https://crrev.com/2945b4acf4c0c95c0c84472dded8b5ad094a5acf/chrome/browser/chromeos/printing/external_printers.h
[add] https://crrev.com/2945b4acf4c0c95c0c84472dded8b5ad094a5acf/chrome/browser/chromeos/printing/external_printers_factory.cc
[add] https://crrev.com/2945b4acf4c0c95c0c84472dded8b5ad094a5acf/chrome/browser/chromeos/printing/external_printers_factory.h
[add] https://crrev.com/2945b4acf4c0c95c0c84472dded8b5ad094a5acf/chrome/browser/chromeos/printing/external_printers_pref_bridge.cc
[add] https://crrev.com/2945b4acf4c0c95c0c84472dded8b5ad094a5acf/chrome/browser/chromeos/printing/external_printers_pref_bridge.h
[modify] https://crrev.com/2945b4acf4c0c95c0c84472dded8b5ad094a5acf/chrome/browser/chromeos/printing/external_printers_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68fa97d099863c6a89c077f1e4e78da857759416

commit 68fa97d099863c6a89c077f1e4e78da857759416
Author: Keishi Hattori <keishi@chromium.org>
Date: Sun Dec 24 21:50:49 2017

Revert "Parse JSON and compute off the UI thread for policy printers."

This reverts commit 2945b4acf4c0c95c0c84472dded8b5ad094a5acf.

Reason for revert: ExternalPrintersTest.* failing on Linux Chromium OS ASan LSan Tests
https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/25356

Original change's description:
> Parse JSON and compute off the UI thread for policy printers.
> 
> Change ExternalPrinters to perform slow operations off the UI thread
> to avoid introducing jank.  Also add infrastructure to observe
> preferences and manage instances by user.
> 
> Bug:  758680 
> Change-Id: I56f4dae9f0c2062cfe177fcdac88785978874217
> Reviewed-on: https://chromium-review.googlesource.com/826705
> Commit-Queue: Sean Kau <skau@chromium.org>
> Reviewed-by: Xiaoqian Dai OOO until Jan 2nd <xdai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#526087}

TBR=xdai@chromium.org,skau@chromium.org,justincarlson@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  758680 
Change-Id: Iec13f21a1e5af25c89233733c0926ce6cad91671
Reviewed-on: https://chromium-review.googlesource.com/844174
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526162}
[modify] https://crrev.com/68fa97d099863c6a89c077f1e4e78da857759416/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/68fa97d099863c6a89c077f1e4e78da857759416/chrome/browser/chromeos/printing/external_printers.cc
[modify] https://crrev.com/68fa97d099863c6a89c077f1e4e78da857759416/chrome/browser/chromeos/printing/external_printers.h
[delete] https://crrev.com/889aca57994d3d398e588e5d2b0f3a75af52e8c5/chrome/browser/chromeos/printing/external_printers_factory.cc
[delete] https://crrev.com/889aca57994d3d398e588e5d2b0f3a75af52e8c5/chrome/browser/chromeos/printing/external_printers_factory.h
[delete] https://crrev.com/889aca57994d3d398e588e5d2b0f3a75af52e8c5/chrome/browser/chromeos/printing/external_printers_pref_bridge.cc
[delete] https://crrev.com/889aca57994d3d398e588e5d2b0f3a75af52e8c5/chrome/browser/chromeos/printing/external_printers_pref_bridge.h
[modify] https://crrev.com/68fa97d099863c6a89c077f1e4e78da857759416/chrome/browser/chromeos/printing/external_printers_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32d923801c1ba214c40d108cf86967740e9fb1bb

commit 32d923801c1ba214c40d108cf86967740e9fb1bb
Author: Sean Kau <skau@chromium.org>
Date: Fri Jan 05 01:59:17 2018

Parse JSON and compute off the UI thread for policy printers.

Change ExternalPrinters to perform slow operations off the UI thread
to avoid introducing jank.  Also add infrastructure to observe
preferences and manage instances by user.

Reland of https://chromium-review.googlesource.com/c/chromium/src/+/826705
Fixes memory leak.

Bug:  758680 
Change-Id: I150b77b974985902f49c9010b3696e8b56a04a4b
Reviewed-on: https://chromium-review.googlesource.com/846294
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527188}
[modify] https://crrev.com/32d923801c1ba214c40d108cf86967740e9fb1bb/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/32d923801c1ba214c40d108cf86967740e9fb1bb/chrome/browser/chromeos/printing/external_printers.cc
[modify] https://crrev.com/32d923801c1ba214c40d108cf86967740e9fb1bb/chrome/browser/chromeos/printing/external_printers.h
[add] https://crrev.com/32d923801c1ba214c40d108cf86967740e9fb1bb/chrome/browser/chromeos/printing/external_printers_factory.cc
[add] https://crrev.com/32d923801c1ba214c40d108cf86967740e9fb1bb/chrome/browser/chromeos/printing/external_printers_factory.h
[add] https://crrev.com/32d923801c1ba214c40d108cf86967740e9fb1bb/chrome/browser/chromeos/printing/external_printers_pref_bridge.cc
[add] https://crrev.com/32d923801c1ba214c40d108cf86967740e9fb1bb/chrome/browser/chromeos/printing/external_printers_pref_bridge.h
[modify] https://crrev.com/32d923801c1ba214c40d108cf86967740e9fb1bb/chrome/browser/chromeos/printing/external_printers_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09cdec6d17e8bd39061a429d6ef885df2f119c0a

commit 09cdec6d17e8bd39061a429d6ef885df2f119c0a
Author: Sean Kau <skau@chromium.org>
Date: Mon Jan 08 19:52:39 2018

Use new CrOS printer configurations.

Download and use the NativePrintersBulk* policies. This allows
the configuration of an arbitrarily large number of printers
for an enterprise user.

Bug:  758680 
Change-Id: Ie5619f2e9b4b531608fd0cd2ee4e58cf5cf39701
Reviewed-on: https://chromium-review.googlesource.com/852447
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527720}
[modify] https://crrev.com/09cdec6d17e8bd39061a429d6ef885df2f119c0a/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/09cdec6d17e8bd39061a429d6ef885df2f119c0a/chrome/browser/chromeos/login/users/chrome_user_manager_impl.h
[modify] https://crrev.com/09cdec6d17e8bd39061a429d6ef885df2f119c0a/chrome/browser/chromeos/printing/synced_printers_manager.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0194564f22fd2781af86d14ef3ae7b4ba4ee61a7

commit 0194564f22fd2781af86d14ef3ae7b4ba4ee61a7
Author: Sean Kau <skau@chromium.org>
Date: Wed Jan 10 19:25:14 2018

Enable Bulk Printers Policy by default.

Read the new bulk printers policies for printer
configurations for enterprise users.

Bug:  758680 , 755560
Change-Id: Ic6137e0ec542e95888a25463f0b66c7ba460473c
Reviewed-on: https://chromium-review.googlesource.com/854698
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528379}
[modify] https://crrev.com/0194564f22fd2781af86d14ef3ae7b4ba4ee61a7/chrome/common/chrome_features.cc

As verified in M65.0.3325.93 10323.41.0 beta paine on YAPS, the four policies are in place and working fine.

Re-opening this issue as policy definition is ambigous as to how this is set and used:

https://www.chromium.org/administrators/policy-list-3#NativePrintersBulkConfiguration

What type of hash is the hash value (would have been best if we had named it something like sha256-hash but we need to at least document on policy def. what type of hash it is)

The hash is the SHA-256 of the JSON file.  I'll update the template.

policy_templates.json fixed separately.

Hi jayhlee@ does Sean's update satisfy your question in #17?

skau@ could you provide a link to the update policy template, just for reference?

Yes, that's helpful. Once the policy template is updated I assume that will trickle down to the chromium.org doc I linked to?

Lutz fixed it last time he changed the file.  https://chromium-review.googlesource.com/1001576

Can I assume it is now satisfactory to close-verified?

Sure?

Client work is confirmed working in TT.