New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 758679 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocked on:
issue 767963

Blocking:
issue 807068
issue 915272



Sign in to add a comment

Add NativeDevicePrintersPolicy

Project Member Reported by skau@chromium.org, Aug 24 2017

Issue description

Define and register policies for device printers.

NativeDevicePrintersFile
NativeDevicePrinterskAccessMode
NativeDevicePrintersWhitelist
NativeDevicePrintersBlacklist
 

Comment 1 by skau@chromium.org, Aug 24 2017

Blocking: 755560

Comment 3 by skau@chromium.org, Aug 24 2017

Summary: Add NativeDevicePrintersPolicy (was: Add NativePrintersBulk policy)

Comment 4 by skau@chromium.org, Aug 24 2017

Description: Show this description
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f183a0083e749de3c9a80044deb83a1173fe249b

commit f183a0083e749de3c9a80044deb83a1173fe249b
Author: Sean Kau <skau@chromium.org>
Date: Sat Sep 02 01:50:30 2017

Define device policies for enterpise printers.

Enterprise printers in ChromeOS can be configured either for a user or
for the device.  This implements the device policy which is identical
to the user policy.

Bug: 758679
Change-Id: I05dcb255d1ca50b2c16d94a5540232c313d5d4fe
Reviewed-on: https://chromium-review.googlesource.com/646695
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499371}
[modify] https://crrev.com/f183a0083e749de3c9a80044deb83a1173fe249b/chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc
[modify] https://crrev.com/f183a0083e749de3c9a80044deb83a1173fe249b/chrome/browser/chromeos/policy/proto/chrome_device_policy.proto
[modify] https://crrev.com/f183a0083e749de3c9a80044deb83a1173fe249b/chrome/browser/chromeos/settings/device_settings_provider.cc
[modify] https://crrev.com/f183a0083e749de3c9a80044deb83a1173fe249b/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/f183a0083e749de3c9a80044deb83a1173fe249b/chromeos/settings/cros_settings_names.cc
[modify] https://crrev.com/f183a0083e749de3c9a80044deb83a1173fe249b/chromeos/settings/cros_settings_names.h
[modify] https://crrev.com/f183a0083e749de3c9a80044deb83a1173fe249b/components/policy/resources/policy_templates.json
[modify] https://crrev.com/f183a0083e749de3c9a80044deb83a1173fe249b/tools/metrics/histograms/enums.xml

Labels: -M-62 M-63

Comment 7 by skau@chromium.org, Sep 22 2017

Blockedon: 767963
Labels: -Type-Bug Type-Feature
Labels: -M-63 M-64
Launch is slated for M-64
Labels: -M-64 M-65

Comment 11 by skau@chromium.org, Feb 3 2018

Labels: -M-65 M-66
Labels: -M-66 M-67
skau@ - is this blocking remove 20 printers for user settings?

Comment 14 by skau@chromium.org, Mar 6 2018

No
Blocking: -755560
ok. In that case, I'll update this bug to reflect that (not blocking "Remove 20 Printers for user settings" -- Issue 755560)
skau@ - assuming this is blocking remove 20 printers for device settings (https://bugs.chromium.org/p/chromium/issues/detail?id=807068#c1)?

Comment 17 by skau@chromium.org, Mar 7 2018

This is the bug tracking device settings work
Labels: -M-67 M-68

Comment 19 by skau@chromium.org, Apr 26 2018

Blocking: 823674

Comment 20 by skau@chromium.org, May 14 2018

I ended up writing a design doc
go/external-data-for-device-policy
Hey sean... link's not working.

Comment 22 by skau@chromium.org, May 16 2018

The link should work now.
Project Member

Comment 23 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/bd2fbfe0e529de0c4e95d001926d0abac351110f

commit bd2fbfe0e529de0c4e95d001926d0abac351110f
Author: Sean Kau <skau@chromium.org>
Date: Wed May 30 04:22:37 2018

autotest: Add path to security_StatefulPermissions

Add the directory for Device Policy External Data to the list
of directories owned by chronos in security_StatefulPermissions.

TEST=test_that ... security_StatefulPermissions
BUG=chromium:758679
CQ-DEPEND=CL:1072950

Change-Id: I876f21504609feacba103a22b1f6216d08153a73
Reviewed-on: https://chromium-review.googlesource.com/1074327
Commit-Ready: Sean Kau <skau@chromium.org>
Tested-by: Sean Kau <skau@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>

[modify] https://crrev.com/bd2fbfe0e529de0c4e95d001926d0abac351110f/client/site_tests/security_StatefulPermissions/security_StatefulPermissions.py

Project Member

Comment 24 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/c89459574dd525810d65a43f84838ad4fe5840b2

commit c89459574dd525810d65a43f84838ad4fe5840b2
Author: Sean Kau <skau@chromium.org>
Date: Wed May 30 04:22:38 2018

login: Device Policy External Data

Ensure Device Policy External Data directory exists
before Chrome startup.  The new directory,
/var/cache/device_policy_external_data will cache
the data designated by device policy.

BUG=chromium:758679
TEST=Chrome comes up, confirm directory creation and
ownership.
CQ-DEPEND=CL:1074327

Change-Id: I23b172d05d13dd58c9498b60cda291c08234dcd9
Reviewed-on: https://chromium-review.googlesource.com/1072950
Commit-Ready: Sean Kau <skau@chromium.org>
Tested-by: Sean Kau <skau@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/c89459574dd525810d65a43f84838ad4fe5840b2/login_manager/chrome_setup.cc

Labels: -M-68 M-70
Labels: -M-70 M-72
Cc: skau@chromium.org
Owner: nikitapodguzov@chromium.org
I think nikitapodguzov@ is working on this now.
Blocking: -823674
Blocking: 807068
Blocking: 915272

Comment 31 by nikitapodguzov@chromium.org, Yesterday (32 hours ago)

Labels: -M-72 M-73

Sign in to add a comment