Issue metadata
Sign in to add a comment
|
Remove deprecated JS mojo APIs |
||||||||||||||||||||||||
Issue descriptionbattery-status/ bluetooth/ presentation/ layout tests are failing with the network service because those tests use the old loadMojoModules method of loading .mojom files. We need to convert these so that they will work with network service, and then we can remove MojomProtocolHandler. Yuzhu: creating this bug to track the failures, please delegate as necessary :)
,
Aug 24 2017
battery-status is blocked on the question of whether or not we should be making per-frame connections. presentation is blocked on some test failures that I have yet to completely work out.
,
Aug 31 2017
@reillyg @yzshen: can we create a process wide connection for new bindings like old ones for now to unblock battery-status?
,
Aug 31 2017
@jam: I'm working on this right now.
,
Aug 31 2017
ah great!
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/077b0f850e1f737c66c2ab29cc736bd32c5aed6d commit 077b0f850e1f737c66c2ab29cc736bd32c5aed6d Author: John Abd-El-Malek <jam@chromium.org> Date: Thu Aug 31 21:41:12 2017 Add some annotations to network service layout test expectations. A bunch of failures are related to old Mojo JS APIs. Another group is because we don't handle blobs in POSTS. BUG= 761117 , 758675 TBR=reillyg@chromium.org NOTRY=true Change-Id: I131be4b793b3c91b1b735116cf7f86c34819dcb8 Reviewed-on: https://chromium-review.googlesource.com/646514 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#499014} [modify] https://crrev.com/077b0f850e1f737c66c2ab29cc736bd32c5aed6d/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
,
Sep 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c5f5165ec688c2f23f7f65c14a293450807d3ae commit 4c5f5165ec688c2f23f7f65c14a293450807d3ae Author: Reilly Grant <reillyg@chromium.org> Date: Tue Sep 05 23:10:30 2017 [MojoJS] Support intercepting interfaces at process scope This patch expands the concept of "process" scope to the MojoInterfaceInterceptor class. Interceptors created with this option will add binder overrides to the process's Connector. Bug: 758675 Change-Id: Iae8fbc6617faedf46ac43d5171234518e35e1eab Reviewed-on: https://chromium-review.googlesource.com/646764 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#499786} [modify] https://crrev.com/4c5f5165ec688c2f23f7f65c14a293450807d3ae/services/service_manager/public/cpp/connector.cc [modify] https://crrev.com/4c5f5165ec688c2f23f7f65c14a293450807d3ae/services/service_manager/public/cpp/connector.h [modify] https://crrev.com/4c5f5165ec688c2f23f7f65c14a293450807d3ae/third_party/WebKit/LayoutTests/mojo/bind-intercepted-interface-in-worker.html [modify] https://crrev.com/4c5f5165ec688c2f23f7f65c14a293450807d3ae/third_party/WebKit/LayoutTests/mojo/bind-interface.html [add] https://crrev.com/4c5f5165ec688c2f23f7f65c14a293450807d3ae/third_party/WebKit/LayoutTests/mojo/intercept-interface-for-worker.html [modify] https://crrev.com/4c5f5165ec688c2f23f7f65c14a293450807d3ae/third_party/WebKit/LayoutTests/mojo/resources/bind-intercepted-interface-in-worker.js [add] https://crrev.com/4c5f5165ec688c2f23f7f65c14a293450807d3ae/third_party/WebKit/LayoutTests/mojo/resources/expect-test-reply.js [add] https://crrev.com/4c5f5165ec688c2f23f7f65c14a293450807d3ae/third_party/WebKit/LayoutTests/mojo/resources/helpers.js [modify] https://crrev.com/4c5f5165ec688c2f23f7f65c14a293450807d3ae/third_party/WebKit/Source/core/mojo/test/MojoInterfaceInterceptor.cpp [modify] https://crrev.com/4c5f5165ec688c2f23f7f65c14a293450807d3ae/third_party/WebKit/Source/core/mojo/test/MojoInterfaceInterceptor.h [modify] https://crrev.com/4c5f5165ec688c2f23f7f65c14a293450807d3ae/third_party/WebKit/Source/core/mojo/test/MojoInterfaceInterceptor.idl
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/266c53aeb61c82a3b5b7f2c911a465313b2c4f17 commit 266c53aeb61c82a3b5b7f2c911a465313b2c4f17 Author: Reilly Grant <reillyg@chromium.org> Date: Tue Oct 17 21:18:57 2017 Enable more MojoJS LayoutTests with Network Service These tests were disabled because they relied on the AMD module loading path used by the old Mojo JS bindings. Now that they have been ported to the new Mojo JS bindings the tests should pass. TBR=jam@chromium.org NOTRY=true Bug: 758675 Change-Id: I62474d6bc923f4198c22d3c0096d5ce1d2040ced Reviewed-on: https://chromium-review.googlesource.com/723868 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#509535} [modify] https://crrev.com/266c53aeb61c82a3b5b7f2c911a465313b2c4f17/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
,
Nov 7 2017
,
Nov 7 2017
Apologies, applied the wrong component in bulk.
,
Dec 6 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by yzshen@chromium.org
, Aug 24 2017