Improvements to OOP HP trace format |
||
Issue description1) Emit fewer stacks. Stacks with small size + count are not very interesting. When there are too many stacks, the compressed trace size is very large [10MB+] and it's not possible to use the chrome://tracing UI to view the stack traces. 2) Reverse the order of stack frames [they are backwards right now!] 3) Hook up PartitionAlloc/Oilpan DumpProvider. 4) Plumb through the "type" for stacks, which should be the component for MallocDumpProvider, and Object type for PartitionAlloc/Oilpan.
,
Aug 24 2017
Please note that tasks (3) and (4) are also duplicated in Issue 758739. Let's track those there instead of here.
,
Aug 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52e458344ed0d5e2c6e9882c637a99dad1f3ae05 commit 52e458344ed0d5e2c6e9882c637a99dad1f3ae05 Author: Etienne Bergeron <etienneb@chromium.org> Date: Mon Aug 28 21:25:49 2017 Filter irrelevant nodes from the JSon exporter. The goal of this CL is to add nodes filtering for allocations that won't be useful for digging into memory bugs. This is an optimisation to reduce the size of a trace. R=erikchen@chromium.org, brettw@chromium.org Bug: 758657 Change-Id: I78b4529d1d6a11d8fd5dcb658d57f69dc90e4a94 Reviewed-on: https://chromium-review.googlesource.com/634211 Reviewed-by: Erik Chen <erikchen@chromium.org> Reviewed-by: Brett Wilson <brettw@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#497881} [modify] https://crrev.com/52e458344ed0d5e2c6e9882c637a99dad1f3ae05/chrome/profiling/json_exporter.cc [modify] https://crrev.com/52e458344ed0d5e2c6e9882c637a99dad1f3ae05/chrome/profiling/json_exporter.h [modify] https://crrev.com/52e458344ed0d5e2c6e9882c637a99dad1f3ae05/chrome/profiling/json_exporter_unittest.cc [modify] https://crrev.com/52e458344ed0d5e2c6e9882c637a99dad1f3ae05/chrome/profiling/memlog_connection_manager.cc
,
Sep 6 2017
task 1 and 2 are completed. Task 3 and 4 are moved to Issue 758739. Closing this bug.
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ba0b9ecdf464b70a4eb04a4fcbd69f6bc7e3ac8 commit 7ba0b9ecdf464b70a4eb04a4fcbd69f6bc7e3ac8 Author: Etienne Bergeron <etienneb@chromium.org> Date: Wed Sep 06 19:29:47 2017 Output stackframe in reverse order. The stackframe were outputted in the reverse order in the Heap Profiler. We are doing the same in OOP HP to keep the tooling working. R=Erikchen@chromium.org, brettw@chromium.org Bug: 758657 Change-Id: Ia5caa3a3d7f5892783e10d07173a3436317a3bce Reviewed-on: https://chromium-review.googlesource.com/653597 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Reviewed-by: Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#500041} [modify] https://crrev.com/7ba0b9ecdf464b70a4eb04a4fcbd69f6bc7e3ac8/chrome/profiling/json_exporter.cc [modify] https://crrev.com/7ba0b9ecdf464b70a4eb04a4fcbd69f6bc7e3ac8/chrome/profiling/json_exporter_unittest.cc |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Aug 24 2017