NOTREACHED in CloudPolicyRefreshScheduler::PerformRefresh |
|||||
Issue description
Running local build dcheck_always_on=true, after a "while" my browser bails at location of "<<< HERE"
void CloudPolicyRefreshScheduler::PerformRefresh() {
CancelRefresh();
if (client_->is_registered()) {
// Update |last_refresh_| so another fetch isn't triggered inadvertently.
UpdateLastRefresh();
// The result of this operation will be reported through a callback, at
// which point the next refresh will be scheduled.
client_->FetchPolicy();
return;
}
// This should never happen, as the registration change should have been
// handled via OnRegistrationStateChanged().
NOTREACHED(); <<< HERE
}
,
Aug 24 2017
,
Aug 25 2017
,
Sep 1 2017
This hit me again this morning, see https://crash/7d5ad949f0897316 - though I may have been running a private build by that time.
,
Sep 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3642258c5111a92937eb6662100fb5836c78e1ad commit 3642258c5111a92937eb6662100fb5836c78e1ad Author: Igor <igorcov@chromium.org> Date: Tue Sep 05 15:02:54 2017 Fixed the IPAddressChanged for unregistered client The client must be registered in order to reschedule the refresh interval when IP address changed. Bug: chromium:758649 Test: Unit test Change-Id: I65ecd5685aacc5699bef8bc8e2932934ce44abb7 Reviewed-on: https://chromium-review.googlesource.com/635264 Reviewed-by: Igor <igorcov@chromium.org> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#499633} [modify] https://crrev.com/3642258c5111a92937eb6662100fb5836c78e1ad/components/policy/core/common/cloud/cloud_policy_refresh_scheduler.cc [modify] https://crrev.com/3642258c5111a92937eb6662100fb5836c78e1ad/components/policy/core/common/cloud/cloud_policy_refresh_scheduler.h [modify] https://crrev.com/3642258c5111a92937eb6662100fb5836c78e1ad/components/policy/core/common/cloud/cloud_policy_refresh_scheduler_unittest.cc
,
Sep 5 2017
Thank you for reporting this. It should be fixed now.
,
Sep 5 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by siggi@chromium.org
, Aug 24 2017Owner: igorcov@chromium.org