TwoClientPreferencesSyncTest.SingleClientEnabledEncryptionBothChanged_E2ETest is failing on waterfall |
|||
Issue descriptionLog preview: [28739:28739:0823/204755.403206:INFO:CONSOLE(7)] "SW registered", source: https://www.google.com/_/chrome/newtab?espv=2&ie=UTF-8 (7) [28739:28739:0823/204755.928960:ERROR:CONSOLE(1)] "Uncaught ReferenceError: inline is not defined", source: (1) ../../chrome/browser/sync/test/integration/two_client_preferences_sync_test.cc:130: Failure Value of: BooleanPrefMatches(prefs::kHomePageIsNewTabPage) Actual: false Expected: true [28739:28739:0823/204758.398796:INFO:profile_sync_service.cc(1239)] ProfileSyncService::Observe Sync Configure aborted [28739:28739:0823/204758.663881:WARNING:signin_manager.cc(213)] Revoking refresh token on server. Reason: sign out, IsSigninAllowed: 1 [28739:28739:0823/204758.843990:INFO:sync_scheduler_impl.cc(133)] Scheduling next sync for CryptAuth Enrollment: Strategy: Aggressive Recovery Time Delta: 0 seconds Previous Failures: 1 [28739:28739:0823/204758.851495:ERROR:event_page_request_manager.cc(153)] An error encountered while waking the event page. [28739:28739:0823/204758.851554:ERROR:event_page_request_manager.cc(95)] Draining request queue. (queue-length=2) [28739:28739:0823/204758.906061:INFO:chrome_cryptauth_service.cc(222)] Profile is not authenticated yet; waiting before starting CryptAuth managers. [28739:28739:0823/204758.912706:ERROR:event_page_request_manager.cc(153)] An error encountered while waking the event page. [28739:28739:0823/204758.912747:ERROR:event_page_request_manager.cc(95)] Draining request queue. (queue-length=2) [28739:28739:0823/204758.969148:INFO:chrome_cryptauth_service.cc(222)] Profile is not authenticated yet; waiting before starting CryptAuth managers. [28739:28739:0823/204758.973455:ERROR:event_page_request_manager.cc(153)] An error encountered while waking the event page. [28739:28739:0823/204758.973493:ERROR:event_page_request_manager.cc(95)] Draining request queue. (queue-length=2) [ FAILED ] TwoClientPreferencesSyncTest.SingleClientEnabledEncryptionBothChanged_E2ETest, where TypeParam = and GetParam() = (41407 ms) View full log here: https://uberchromegw.corp.google.com/i/internal.client.kitchensync/builders/Linux%20Canary/builds/40224/steps/sync_integration_tests/logs/TwoClientPreferencesSyncTest.SingleClientEnabledEncryptionBothChanged_E2ETest
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4de8f867f92ac267190119e511f29c546a570a16 commit 4de8f867f92ac267190119e511f29c546a570a16 Author: Sky Malice <skym@chromium.org> Date: Wed Sep 06 00:32:47 2017 [Sync] Fix race in SingleClientEnabledEncryptionBothChanged. I have not been able to reproduce this failure myself, the only failures have been the kitchen sync bots. My theory is this test case contained a race condition for client "1" (the second client). Client 0 would enable encryption, and then change kHomePageIsNewTabPage pref. We cannot make any assumptions about if the encryption change and the pref update are going to arrive in the same GetUpdates to client "1" or not. If they arrive in separate GetUpdates, the first which just contains the encryption change will be enough to pass the AwaitEncryptionComplete() call, which will send us towards the BooleanPrefMatches that can now fail, because the pref update is not on client "1" yet. The fix here is simply to check via a checker that waits, as most of the validation in these test cases is done. Bug: 758639 Change-Id: I4f8c77bf9ff65e45a6485b1d699b8d2baaddabd0 Reviewed-on: https://chromium-review.googlesource.com/651787 Reviewed-by: Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#499815} [modify] https://crrev.com/4de8f867f92ac267190119e511f29c546a570a16/chrome/browser/sync/test/integration/two_client_preferences_sync_test.cc
,
Sep 6 2017
Maybe this is fixed? The last two runs succeeded. Closing this, but I'll also keep an eye on the Linux KitchenSync bots for a few days.
,
Sep 14 2017
Issue 736019 has been merged into this issue. |
|||
►
Sign in to add a comment |
|||
Comment 1 by s...@chromium.org
, Aug 30 2017Status: Assigned (was: Untriaged)